[PATCH] tools/perf/util/addr_location.c: update outdated comment

Julia Lawall posted 1 patch 1 month, 1 week ago
tools/perf/util/addr_location.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tools/perf/util/addr_location.c: update outdated comment
Posted by Julia Lawall 1 month, 1 week ago
The function addr_location__put() was renamed addr_location__exit()
in commit 0dd5041c9a0e ("perf addr_location: Add init/exit/copy
functions").  Make the comment preceding the function consistent with
the function itself.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 tools/perf/util/addr_location.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/addr_location.c b/tools/perf/util/addr_location.c
index 007a2f5df9a6..81a0b79c5e10 100644
--- a/tools/perf/util/addr_location.c
+++ b/tools/perf/util/addr_location.c
@@ -24,7 +24,7 @@ void addr_location__init(struct addr_location *al)
  * The preprocess_sample method will return with reference counts for the
  * in it, when done using (and perhaps getting ref counts if needing to
  * keep a pointer to one of those entries) it must be paired with
- * addr_location__put(), so that the refcounts can be decremented.
+ * addr_location__exit(), so that the refcounts can be decremented.
  */
 void addr_location__exit(struct addr_location *al)
 {
Re: [PATCH] tools/perf/util/addr_location.c: update outdated comment
Posted by Ian Rogers 1 month, 1 week ago
On Tue, Dec 30, 2025 at 8:52 AM Julia Lawall <Julia.Lawall@inria.fr> wrote:
>
> The function addr_location__put() was renamed addr_location__exit()
> in commit 0dd5041c9a0e ("perf addr_location: Add init/exit/copy
> functions").  Make the comment preceding the function consistent with
> the function itself.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/util/addr_location.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/addr_location.c b/tools/perf/util/addr_location.c
> index 007a2f5df9a6..81a0b79c5e10 100644
> --- a/tools/perf/util/addr_location.c
> +++ b/tools/perf/util/addr_location.c
> @@ -24,7 +24,7 @@ void addr_location__init(struct addr_location *al)
>   * The preprocess_sample method will return with reference counts for the
>   * in it, when done using (and perhaps getting ref counts if needing to
>   * keep a pointer to one of those entries) it must be paired with
> - * addr_location__put(), so that the refcounts can be decremented.
> + * addr_location__exit(), so that the refcounts can be decremented.
>   */
>  void addr_location__exit(struct addr_location *al)
>  {
>
Re: [PATCH] tools/perf/util/addr_location.c: update outdated comment
Posted by Arnaldo Carvalho de Melo 3 weeks, 5 days ago
On Thu, Jan 01, 2026 at 04:07:07PM -0800, Ian Rogers wrote:
> On Tue, Dec 30, 2025 at 8:52 AM Julia Lawall <Julia.Lawall@inria.fr> wrote:
> >
> > The function addr_location__put() was renamed addr_location__exit()
> > in commit 0dd5041c9a0e ("perf addr_location: Add init/exit/copy
> > functions").  Make the comment preceding the function consistent with
> > the function itself.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next,

- Arnaldo