[PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference

Julia Lawall posted 1 patch 1 month, 1 week ago
drivers/md/dm-vdo/data-vio.h |    4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference
Posted by Julia Lawall 1 month, 1 week ago
There is no function advance_compression_stage().  But
advance_data_vio_compression_stage() does iterate through
the values of the data_vio_compression_stage enum, so it
seems to be what was intended.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 drivers/md/dm-vdo/data-vio.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/md/dm-vdo/data-vio.h b/drivers/md/dm-vdo/data-vio.h
index 067b983bb291..58a1ac806885 100644
--- a/drivers/md/dm-vdo/data-vio.h
+++ b/drivers/md/dm-vdo/data-vio.h
@@ -88,8 +88,8 @@ struct zoned_pbn {
 };
 
 /*
- * Where a data_vio is on the compression path; advance_compression_stage() depends on the order of
- * this enum.
+ * Where a data_vio is on the compression path; advance_data_vio_compression_stage()
+ * depends on the order of this enum.
  */
 enum data_vio_compression_stage {
 	/* A data_vio which has not yet entered the compression path */
Re: [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference
Posted by Matthew Sakai 1 month ago
On 12/30/25 10:22 AM, Julia Lawall wrote:
> There is no function advance_compression_stage().  But
> advance_data_vio_compression_stage() does iterate through
> the values of the data_vio_compression_stage enum, so it
> seems to be what was intended.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

We must have missed this comment when we were renaming functions a few 
years ago.

Reviewed-by: Matthew Sakai <msakai@redhat.com>

> ---
>   drivers/md/dm-vdo/data-vio.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-vdo/data-vio.h b/drivers/md/dm-vdo/data-vio.h
> index 067b983bb291..58a1ac806885 100644
> --- a/drivers/md/dm-vdo/data-vio.h
> +++ b/drivers/md/dm-vdo/data-vio.h
> @@ -88,8 +88,8 @@ struct zoned_pbn {
>   };
>   
>   /*
> - * Where a data_vio is on the compression path; advance_compression_stage() depends on the order of
> - * this enum.
> + * Where a data_vio is on the compression path; advance_data_vio_compression_stage()
> + * depends on the order of this enum.
>    */
>   enum data_vio_compression_stage {
>   	/* A data_vio which has not yet entered the compression path */
>