[PATCH] ocfs2: adjust function name reference

Julia Lawall posted 1 patch 1 month, 1 week ago
fs/ocfs2/dlm/dlmdomain.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ocfs2: adjust function name reference
Posted by Julia Lawall 1 month, 1 week ago
There is no function dlm_mast_regions().  However,
dlm_match_regions() is passed the buffer "local",
which it uses internally, so it seems like
dlm_match_regions() was intended.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 fs/ocfs2/dlm/dlmdomain.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c
index 2347a50f079b..cf3ca2f597c2 100644
--- a/fs/ocfs2/dlm/dlmdomain.c
+++ b/fs/ocfs2/dlm/dlmdomain.c
@@ -1105,7 +1105,7 @@ static int dlm_query_region_handler(struct o2net_msg *msg, u32 len,
 	mlog(0, "Node %u queries hb regions on domain %s\n", qr->qr_node,
 	     qr->qr_domain);
 
-	/* buffer used in dlm_mast_regions() */
+	/* buffer used in dlm_match_regions() */
 	local = kmalloc(sizeof(qr->qr_regions), GFP_KERNEL);
 	if (!local)
 		return -ENOMEM;
Re: [PATCH] ocfs2: adjust function name reference
Posted by Joseph Qi 1 month ago

On 2025/12/30 22:25, Julia Lawall wrote:
> There is no function dlm_mast_regions().  However,
> dlm_match_regions() is passed the buffer "local",
> which it uses internally, so it seems like
> dlm_match_regions() was intended.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> 
> ---
>  fs/ocfs2/dlm/dlmdomain.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c
> index 2347a50f079b..cf3ca2f597c2 100644
> --- a/fs/ocfs2/dlm/dlmdomain.c
> +++ b/fs/ocfs2/dlm/dlmdomain.c
> @@ -1105,7 +1105,7 @@ static int dlm_query_region_handler(struct o2net_msg *msg, u32 len,
>  	mlog(0, "Node %u queries hb regions on domain %s\n", qr->qr_node,
>  	     qr->qr_domain);
>  
> -	/* buffer used in dlm_mast_regions() */
> +	/* buffer used in dlm_match_regions() */
>  	local = kmalloc(sizeof(qr->qr_regions), GFP_KERNEL);
>  	if (!local)
>  		return -ENOMEM;
>