The code just below the comment sets chip->pipe_alloc_mask to 0 and
then calls restore_dsp_rettings, so it seems that restore_dsp_rettings
is what was intended.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---

The code in restore_dsp_rettings() looks like restore_dsp_settings()
might be a more appropriate name.  If it is preferred to change that,
I would be happy to redo the patch.

 sound/pci/echoaudio/echoaudio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index f2c8602a1ad7..65a73faf2027 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -2155,7 +2155,7 @@ static int snd_echo_resume(struct device *dev)
 	}
 
 	/* Temporarily set chip->pipe_alloc_mask=0 otherwise
-	 * restore_dsp_settings() fails.
+	 * restore_dsp_rettings() fails.
 	 */
 	pipe_alloc_mask = chip->pipe_alloc_mask;
 	chip->pipe_alloc_mask = 0;

On Tue, 30 Dec 2025 14:35:25 +0100,
Julia Lawall wrote:
> 
> The code just below the comment sets chip->pipe_alloc_mask to 0 and
> then calls restore_dsp_rettings, so it seems that restore_dsp_rettings
> is what was intended.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> 
> ---
> 
> The code in restore_dsp_rettings() looks like restore_dsp_settings()
> might be a more appropriate name.  If it is preferred to change that,
> I would be happy to redo the patch.

Yes, let's correct the typo in the function name itself.
Please submit another version.


thanks,

Takashi