arm64: dts: qcom: sm6125-ginkgo: Fix missing msm-id subtype

[PATCH RFT] arm64: dts: qcom: sm6125-ginkgo: Fix missing msm-id subtype

Posted by Krzysztof Kozlowski 1 month, 1 week ago

qcom,msm-id property must consist of two numbers, where the second
number is the subtype, as reported by dtbs_check:

  sm6125-xiaomi-ginkgo.dtb: / (xiaomi,ginkgo): qcom,msm-id:0: [394] is too short

Xiaomi vendor DTS for Trinket IDP and QRD boards uses value of 0x10000,
so put it here as well.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
index 68a237215bd1..6b68e391cf3e 100644
--- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
+++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
@@ -19,7 +19,7 @@ / {
 	chassis-type = "handset";
 
 	/* required for bootloader to select correct board */
-	qcom,msm-id = <QCOM_ID_SM6125>;
+	qcom,msm-id = <QCOM_ID_SM6125 0x10000>;
 	qcom,board-id = <22 0>;
 
 	chosen {
-- 
2.51.0

Re: [PATCH RFT] arm64: dts: qcom: sm6125-ginkgo: Fix missing msm-id subtype

Posted by Bjorn Andersson 3 weeks, 3 days ago

On Mon, 29 Dec 2025 15:28:07 +0100, Krzysztof Kozlowski wrote:
> qcom,msm-id property must consist of two numbers, where the second
> number is the subtype, as reported by dtbs_check:
> 
>   sm6125-xiaomi-ginkgo.dtb: / (xiaomi,ginkgo): qcom,msm-id:0: [394] is too short
> 
> Xiaomi vendor DTS for Trinket IDP and QRD boards uses value of 0x10000,
> so put it here as well.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm6125-ginkgo: Fix missing msm-id subtype
      commit: 2c3b8260d1a0d9a388f2d30e3bbe50d93edfa2aa

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH RFT] arm64: dts: qcom: sm6125-ginkgo: Fix missing msm-id subtype

Posted by Krzysztof Kozlowski 3 weeks, 4 days ago

On 29/12/2025 15:28, Krzysztof Kozlowski wrote:
> qcom,msm-id property must consist of two numbers, where the second
> number is the subtype, as reported by dtbs_check:
> 
>   sm6125-xiaomi-ginkgo.dtb: / (xiaomi,ginkgo): qcom,msm-id:0: [394] is too short
> 
> Xiaomi vendor DTS for Trinket IDP and QRD boards uses value of 0x10000,
> so put it here as well.


So I guess reviews from:
https://lore.kernel.org/all/6mxiysnjmrije7hz3opgaw3f5kn6p4glgoivxvnizrkjtjiywe@5qgj4jxfxa2m/

apply here...

Best regards,
Krzysztof

Re: [PATCH RFT] arm64: dts: qcom: sm6125-ginkgo: Fix missing msm-id subtype

Posted by Konrad Dybcio 1 month, 1 week ago

On 12/29/25 3:28 PM, Krzysztof Kozlowski wrote:
> qcom,msm-id property must consist of two numbers, where the second
> number is the subtype, as reported by dtbs_check:
> 
>   sm6125-xiaomi-ginkgo.dtb: / (xiaomi,ginkgo): qcom,msm-id:0: [394] is too short
> 
> Xiaomi vendor DTS for Trinket IDP and QRD boards uses value of 0x10000,
> so put it here as well.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> index 68a237215bd1..6b68e391cf3e 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> @@ -19,7 +19,7 @@ / {
>  	chassis-type = "handset";
>  
>  	/* required for bootloader to select correct board */
> -	qcom,msm-id = <QCOM_ID_SM6125>;
> +	qcom,msm-id = <QCOM_ID_SM6125 0x10000>;

+Gabriel (the original contributor)

could you please confirm the phone still boots with that?

Konrad