[PATCH v1 0/7] auxdisplay: arm-charlcd: refactor with modern APIs

Andy Shevchenko posted 7 patches 1 month, 1 week ago
drivers/auxdisplay/arm-charlcd.c | 96 ++++++++++----------------------
1 file changed, 28 insertions(+), 68 deletions(-)
[PATCH v1 0/7] auxdisplay: arm-charlcd: refactor with modern APIs
Posted by Andy Shevchenko 1 month, 1 week ago
The whole series was induced by the Geert's report on one mistake
in the error path. I looked closely and found a room to refactor
the whole driver to use modern style and APIs.

Not tested.

Andy Shevchenko (7):
  auxdisplay: arm-charlcd: convert to use device managed APIs
  auxdisplay: arm-charlcd: Remove unneeded info message
  auxdisplay: arm-charlcd: drop of_match_ptr()
  auxdisplay: arm-charlcd: Don't use "proxy" headers
  auxdisplay: arm-charlcd: Use readl_poll_timeout
  auxdisplay: arm-charlcd: Join string literals back
  auxdisplay: arm-charlcd: Remove redundant ternary operators

 drivers/auxdisplay/arm-charlcd.c | 96 ++++++++++----------------------
 1 file changed, 28 insertions(+), 68 deletions(-)

-- 
2.50.1
Re: [PATCH v1 0/7] auxdisplay: arm-charlcd: refactor with modern APIs
Posted by Andy Shevchenko 1 month ago
On Mon, Dec 29, 2025 at 02:52:33PM +0100, Andy Shevchenko wrote:
> The whole series was induced by the Geert's report on one mistake
> in the error path. I looked closely and found a room to refactor
> the whole driver to use modern style and APIs.

For so long I have got no CI reports and no comments, I'm going to push this
series tomorrow to the repository. Feel free to tell if there is any problem
with that.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/7] auxdisplay: arm-charlcd: refactor with modern APIs
Posted by Andy Shevchenko 1 month ago
On Wed, Jan 07, 2026 at 11:06:56PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 29, 2025 at 02:52:33PM +0100, Andy Shevchenko wrote:
> > The whole series was induced by the Geert's report on one mistake
> > in the error path. I looked closely and found a room to refactor
> > the whole driver to use modern style and APIs.
> 
> For so long I have got no CI reports and no comments, I'm going to push this
> series tomorrow to the repository. Feel free to tell if there is any problem
> with that.

If I'm not mistaken, Linus might want to have a look... Cc'ing him.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/7] auxdisplay: arm-charlcd: refactor with modern APIs
Posted by Linus Walleij 4 weeks, 1 day ago
On Wed, Jan 7, 2026 at 10:08 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Jan 07, 2026 at 11:06:56PM +0200, Andy Shevchenko wrote:
> > On Mon, Dec 29, 2025 at 02:52:33PM +0100, Andy Shevchenko wrote:
> > > The whole series was induced by the Geert's report on one mistake
> > > in the error path. I looked closely and found a room to refactor
> > > the whole driver to use modern style and APIs.
> >
> > For so long I have got no CI reports and no comments, I'm going to push this
> > series tomorrow to the repository. Feel free to tell if there is any problem
> > with that.
>
> If I'm not mistaken, Linus might want to have a look... Cc'ing him.

I haven't had time to look at it because it's not in my inbox, sorry.

On the other hand, I trust you more than most developers so I'm pretty
sure I would just ACK it anyways.

Yours,
Linus Walleij
Re: [PATCH v1 0/7] auxdisplay: arm-charlcd: refactor with modern APIs
Posted by Andy Shevchenko 4 weeks ago
On Fri, Jan 9, 2026 at 4:30 PM Linus Walleij <linusw@kernel.org> wrote:
> On Wed, Jan 7, 2026 at 10:08 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Jan 07, 2026 at 11:06:56PM +0200, Andy Shevchenko wrote:
> > > On Mon, Dec 29, 2025 at 02:52:33PM +0100, Andy Shevchenko wrote:
> > > > The whole series was induced by the Geert's report on one mistake
> > > > in the error path. I looked closely and found a room to refactor
> > > > the whole driver to use modern style and APIs.
> > >
> > > For so long I have got no CI reports and no comments, I'm going to push this
> > > series tomorrow to the repository. Feel free to tell if there is any problem
> > > with that.
> >
> > If I'm not mistaken, Linus might want to have a look... Cc'ing him.
>
> I haven't had time to look at it because it's not in my inbox, sorry.

No, it's me who should say "sorry". I have told you about the old
address (you are the author, if I'm not mistaken), but I forgot to Cc
you with a new one. Of course, you can use `b4 mbox $MSG_ID` to
retrieve this whole thread, but I admit a bit of inconvenience.

> On the other hand, I trust you more than most developers so I'm pretty
> sure I would just ACK it anyways.

Thanks!

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/7] auxdisplay: arm-charlcd: refactor with modern APIs
Posted by Andy Shevchenko 4 weeks, 1 day ago
On Wed, Jan 07, 2026 at 11:08:20PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 07, 2026 at 11:06:56PM +0200, Andy Shevchenko wrote:
> > On Mon, Dec 29, 2025 at 02:52:33PM +0100, Andy Shevchenko wrote:
> > > The whole series was induced by the Geert's report on one mistake
> > > in the error path. I looked closely and found a room to refactor
> > > the whole driver to use modern style and APIs.
> > 
> > For so long I have got no CI reports and no comments, I'm going to push this
> > series tomorrow to the repository. Feel free to tell if there is any problem
> > with that.
> 
> If I'm not mistaken, Linus might want to have a look... Cc'ing him.

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko