[PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS

Pradeep P V K posted 4 patches 1 month, 1 week ago
[PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS
Posted by Pradeep P V K 1 month, 1 week ago
Enable UFS for HAMOA-IOT-EVK board.

Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
index 36dd6599402b..2b1e643975d9 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
@@ -1190,6 +1190,24 @@ &uart21 {
 	status = "okay";
 };
 
+&ufs_mem_phy {
+	vdda-phy-supply = <&vreg_l3i_0p8>;
+	vdda-pll-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&ufs_mem_hc {
+	reset-gpios = <&tlmm 238 GPIO_ACTIVE_LOW>;
+
+	vcc-supply = <&vreg_l17b_2p5>;
+	vcc-max-microamp = <1300000>;
+	vccq-supply = <&vreg_l2i_1p2>;
+	vccq-max-microamp = <1200000>;
+
+	status = "okay";
+};
+
 &usb_1_ss0_dwc3_hs {
 	remote-endpoint = <&pmic_glink_ss0_hs_in>;
 };
-- 
2.34.1
Re: [PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS
Posted by Konrad Dybcio 1 month, 1 week ago
On 12/29/25 7:06 AM, Pradeep P V K wrote:
> Enable UFS for HAMOA-IOT-EVK board.
> 
> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
> ---

[...]

> +&ufs_mem_hc {
> +	reset-gpios = <&tlmm 238 GPIO_ACTIVE_LOW>;
> +
> +	vcc-supply = <&vreg_l17b_2p5>;
> +	vcc-max-microamp = <1300000>;

I think they should both be 1.2 A peak

Konrad

> +	vccq-supply = <&vreg_l2i_1p2>;
> +	vccq-max-microamp = <1200000>;
> +
> +	status = "okay";
> +};
> +
>  &usb_1_ss0_dwc3_hs {
>  	remote-endpoint = <&pmic_glink_ss0_hs_in>;
>  };
Re: [PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS
Posted by Pradeep Pragallapati 1 month, 1 week ago
On 12/29/2025 5:47 PM, Konrad Dybcio wrote:
> On 12/29/25 7:06 AM, Pradeep P V K wrote:
>> Enable UFS for HAMOA-IOT-EVK board.
>>
>> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
>> ---
> [...]
>
>> +&ufs_mem_hc {
>> +	reset-gpios = <&tlmm 238 GPIO_ACTIVE_LOW>;
>> +
>> +	vcc-supply = <&vreg_l17b_2p5>;
>> +	vcc-max-microamp = <1300000>;
> I think they should both be 1.2 A peak
>
> Konrad
This (1.3 A) is as per Hamoa power grid, which is same as SM8550.
>> +	vccq-supply = <&vreg_l2i_1p2>;
>> +	vccq-max-microamp = <1200000>;
>> +
>> +	status = "okay";
>> +};
>> +
>>   &usb_1_ss0_dwc3_hs {
>>   	remote-endpoint = <&pmic_glink_ss0_hs_in>;
>>   };
Re: [PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS
Posted by Konrad Dybcio 1 month, 1 week ago
On 12/30/25 9:58 AM, Pradeep Pragallapati wrote:
> 
> On 12/29/2025 5:47 PM, Konrad Dybcio wrote:
>> On 12/29/25 7:06 AM, Pradeep P V K wrote:
>>> Enable UFS for HAMOA-IOT-EVK board.
>>>
>>> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
>>> ---
>> [...]
>>
>>> +&ufs_mem_hc {
>>> +    reset-gpios = <&tlmm 238 GPIO_ACTIVE_LOW>;
>>> +
>>> +    vcc-supply = <&vreg_l17b_2p5>;
>>> +    vcc-max-microamp = <1300000>;
>> I think they should both be 1.2 A peak
>>
>> Konrad
> This (1.3 A) is as per Hamoa power grid, which is same as SM8550.

Please check again, I opened the power grid tab in the internal
documentation source that shall remain nameless and it said 1200 mA
for both regulators

Konrad
Re: [PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS
Posted by Konrad Dybcio 1 month, 1 week ago
On 12/30/25 3:19 PM, Konrad Dybcio wrote:
> On 12/30/25 9:58 AM, Pradeep Pragallapati wrote:
>>
>> On 12/29/2025 5:47 PM, Konrad Dybcio wrote:
>>> On 12/29/25 7:06 AM, Pradeep P V K wrote:
>>>> Enable UFS for HAMOA-IOT-EVK board.
>>>>
>>>> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
>>>> ---
>>> [...]
>>>
>>>> +&ufs_mem_hc {
>>>> +    reset-gpios = <&tlmm 238 GPIO_ACTIVE_LOW>;
>>>> +
>>>> +    vcc-supply = <&vreg_l17b_2p5>;
>>>> +    vcc-max-microamp = <1300000>;
>>> I think they should both be 1.2 A peak
>>>
>>> Konrad
>> This (1.3 A) is as per Hamoa power grid, which is same as SM8550.
> 
> Please check again, I opened the power grid tab in the internal
> documentation source that shall remain nameless and it said 1200 mA
> for both regulators

My source indeed said 1.2 and Pradeep's source indeed said 1.3

Because we don't know the source of this disjoint information we
agreed to keep the higher value, especially since it was battle-tested

Konrad