mips: LOONGSON32: drop a dangling Kconfig symbol

[PATCH] mips: LOONGSON32: drop a dangling Kconfig symbol

Posted by Randy Dunlap 1 month, 1 week ago

CPU_GAS_LOAD_STORE_LR is not used anywhere in the kernel sources,
so drop it.

Fixes: 85c4354076ca ("MIPS: loongson32: Switch to generic core")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Keguang Zhang <keguang.zhang@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org

 arch/mips/Kconfig |    1 -
 1 file changed, 1 deletion(-)

--- linux-next-20251219.orig/arch/mips/Kconfig
+++ linux-next-20251219/arch/mips/Kconfig
@@ -1408,7 +1408,6 @@ config CPU_LOONGSON32
 	select CPU_MIPS32
 	select CPU_MIPSR2
 	select CPU_HAS_PREFETCH
-	select CPU_HAS_LOAD_STORE_LR
 	select CPU_SUPPORTS_32BIT_KERNEL
 	select CPU_SUPPORTS_HIGHMEM
 	select CPU_SUPPORTS_CPUFREQ

Re: [PATCH] mips: LOONGSON32: drop a dangling Kconfig symbol

Posted by Thomas Bogendoerfer 1 week, 1 day ago

On Sun, Dec 28, 2025 at 11:04:43AM -0800, Randy Dunlap wrote:
> CPU_GAS_LOAD_STORE_LR is not used anywhere in the kernel sources,
> so drop it.
> 
> Fixes: 85c4354076ca ("MIPS: loongson32: Switch to generic core")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Keguang Zhang <keguang.zhang@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> 
>  arch/mips/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-next-20251219.orig/arch/mips/Kconfig
> +++ linux-next-20251219/arch/mips/Kconfig
> @@ -1408,7 +1408,6 @@ config CPU_LOONGSON32
>  	select CPU_MIPS32
>  	select CPU_MIPSR2
>  	select CPU_HAS_PREFETCH
> -	select CPU_HAS_LOAD_STORE_LR
>  	select CPU_SUPPORTS_32BIT_KERNEL
>  	select CPU_SUPPORTS_HIGHMEM
>  	select CPU_SUPPORTS_CPUFREQ

applied to mips-next with the typo fixed
Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH] mips: LOONGSON32: drop a dangling Kconfig symbol

Posted by Maciej W. Rozycki 1 month ago

On Sun, 28 Dec 2025, Randy Dunlap wrote:

> CPU_GAS_LOAD_STORE_LR is not used anywhere in the kernel sources,

s/CPU_GAS_LOAD_STORE_LR/CPU_HAS_LOAD_STORE_LR/

  Maciej

Re: [PATCH] mips: LOONGSON32: drop a dangling Kconfig symbol

Posted by Randy Dunlap 1 month ago


On 1/2/26 5:26 PM, Maciej W. Rozycki wrote:
> On Sun, 28 Dec 2025, Randy Dunlap wrote:
> 
>> CPU_GAS_LOAD_STORE_LR is not used anywhere in the kernel sources,
> 
> s/CPU_GAS_LOAD_STORE_LR/CPU_HAS_LOAD_STORE_LR/

Aye, thanks. Will send v2.

-- 
~Randy

Re: [PATCH] mips: LOONGSON32: drop a dangling Kconfig symbol

Posted by Keguang Zhang 1 month, 1 week ago

It appears that CPU_HAS_LOAD_STORE_LR has been outdated since about 2020.

Reviewed-by: Keguang Zhang <keguang.zhang@gmail.com>


On Mon, Dec 29, 2025 at 3:04 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> CPU_GAS_LOAD_STORE_LR is not used anywhere in the kernel sources,
> so drop it.
>
> Fixes: 85c4354076ca ("MIPS: loongson32: Switch to generic core")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Keguang Zhang <keguang.zhang@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
>
>  arch/mips/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
>
> --- linux-next-20251219.orig/arch/mips/Kconfig
> +++ linux-next-20251219/arch/mips/Kconfig
> @@ -1408,7 +1408,6 @@ config CPU_LOONGSON32
>         select CPU_MIPS32
>         select CPU_MIPSR2
>         select CPU_HAS_PREFETCH
> -       select CPU_HAS_LOAD_STORE_LR
>         select CPU_SUPPORTS_32BIT_KERNEL
>         select CPU_SUPPORTS_HIGHMEM
>         select CPU_SUPPORTS_CPUFREQ



--
Best regards,

Keguang Zhang