[PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init()

Haoxiang Li posted 1 patch 1 month, 1 week ago
sound/hda/controllers/tegra.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init()
Posted by Haoxiang Li 1 month, 1 week ago
Add azx_free_stream_pages() to release the resources allocated
by azx_alloc_stream_pages().

Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
 sound/hda/controllers/tegra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/controllers/tegra.c b/sound/hda/controllers/tegra.c
index 6ab338f37db5..656cbd88b9aa 100644
--- a/sound/hda/controllers/tegra.c
+++ b/sound/hda/controllers/tegra.c
@@ -380,6 +380,7 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
 	/* codec detection */
 	if (!bus->codec_mask) {
 		dev_err(card->dev, "no codecs found!\n");
+		azx_free_stream_pages(chip);
 		return -ENODEV;
 	}
 
-- 
2.25.1
Re: [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init()
Posted by Takashi Iwai 1 month, 1 week ago
On Sun, 28 Dec 2025 15:05:30 +0100,
Haoxiang Li wrote:
> 
> Add azx_free_stream_pages() to release the resources allocated
> by azx_alloc_stream_pages().

It'll be already called later at the destructor hda_tegra_dev_free()
callback, so this change would be rather superfluous or harmful.


thanks,

Takashi
Re: [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init()
Posted by Markus Elfring 1 month, 1 week ago
> Add azx_free_stream_pages() to release the resources allocated

                              call?


> by azx_alloc_stream_pages().

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n145

Regards,
Markus