1. Patchew
  2. linux
  3. [PATCH v2 0/3] pinctrl: samsung: add Exynos9610 pinctrl support
  4. View patch

[PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node

Alexandru Chimac posted 3 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node
Posted by Alexandru Chimac 1 month, 1 week ago 
Add a dedicated compatible for the exynos9610-wakeup-eint node,
which is compatbile with Exynos850's implementation (and the
Exynos7 fallback).

Signed-off-by: Alexandru Chimac <alex@chimac.ro>
---
 .../devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
index f3c433015b12..deb2730855bd 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
@@ -48,6 +48,7 @@ properties:
           - enum:
               - google,gs101-wakeup-eint
               - samsung,exynos2200-wakeup-eint
+              - samsung,exynos9610-wakeup-eint
               - samsung,exynos9810-wakeup-eint
               - samsung,exynos990-wakeup-eint
               - samsung,exynosautov9-wakeup-eint
@@ -107,6 +108,7 @@ allOf:
           contains:
             enum:
               - samsung,exynos850-wakeup-eint
+              - samsung,exynos9610-wakeup-eint
               - samsung,exynosautov920-wakeup-eint
     then:
       properties:

-- 
2.51.0
Re: [PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node
Posted by Krzysztof Kozlowski 1 month, 1 week ago 
On Sun, Dec 28, 2025 at 06:05:52PM +0000, Alexandru Chimac wrote:
> Add a dedicated compatible for the exynos9610-wakeup-eint node,
> which is compatbile with Exynos850's implementation (and the
> Exynos7 fallback).
> 
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
>  .../devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> index f3c433015b12..deb2730855bd 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> @@ -48,6 +48,7 @@ properties:
>            - enum:
>                - google,gs101-wakeup-eint
>                - samsung,exynos2200-wakeup-eint
> +              - samsung,exynos9610-wakeup-eint
>                - samsung,exynos9810-wakeup-eint
>                - samsung,exynos990-wakeup-eint
>                - samsung,exynosautov9-wakeup-eint
> @@ -107,6 +108,7 @@ allOf:
>            contains:
>              enum:
>                - samsung,exynos850-wakeup-eint
> +              - samsung,exynos9610-wakeup-eint

This is not needed. Device has 850 fallback, no?


Best regards,
Krzysztof
Re: [PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node
Posted by Alexandru Chimac 1 month, 1 week ago 
On Tuesday, December 30th, 2025 at 11:51, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> 
> On Sun, Dec 28, 2025 at 06:05:52PM +0000, Alexandru Chimac wrote:
> 
> > Add a dedicated compatible for the exynos9610-wakeup-eint node,
> > which is compatbile with Exynos850's implementation (and the
> > Exynos7 fallback).
> > 
> > Signed-off-by: Alexandru Chimac alex@chimac.ro
> > ---
> > .../devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > index f3c433015b12..deb2730855bd 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > @@ -48,6 +48,7 @@ properties:
> > - enum:
> > - google,gs101-wakeup-eint
> > - samsung,exynos2200-wakeup-eint
> > + - samsung,exynos9610-wakeup-eint
> > - samsung,exynos9810-wakeup-eint
> > - samsung,exynos990-wakeup-eint
> > - samsung,exynosautov9-wakeup-eint
> > @@ -107,6 +108,7 @@ allOf:
> > contains:
> > enum:
> > - samsung,exynos850-wakeup-eint
> > + - samsung,exynos9610-wakeup-eint
> 
> 
> This is not needed. Device has 850 fallback, no?
It's not required, but I guess it would make the device tree look better. If this patch isn't to be merged, it doesn't functionally affect anything so it can just be dropped instead of requiring another patchset revision.
> 
> Best regards,
> Krzysztof
Best regards,
Alexandru Chimac
Re: [PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node
Posted by Krzysztof Kozlowski 1 month, 1 week ago 
On 31/12/2025 13:28, Alexandru Chimac wrote:
> On Tuesday, December 30th, 2025 at 11:51, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>>
>> On Sun, Dec 28, 2025 at 06:05:52PM +0000, Alexandru Chimac wrote:
>>
>>> Add a dedicated compatible for the exynos9610-wakeup-eint node,
>>> which is compatbile with Exynos850's implementation (and the
>>> Exynos7 fallback).
>>>
>>> Signed-off-by: Alexandru Chimac alex@chimac.ro
>>> ---
>>> .../devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> index f3c433015b12..deb2730855bd 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> @@ -48,6 +48,7 @@ properties:
>>> - enum:
>>> - google,gs101-wakeup-eint
>>> - samsung,exynos2200-wakeup-eint
>>> + - samsung,exynos9610-wakeup-eint
>>> - samsung,exynos9810-wakeup-eint
>>> - samsung,exynos990-wakeup-eint
>>> - samsung,exynosautov9-wakeup-eint
>>> @@ -107,6 +108,7 @@ allOf:
>>> contains:
>>> enum:
>>> - samsung,exynos850-wakeup-eint
>>> + - samsung,exynos9610-wakeup-eint
>>
>>
>> This is not needed. Device has 850 fallback, no?
> It's not required, but I guess it would make the device tree look better. If this patch isn't to be merged, it doesn't functionally affect anything so it can just be dropped instead of requiring another patchset revision.

Please wrap your replies.

I did not comment on the patch. Comments are in specific places
discussing specific lines. I asked why do you need this enum to grow?


Best regards,
Krzysztof
Re: [PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node
Posted by Alexandru Chimac 1 month, 1 week ago 




On Friday, January 2nd, 2026 at 12:02, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> 
> 
> On 31/12/2025 13:28, Alexandru Chimac wrote:
> 
> > On Tuesday, December 30th, 2025 at 11:51, Krzysztof Kozlowski krzk@kernel.org wrote:
> > 
> > > On Sun, Dec 28, 2025 at 06:05:52PM +0000, Alexandru Chimac wrote:
> > > 
> > > > Add a dedicated compatible for the exynos9610-wakeup-eint node,
> > > > which is compatbile with Exynos850's implementation (and the
> > > > Exynos7 fallback).
> > > > 
> > > > Signed-off-by: Alexandru Chimac alex@chimac.ro
> > > > ---
> > > > .../devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > > > index f3c433015b12..deb2730855bd 100644
> > > > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > > > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > > > @@ -48,6 +48,7 @@ properties:
> > > > - enum:
> > > > - google,gs101-wakeup-eint
> > > > - samsung,exynos2200-wakeup-eint
> > > > + - samsung,exynos9610-wakeup-eint
> > > > - samsung,exynos9810-wakeup-eint
> > > > - samsung,exynos990-wakeup-eint
> > > > - samsung,exynosautov9-wakeup-eint
> > > > @@ -107,6 +108,7 @@ allOf:
> > > > contains:
> > > > enum:
> > > > - samsung,exynos850-wakeup-eint
> > > > + - samsung,exynos9610-wakeup-eint
> > > 
> > > This is not needed. Device has 850 fallback, no?
> > > It's not required, but I guess it would make the device tree look better. If this patch isn't to be merged, it doesn't functionally affect anything so it can just be dropped instead of requiring another patchset revision.
> 
> 
> Please wrap your replies.
> 
> I did not comment on the patch. Comments are in specific places
> discussing specific lines. I asked why do you need this enum to grow?
Oh, sorry, I thought you meant the whole commit. Yeah, it looks wrong.
Thanks for noticing, I will fix it in v3.
> 
> 
> Best regards,
> Krzysztof
Best regards,
Alexandru Chimac

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.