[v2] drm/atomic: restrict the size of of gamma / degamma LUTs

[PATCH v2 0/3] drm/atomic: restrict the size of of gamma / degamma LUTs

Dmitry Baryshkov posted 3 patches 1 month, 1 week ago

Diff against v1 v1 v3
Download series mbox

There is a newer version of this series

.../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c    | 18 ++++++------
drivers/gpu/drm/drm_atomic_uapi.c                  | 32 ++++++++++++++++------
drivers/gpu/drm/drm_mode_object.c                  | 25 +++++++++++++++++
drivers/gpu/drm/drm_property.c                     | 11 ++++++++
include/drm/drm_mode_object.h                      |  3 ++
include/drm/drm_property.h                         |  1 +
6 files changed, 73 insertions(+), 17 deletions(-)

Expand all Fold all

[PATCH v2 0/3] drm/atomic: restrict the size of of gamma / degamma LUTs

Posted by Dmitry Baryshkov 1 month, 1 week ago

While picking up the Gamma correction patch for the msm driver I noticed
that kms_color@invalid-gamma-lut-sizes and
kms_color@invalid-degamma-lut-sizes tests fail. These tests attempt
submitting LUT tables greater than the size specified by the
corresponding property. The issue doesn't seem to be specific to msm
driver only. Add generic check that LUT size is not greater than the
size passed to drm_crtc_enable_color_mgmt().

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Changes in v2:
- Fixed comments for drm_object_immutable_property_get_value(), changed
  it to use drm_WARN_ON (Thomas)
- Reordered arguments of drm_property_replace_blob_from_id(), moving
  max_size before expected_size (Thomas)
- Link to v1: https://lore.kernel.org/r/20251115-drm-fix-lut-checks-v1-0-3586f5855bc7@oss.qualcomm.com,
  resent at https://lore.kernel.org/all/20251210-drm-fix-lut-checks-v1-0-10ae38519f43@oss.qualcomm.com/

---
Dmitry Baryshkov (3):
      drm/mode_object: add drm_object_immutable_property_get_value()
      drm/atomic: add max_size check to drm_property_replace_blob_from_id()
      drm/atomic: verify that gamma/degamma LUTs are not too big

 .../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c    | 18 ++++++------
 drivers/gpu/drm/drm_atomic_uapi.c                  | 32 ++++++++++++++++------
 drivers/gpu/drm/drm_mode_object.c                  | 25 +++++++++++++++++
 drivers/gpu/drm/drm_property.c                     | 11 ++++++++
 include/drm/drm_mode_object.h                      |  3 ++
 include/drm/drm_property.h                         |  1 +
 6 files changed, 73 insertions(+), 17 deletions(-)
---
base-commit: 130343ee6bca9895c47d314467db7dd3dcc8bc35
change-id: 20251114-drm-fix-lut-checks-4bb325e24110

Best regards,
-- 
With best wishes
Dmitry