[PATCH 4/4] serial: SH_SCI: improve "DMA support" prompt

Randy Dunlap posted 4 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 4/4] serial: SH_SCI: improve "DMA support" prompt
Posted by Randy Dunlap 1 month, 2 weeks ago
Having a prompt of "DMA support" suddenly appear during a
"make oldconfig" can be confusing. Add a little helpful text to
the prompt message.

Fixes: 73a19e4c0301 ("serial: sh-sci: Add DMA support.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-serial@vger.kernel.org

 drivers/tty/serial/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20251219.orig/drivers/tty/serial/Kconfig
+++ linux-next-20251219/drivers/tty/serial/Kconfig
@@ -671,7 +671,7 @@ config SERIAL_SH_SCI_EARLYCON
 	default ARCH_RENESAS
 
 config SERIAL_SH_SCI_DMA
-	bool "DMA support" if EXPERT
+	bool "DMA support on SuperH SCI(F)" if EXPERT
 	depends on SERIAL_SH_SCI && DMA_ENGINE
 	default ARCH_RENESAS
Re: [PATCH 4/4] serial: SH_SCI: improve "DMA support" prompt
Posted by Geert Uytterhoeven 1 month ago
Hi Randy,

On Sat, 27 Dec 2025 at 21:25, Randy Dunlap <rdunlap@infradead.org> wrote:
> Having a prompt of "DMA support" suddenly appear during a
> "make oldconfig" can be confusing. Add a little helpful text to
> the prompt message.
>
> Fixes: 73a19e4c0301 ("serial: sh-sci: Add DMA support.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Thanks for your patch!

> --- linux-next-20251219.orig/drivers/tty/serial/Kconfig
> +++ linux-next-20251219/drivers/tty/serial/Kconfig
> @@ -671,7 +671,7 @@ config SERIAL_SH_SCI_EARLYCON
>         default ARCH_RENESAS
>
>  config SERIAL_SH_SCI_DMA
> -       bool "DMA support" if EXPERT
> +       bool "DMA support on SuperH SCI(F)" if EXPERT

Perhaps reword to "Support for DMA on SuperH SCI(F)", to match
the surrounding options?

>         depends on SERIAL_SH_SCI && DMA_ENGINE
>         default ARCH_RENESAS

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH 4/4] serial: SH_SCI: improve "DMA support" prompt
Posted by Randy Dunlap 1 month ago

On 1/5/26 8:51 AM, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> On Sat, 27 Dec 2025 at 21:25, Randy Dunlap <rdunlap@infradead.org> wrote:
>> Having a prompt of "DMA support" suddenly appear during a
>> "make oldconfig" can be confusing. Add a little helpful text to
>> the prompt message.
>>
>> Fixes: 73a19e4c0301 ("serial: sh-sci: Add DMA support.")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Thanks for your patch!
> 
>> --- linux-next-20251219.orig/drivers/tty/serial/Kconfig
>> +++ linux-next-20251219/drivers/tty/serial/Kconfig
>> @@ -671,7 +671,7 @@ config SERIAL_SH_SCI_EARLYCON
>>         default ARCH_RENESAS
>>
>>  config SERIAL_SH_SCI_DMA
>> -       bool "DMA support" if EXPERT
>> +       bool "DMA support on SuperH SCI(F)" if EXPERT
> 
> Perhaps reword to "Support for DMA on SuperH SCI(F)", to match
> the surrounding options?

OK. Thanks.

>>         depends on SERIAL_SH_SCI && DMA_ENGINE
>>         default ARCH_RENESAS
-- 
~Randy