Document the TPS65185. GPIO names are same as in the datasheet except for
the PWRUP pad which is described as "enable". That pin is optional because
the rising edge corresponds to setting one register bit and falling edge
to another register bit.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
.../devicetree/bindings/regulator/ti,tps65185.yaml | 99 ++++++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml
new file mode 100644
index 000000000000..7cc5a895c2fc
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps65185.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI TPS65185 Power Management Integrated Circuit
+
+maintainers:
+ - Andreas Kemnade <andreas@kemnade.info>
+
+description:
+ TPS65185 is a Power Management IC to provide Power for EPDs with one 3.3V
+ switch, 2 symmetric LDOs behind 2 DC/DC converters, and one unsymmetric
+ regulator for a compensation voltage.
+
+properties:
+ compatible:
+ const: ti,tps65185
+
+ reg:
+ maxItems: 1
+
+ enable-gpios:
+ description:
+ PWRUP pin
+ maxItems: 1
+
+ pwr-good-gpios:
+ maxItems: 1
+
+ vcom-ctrl-gpios:
+ maxItems: 1
+
+ wakeup-gpios:
+ maxItems: 1
+
+ vin-supply:
+ description:
+ Supply for the whole chip. Some vendor kernels and devicetrees
+ declare this as a non-existing GPIO named "pwrall".
+
+ interrupts:
+ maxItems: 1
+
+ regulators:
+ type: object
+ additionalProperties: false
+ patternProperties:
+ "^(vcom|vposneg|v3p3)$":
+ unevaluatedProperties: false
+ type: object
+ $ref: /schemas/regulator/regulator.yaml
+
+required:
+ - compatible
+ - reg
+ - pwr-good-gpios
+ - vin-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@18 {
+ compatible = "ti,tps65185";
+ reg = <0x18>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_tps65185_gpio>;
+ pwr-good-gpios = <&gpio2 7 GPIO_ACTIVE_HIGH>;
+ vcom-ctrl-gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>;
+ enable-gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
+ wakeup-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
+ vin-supply = <&epdc_pmic_supply>;
+ interrupts-extended = <&gpio2 0 IRQ_TYPE_LEVEL_LOW>;
+
+ regulators {
+ vcom {
+ regulator-name = "vcom";
+ };
+
+ vposneg {
+ regulator-name = "vposneg";
+ regulator-min-microvolt = <15000000>;
+ regulator-max-microvolt = <15000000>;
+ };
+
+ v3p3 {
+ regulator-name = "v3p3";
+ };
+ };
+ };
+ };
--
2.47.3On Sat, Dec 27, 2025 at 11:20:36AM +0100, Andreas Kemnade wrote: > Document the TPS65185. GPIO names are same as in the datasheet except for > the PWRUP pad which is described as "enable". That pin is optional because > the rising edge corresponds to setting one register bit and falling edge > to another register bit. Nothing improved in the subject. Mark asked for proper prefix and you used exactly the same prefix, so the same problem stays. Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > .../devicetree/bindings/regulator/ti,tps65185.yaml | 99 ++++++++++++++++++++++ > 1 file changed, 99 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml > new file mode 100644 > index 000000000000..7cc5a895c2fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/ti,tps65185.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI TPS65185 Power Management Integrated Circuit > + > +maintainers: > + - Andreas Kemnade <andreas@kemnade.info> > + > +description: > + TPS65185 is a Power Management IC to provide Power for EPDs with one 3.3V > + switch, 2 symmetric LDOs behind 2 DC/DC converters, and one unsymmetric > + regulator for a compensation voltage. > + > +properties: > + compatible: > + const: ti,tps65185 > + > + reg: > + maxItems: 1 > + > + enable-gpios: > + description: > + PWRUP pin > + maxItems: 1 > + > + pwr-good-gpios: > + maxItems: 1 > + > + vcom-ctrl-gpios: > + maxItems: 1 > + > + wakeup-gpios: > + maxItems: 1 > + > + vin-supply: > + description: > + Supply for the whole chip. Some vendor kernels and devicetrees > + declare this as a non-existing GPIO named "pwrall". GPIO cannot be non-existing. Anyway, use name matching the datasheet. With these two things fixed: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof
On Tue, 30 Dec 2025 10:08:57 +0100 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Sat, Dec 27, 2025 at 11:20:36AM +0100, Andreas Kemnade wrote: > > Document the TPS65185. GPIO names are same as in the datasheet except for > > the PWRUP pad which is described as "enable". That pin is optional because > > the rising edge corresponds to setting one register bit and falling edge > > to another register bit. > > Nothing improved in the subject. Mark asked for proper prefix and you > used exactly the same prefix, so the same problem stays. > Quoting: The Documentation/ and include/dt-bindings/ portion of the patch should be a separate patch. The preferred subject prefix for binding patches is: "dt-bindings: <binding dir>: ..." That looks like what I am using. > Please use subject prefixes matching the subsystem. You can get them for > example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters besides merge commits, patches with subjects doing the same seems to be: d0f9f5b7a335 dt-bindings: regulator: Document MediaTek MT6363 PMIC Regulators 0f1010284076 dt-bindings: regulator: document max77838 pmic That looks like mine. So no idea what to improve... [...] > > + vin-supply: > > + description: > > + Supply for the whole chip. Some vendor kernels and devicetrees > > + declare this as a non-existing GPIO named "pwrall". > > GPIO cannot be non-existing. Anyway, use name matching the datasheet. > That is correct, GPIO cannot be non-existing. That comment was just meant as a help for people trying to convert the dirty devicetree mess out there into proper, submittable material. But I will remove that help as you request. Regards, Andreas
On 30/12/2025 10:49, Andreas Kemnade wrote: > On Tue, 30 Dec 2025 10:08:57 +0100 > Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> On Sat, Dec 27, 2025 at 11:20:36AM +0100, Andreas Kemnade wrote: >>> Document the TPS65185. GPIO names are same as in the datasheet except for >>> the PWRUP pad which is described as "enable". That pin is optional because >>> the rising edge corresponds to setting one register bit and falling edge >>> to another register bit. >> >> Nothing improved in the subject. Mark asked for proper prefix and you >> used exactly the same prefix, so the same problem stays. >> > Quoting: > The Documentation/ and include/dt-bindings/ portion of the patch should be a separate patch. The preferred subject prefix for binding patches is: > "dt-bindings: <binding dir>: ..." > > That looks like what I am using. Please read entire paragraph not just half of it. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.