[PATCH v5 20/21] regulator: s2mps11: more descriptive gpio consumer name

André Draszik posted 21 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH v5 20/21] regulator: s2mps11: more descriptive gpio consumer name
Posted by André Draszik 1 month, 2 weeks ago
Currently, GPIOs claimed by this driver for external rail control
all show up with "s2mps11-regulator" as consumer, which is not
very informative.

Switch to using the regulator name via desc->name instead, using the
device name as fallback.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/regulator/s2mps11.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index f068b795ab51845bddac84eca08be0efdcf4f164..178a032c0dc192874118906aee45441a1bbd8515 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -362,7 +362,8 @@ static int s2mps11_of_parse_gpiod(struct device_node *np,
 	ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), con_id, 0,
 					   GPIOD_OUT_HIGH |
 					   GPIOD_FLAGS_BIT_NONEXCLUSIVE,
-					   "s2mps11-regulator");
+					   desc->name
+					   ? : dev_name(config->dev));
 	if (IS_ERR(ena_gpiod)) {
 		ret = PTR_ERR(ena_gpiod);
 

-- 
2.52.0.351.gbe84eed79e-goog

Re: [PATCH v5 20/21] regulator: s2mps11: more descriptive gpio consumer name
Posted by Bartosz Golaszewski 1 month, 1 week ago
On Sat, Dec 27, 2025 at 1:24 PM André Draszik <andre.draszik@linaro.org> wrote:
>
> Currently, GPIOs claimed by this driver for external rail control
> all show up with "s2mps11-regulator" as consumer, which is not
> very informative.
>
> Switch to using the regulator name via desc->name instead, using the
> device name as fallback.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  drivers/regulator/s2mps11.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
> index f068b795ab51845bddac84eca08be0efdcf4f164..178a032c0dc192874118906aee45441a1bbd8515 100644
> --- a/drivers/regulator/s2mps11.c
> +++ b/drivers/regulator/s2mps11.c
> @@ -362,7 +362,8 @@ static int s2mps11_of_parse_gpiod(struct device_node *np,
>         ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), con_id, 0,
>                                            GPIOD_OUT_HIGH |
>                                            GPIOD_FLAGS_BIT_NONEXCLUSIVE,
> -                                          "s2mps11-regulator");
> +                                          desc->name
> +                                          ? : dev_name(config->dev));
>         if (IS_ERR(ena_gpiod)) {
>                 ret = PTR_ERR(ena_gpiod);
>
>
> --
> 2.52.0.351.gbe84eed79e-goog
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>