drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+)
The SpacemiT PCIe PHY driver depends on the common clock framework.
Not specifying that led to a failure when doing a COMPILE_TEST build
for the SPARC architecture.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/
Signed-off-by: Alex Elder <elder@riscstar.com>
---
Note: This is based on phy/next, which I find doesn't currently build
cleanly using "arch/riscv/configs/defconfig".
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index aa2d30e0e3261..3bc7378ea8658 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -104,6 +104,7 @@ config PHY_NXP_PTN3222
config PHY_SPACEMIT_K1_PCIE
tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC"
depends on ARCH_SPACEMIT || COMPILE_TEST
+ depends on COMMON_CLK
depends on HAS_IOMEM
depends on OF
select GENERIC_PHY
base-commit: 27287e3b52b5954b73203d32ee76ffd5f53f5074
--
2.48.1
On Fri, 26 Dec 2025 11:32:27 -0600, Alex Elder wrote:
> The SpacemiT PCIe PHY driver depends on the common clock framework.
> Not specifying that led to a failure when doing a COMPILE_TEST build
> for the SPARC architecture.
>
>
Applied, thanks!
[1/1] phy: Kconfig: spacemit: add COMMON_CLK dependency
commit: 8df20813eb01fe29b4507fd470d73675bda3e1dd
Best regards,
--
~Vinod
On 1/1/26 5:07 AM, Vinod Koul wrote: > > On Fri, 26 Dec 2025 11:32:27 -0600, Alex Elder wrote: >> The SpacemiT PCIe PHY driver depends on the common clock framework. >> Not specifying that led to a failure when doing a COMPILE_TEST build >> for the SPARC architecture. >> >> > > Applied, thanks! > > [1/1] phy: Kconfig: spacemit: add COMMON_CLK dependency > commit: 8df20813eb01fe29b4507fd470d73675bda3e1dd > > Best regards, Thank you. It looks like the same problem affects the s390 build as well. https://lore.kernel.org/oe-kbuild-all/202601022046.OKfcBo0x-lkp@intel.com/ I have confirmed that this fix wasn't applied, and with this fix applied the s390 build error no longer occurs. -Alex
On 26-12-25, 11:32, Alex Elder wrote: > The SpacemiT PCIe PHY driver depends on the common clock framework. > Not specifying that led to a failure when doing a COMPILE_TEST build > for the SPARC architecture. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/ > Signed-off-by: Alex Elder <elder@riscstar.com> > --- > Note: This is based on phy/next, which I find doesn't currently build > cleanly using "arch/riscv/configs/defconfig". I dont build rsicv, I should add that. What is the failure you see, looking at changes I dont see anything that might break this > > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index aa2d30e0e3261..3bc7378ea8658 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -104,6 +104,7 @@ config PHY_NXP_PTN3222 > config PHY_SPACEMIT_K1_PCIE > tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC" > depends on ARCH_SPACEMIT || COMPILE_TEST > + depends on COMMON_CLK > depends on HAS_IOMEM > depends on OF > select GENERIC_PHY > > base-commit: 27287e3b52b5954b73203d32ee76ffd5f53f5074 > -- > 2.48.1 -- ~Vinod
On 12/29/25 10:57 AM, Vinod Koul wrote: > On 26-12-25, 11:32, Alex Elder wrote: >> The SpacemiT PCIe PHY driver depends on the common clock framework. >> Not specifying that led to a failure when doing a COMPILE_TEST build >> for the SPARC architecture. >> >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/ >> Signed-off-by: Alex Elder <elder@riscstar.com> >> --- >> Note: This is based on phy/next, which I find doesn't currently build >> cleanly using "arch/riscv/configs/defconfig". > > I dont build rsicv, I should add that. What is the failure you see, > looking at changes I dont see anything that might break this The clock calls are not defined in the SPARC environment. phy-spacemit-k1-pcie.o: in function `k1_pcie_phy_pll_setup': phy-spacemit-k1-pcie.c:299: undefined reference to `devm_clk_hw_register' phy-spacemit-k1-pcie.c:306: undefined reference to `devm_clk_hw_get_clk' https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/ (I now realize you can just click on the "Closes" link.) -Alex >> >> drivers/phy/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index aa2d30e0e3261..3bc7378ea8658 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -104,6 +104,7 @@ config PHY_NXP_PTN3222 >> config PHY_SPACEMIT_K1_PCIE >> tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC" >> depends on ARCH_SPACEMIT || COMPILE_TEST >> + depends on COMMON_CLK >> depends on HAS_IOMEM >> depends on OF >> select GENERIC_PHY >> >> base-commit: 27287e3b52b5954b73203d32ee76ffd5f53f5074 >> -- >> 2.48.1 >
Alex Elder <elder@riscstar.com> writes: Hello Alex, > The SpacemiT PCIe PHY driver depends on the common clock framework. > Not specifying that led to a failure when doing a COMPILE_TEST build > for the SPARC architecture. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/ > Signed-off-by: Alex Elder <elder@riscstar.com> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
© 2016 - 2026 Red Hat, Inc.