[PATCH v5 1/3] i2c: spacemit: drop useless spaces

Troy Mitchell posted 3 patches 1 month, 2 weeks ago
[PATCH v5 1/3] i2c: spacemit: drop useless spaces
Posted by Troy Mitchell 1 month, 2 weeks ago
Previously, the I2C driver had an extra leading space in column 0 of
included header lines. This commit removes the redundant whitespace.

Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
---
 drivers/i2c/busses/i2c-k1.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c
index d42c03ef5db5984ea8e06b3d7eb485b4f899e616..30cdf733deef264061c8ea565634c5a17f5aebfd 100644
--- a/drivers/i2c/busses/i2c-k1.c
+++ b/drivers/i2c/busses/i2c-k1.c
@@ -4,12 +4,12 @@
  */
 
 #include <linux/bitfield.h>
- #include <linux/clk.h>
- #include <linux/i2c.h>
- #include <linux/iopoll.h>
- #include <linux/module.h>
- #include <linux/of_address.h>
- #include <linux/platform_device.h>
+#include <linux/clk.h>
+#include <linux/i2c.h>
+#include <linux/iopoll.h>
+#include <linux/module.h>
+#include <linux/of_address.h>
+#include <linux/platform_device.h>
 
 /* spacemit i2c registers */
 #define SPACEMIT_ICR		 0x0		/* Control register */

-- 
2.52.0
Re: [PATCH v5 1/3] i2c: spacemit: drop useless spaces
Posted by Andi Shyti 3 weeks, 4 days ago
Hi Troy,

On Fri, Dec 26, 2025 at 04:31:59PM +0800, Troy Mitchell wrote:
> Previously, the I2C driver had an extra leading space in column 0 of
> included header lines. This commit removes the redundant whitespace.
> 
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>

I merged just this patch to i2c/i2c-host so that you don't need
to carry it around.

> - #include <linux/clk.h>
> - #include <linux/i2c.h>
> - #include <linux/iopoll.h>
> - #include <linux/module.h>
> - #include <linux/of_address.h>
> - #include <linux/platform_device.h>

There was a little conflict here which was easy to fix because
linux/reset.h has been included in the meantime.

Thanks,
Andi

> +#include <linux/clk.h>
> +#include <linux/i2c.h>
> +#include <linux/iopoll.h>
> +#include <linux/module.h>
> +#include <linux/of_address.h>
> +#include <linux/platform_device.h>
>  
>  /* spacemit i2c registers */
>  #define SPACEMIT_ICR		 0x0		/* Control register */
> 
> -- 
> 2.52.0
>
Re: [PATCH v5 1/3] i2c: spacemit: drop useless spaces
Posted by Alex Elder 1 month, 1 week ago
On 12/26/25 2:31 AM, Troy Mitchell wrote:
> Previously, the I2C driver had an extra leading space in column 0 of
> included header lines. This commit removes the redundant whitespace.
> 
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> ---
>   drivers/i2c/busses/i2c-k1.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c
> index d42c03ef5db5984ea8e06b3d7eb485b4f899e616..30cdf733deef264061c8ea565634c5a17f5aebfd 100644
> --- a/drivers/i2c/busses/i2c-k1.c
> +++ b/drivers/i2c/busses/i2c-k1.c
> @@ -4,12 +4,12 @@
>    */
>   
>   #include <linux/bitfield.h>
> - #include <linux/clk.h>
> - #include <linux/i2c.h>
> - #include <linux/iopoll.h>
> - #include <linux/module.h>
> - #include <linux/of_address.h>
> - #include <linux/platform_device.h>
> +#include <linux/clk.h>
> +#include <linux/i2c.h>
> +#include <linux/iopoll.h>
> +#include <linux/module.h>
> +#include <linux/of_address.h>
> +#include <linux/platform_device.h>
>   
>   /* spacemit i2c registers */
>   #define SPACEMIT_ICR		 0x0		/* Control register */
> 

Looks good.

Reviewed-by: Alex Elder <elder@riscstar.com>