[PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc_sdp()

Alper Ak posted 1 patch 1 month, 1 week ago
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc_sdp()
Posted by Alper Ak 1 month, 1 week ago
Since dw_dp_video_need_vsc_sdp() returns bool, have it return false
instead of -EINVAL if state is NULL.

Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
 drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 82aaf74e1bc0..36382956bbe0 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
 	state = dw_dp_get_bridge_state(dp);
 	if (!state)
-		return -EINVAL;
+		return false;
 
 	if (!link->vsc_sdp_supported)
 		return false;
-- 
2.43.0
Re:[PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc_sdp()
Posted by Andy Yan 1 month, 1 week ago
Hi Alper,

At 2025-12-26 02:44:01, "Alper Ak" <alperyasinak1@gmail.com> wrote:
>Since dw_dp_video_need_vsc_sdp() returns bool, have it return false
>instead of -EINVAL if state is NULL.
>
>Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
>Signed-off-by: Alper Ak <alperyasinak1@gmail.com>


 Reviewed-by: Andy Yan <andyshrk@163.com>

>---
> drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>index 82aaf74e1bc0..36382956bbe0 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
> 
> 	state = dw_dp_get_bridge_state(dp);
> 	if (!state)
>-		return -EINVAL;
>+		return false;
> 
> 	if (!link->vsc_sdp_supported)
> 		return false;
>-- 
>2.43.0