[PATCH 1/4] dt-bindings: brcm,spi-bcm-qspi: allow hif_mspi as alternative for mspi

Jonas Gorski posted 4 patches 1 month, 2 weeks ago
[PATCH 1/4] dt-bindings: brcm,spi-bcm-qspi: allow hif_mspi as alternative for mspi
Posted by Jonas Gorski 1 month, 2 weeks ago
Add "hif_mspi" as an alternative reg-name for brcm,spi-bcm-qspi, as
it is in use by BCM7xxx (BMIPS) device trees.

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
 Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml
index 45975f40d943..ffe8d7f8dd4a 100644
--- a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml
@@ -57,7 +57,7 @@ properties:
   reg-names:
     minItems: 1
     items:
-      - const: mspi
+      - enum: [ hif_mspi, mspi ]
       - const: bspi
       - enum: [ intr_regs, intr_status_reg, cs_reg ]
       - enum: [ intr_regs, intr_status_reg, cs_reg ]
-- 
2.43.0
Re: [PATCH 1/4] dt-bindings: brcm,spi-bcm-qspi: allow hif_mspi as alternative for mspi
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 25/12/2025 11:25, Jonas Gorski wrote:
> Add "hif_mspi" as an alternative reg-name for brcm,spi-bcm-qspi, as
> it is in use by BCM7xxx (BMIPS) device trees.
> 
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>


Also:

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof
Re: [PATCH 1/4] dt-bindings: brcm,spi-bcm-qspi: allow hif_mspi as alternative for mspi
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 25/12/2025 11:25, Jonas Gorski wrote:
> Add "hif_mspi" as an alternative reg-name for brcm,spi-bcm-qspi, as
> it is in use by BCM7xxx (BMIPS) device trees.
> 
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Rather fix the DTS or provide reason why they cannot/should not be fixed.

Best regards,
Krzysztof