[PATCH 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names

Prabhakar posted 4 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names
Posted by Prabhakar 1 month, 2 weeks ago
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Specify the expected reset-names for the Renesas CAN-FD controller on
RZ/G2L and RZ/G3E SoCs.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../bindings/net/can/renesas,rcar-canfd.yaml           | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index f4ac21c68427..dab79dffef4b 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -188,8 +188,9 @@ allOf:
           maxItems: 2
 
         reset-names:
-          minItems: 2
-          maxItems: 2
+          items:
+            - const: rstp_n
+            - const: rstc_n
 
       required:
         - reset-names
@@ -232,8 +233,9 @@ allOf:
           maxItems: 2
 
         reset-names:
-          minItems: 2
-          maxItems: 2
+          items:
+            - const: rstp_n
+            - const: rstc_n
 
       required:
         - reset-names
-- 
2.52.0
Re: [PATCH 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On Wed, Dec 24, 2025 at 05:33:21PM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Specify the expected reset-names for the Renesas CAN-FD controller on
> RZ/G2L and RZ/G3E SoCs.

Instead this all mess should be fixed - you need to define all
properties in top-level and only override them with specific constraints
per variant.

Best regards,
Krzysztof
Re: [PATCH 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names
Posted by Lad, Prabhakar 1 month, 1 week ago
Hi Krzysztof,

Thank you for the review.

On Sat, Dec 27, 2025 at 1:11 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, Dec 24, 2025 at 05:33:21PM +0000, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Specify the expected reset-names for the Renesas CAN-FD controller on
> > RZ/G2L and RZ/G3E SoCs.
>
> Instead this all mess should be fixed - you need to define all
> properties in top-level and only override them with specific constraints
> per variant.
>
Ok, I will define the reset-names in the top level and adjust accordingly.

Cheers,
Prabhakar