ksmbd: Fix memory leak in get_file_all_info()

[PATCH] ksmbd: Fix memory leak in get_file_all_info()

Posted by Zilin Guan 1 month, 2 weeks ago

In get_file_all_info(), if vfs_getattr() fails, the function returns
immediately without freeing the allocated filename, leading to a memory
leak.

Fix this by freeing the filename before returning in this error case.

Fixes: 5614c8c487f6a ("ksmbd: replace generic_fillattr with vfs_getattr")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
---
 fs/smb/server/smb2pdu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 8aa483800014..4472638ab11a 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -4923,8 +4923,10 @@ static int get_file_all_info(struct ksmbd_work *work,
 
 	ret = vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS,
 			  AT_STATX_SYNC_AS_STAT);
-	if (ret)
+	if (ret) {
+		kfree(filename);
 		return ret;
+	}
 
 	ksmbd_debug(SMB, "filename = %s\n", filename);
 	delete_pending = ksmbd_inode_pending_delete(fp);
-- 
2.34.1

Re: [PATCH] ksmbd: Fix memory leak in get_file_all_info()

Posted by yebin 1 month, 2 weeks ago


On 2025/12/24 22:20, Zilin Guan wrote:
> In get_file_all_info(), if vfs_getattr() fails, the function returns
> immediately without freeing the allocated filename, leading to a memory
> leak.
>
> Fix this by freeing the filename before returning in this error case.
>
> Fixes: 5614c8c487f6a ("ksmbd: replace generic_fillattr with vfs_getattr")
> Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
> ---
>   fs/smb/server/smb2pdu.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
> index 8aa483800014..4472638ab11a 100644
> --- a/fs/smb/server/smb2pdu.c
> +++ b/fs/smb/server/smb2pdu.c
> @@ -4923,8 +4923,10 @@ static int get_file_all_info(struct ksmbd_work *work,
>
>   	ret = vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS,
>   			  AT_STATX_SYNC_AS_STAT);
> -	if (ret)
> +	if (ret) {
		goto out;
> +		kfree(filename);
>   		return ret;
> +	}
>
out:
          kfree(filename);
          return ret;

Maybe we can add 'out' label.

>   	ksmbd_debug(SMB, "filename = %s\n", filename);
>   	delete_pending = ksmbd_inode_pending_delete(fp);
>

Re: [PATCH] ksmbd: Fix memory leak in get_file_all_info()

Posted by Namjae Jeon 1 month, 2 weeks ago

On Wed, Dec 24, 2025 at 11:20 PM Zilin Guan <zilin@seu.edu.cn> wrote:
>
> In get_file_all_info(), if vfs_getattr() fails, the function returns
> immediately without freeing the allocated filename, leading to a memory
> leak.
>
> Fix this by freeing the filename before returning in this error case.
>
> Fixes: 5614c8c487f6a ("ksmbd: replace generic_fillattr with vfs_getattr")
> Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Applied it to #ksmbd-for-next-next.
Thanks!