Add qedi_cm_free_mem() and qedi_free_itt() on error path in
__qedi_probe() to prevent memory leaks.
Found by code review and compiled on ubuntu 20.04.
Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
drivers/scsi/qedi/qedi_main.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 56685ee22fdf..805078205ef1 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -2754,7 +2754,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
if (rc) {
QEDI_ERR(&qedi->dbg_ctx,
"Could not alloc itt memory\n");
- goto free_cid_que;
+ goto free_cm_mem;
}
sprintf(host_buf, "host_%d", qedi->shost->host_no);
@@ -2764,7 +2764,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
QEDI_ERR(&qedi->dbg_ctx,
"Unable to start tmf thread!\n");
rc = -ENODEV;
- goto free_cid_que;
+ goto free_itt_mem;
}
qedi->offload_thread = alloc_workqueue("qedi_ofld%d",
@@ -2800,6 +2800,10 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
free_tmf_thread:
destroy_workqueue(qedi->tmf_thread);
+free_itt_mem:
+ qedi_free_itt(qedi);
+free_cm_mem:
+ qedi_cm_free_mem(qedi);
free_cid_que:
qedi_release_cid_que(qedi);
free_uio:
--
2.25.1