[PATCH 1/2] dt-bindings: phy: Add PHY_TYPE_XAUI definition

Siddharth Vadapalli posted 2 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 1/2] dt-bindings: phy: Add PHY_TYPE_XAUI definition
Posted by Siddharth Vadapalli 1 month, 2 weeks ago
From: Swapnil Jakhade <sjakhade@cadence.com>

Add definition for XAUI phy type.

Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
 include/dt-bindings/phy/phy.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h
index 6b901b342348..d77b372d302f 100644
--- a/include/dt-bindings/phy/phy.h
+++ b/include/dt-bindings/phy/phy.h
@@ -23,5 +23,6 @@
 #define PHY_TYPE_DPHY		10
 #define PHY_TYPE_CPHY		11
 #define PHY_TYPE_USXGMII	12
+#define PHY_TYPE_XAUI		13
 
 #endif /* _DT_BINDINGS_PHY */
-- 
2.51.1
Re: [PATCH 1/2] dt-bindings: phy: Add PHY_TYPE_XAUI definition
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On Wed, Dec 24, 2025 at 11:18:58AM +0530, Siddharth Vadapalli wrote:
> From: Swapnil Jakhade <sjakhade@cadence.com>
> 
> Add definition for XAUI phy type.

What is XAUI?

Your commit msg duplicates subject and is obvious - repeats what is
in the diff. Pretty pointless.

Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: phy: Add PHY_TYPE_XAUI definition
Posted by Siddharth Vadapalli 1 month ago
On 27/12/25 6:33 PM, Krzysztof Kozlowski wrote:
> On Wed, Dec 24, 2025 at 11:18:58AM +0530, Siddharth Vadapalli wrote:
>> From: Swapnil Jakhade <sjakhade@cadence.com>
>>
>> Add definition for XAUI phy type.
> 
> What is XAUI?
> 
> Your commit msg duplicates subject and is obvious - repeats what is
> in the diff. Pretty pointless.

I have posted the v2 series at:
https://lore.kernel.org/r/20260104114422.2868321-1-s-vadapalli@ti.com/
providing a detailed description of XAUI in the commit message.

Thank you for the feedback.

Regards,
Siddharth.