[v3] arm64: dts: qcom: monaco: add QCrypto node

[PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

Posted by Abhinaba Rakshit 1 month, 2 weeks ago

Add Qualcomm Crypto Engine device node for Monaco platform.

QCE and Crypto DMA nodes patch was applied as part of
commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
due to compatible string being mismatched against schema.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
---
QCE device node was reverted for Monaco platform as compatible-string
did not match with bindings schema.

This patch is intended in resubmitting the enablement of
QCE device node for Monaco platform with compatible-string
being aligned with qcom-qce.

Bindings and Crypto DMA nodes for the same platform is already
present in the tree.
---
Changes in v3:
- Update the commit message and cover-letter description.
- Link to v2: https://lore.kernel.org/r/20251223-enable-qualcomm-crypto-engine-for-monaco-v2-1-6274c1f6136f@oss.qualcomm.com

Changes in v2:
- Move the description and history for the patch in cover-letter as suggested in patchset v1.
- Use 0x0 inplace of 0x00 for iommus SMR mask field as suggested in patchset v1.
- Link to v1: https://lore.kernel.org/r/20251222-enable-qualcomm-crypto-engine-for-monaco-v1-1-06741d6ea66a@oss.qualcomm.com
---
 arch/arm64/boot/dts/qcom/monaco.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index 816fa2af8a9a663b8ad176f93d2f18284a08c3d1..c0cf56c46ed50bd558f7cdfc8e55a58d738ef911 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -2350,6 +2350,18 @@ ice: crypto@1d88000 {
 			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
 		};
 
+		crypto: crypto@1dfa000 {
+			compatible = "qcom,qcs8300-qce", "qcom,sm8150-qce", "qcom,qce";
+			reg = <0x0 0x01dfa000 0x0 0x6000>;
+			dmas = <&cryptobam 4>, <&cryptobam 5>;
+			dma-names = "rx", "tx";
+			iommus = <&apps_smmu 0x480 0x0>,
+				 <&apps_smmu 0x481 0x0>;
+			interconnects = <&aggre2_noc MASTER_CRYPTO_CORE0 QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "memory";
+		};
+
 		tcsr_mutex: hwlock@1f40000 {
 			compatible = "qcom,tcsr-mutex";
 			reg = <0x0 0x01f40000 0x0 0x20000>;

---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251222-enable-qualcomm-crypto-engine-for-monaco-7c6b9112779d

Best regards,
-- 
Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>

Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

Posted by Bjorn Andersson 1 month ago

On Wed, 24 Dec 2025 14:03:02 +0530, Abhinaba Rakshit wrote:
> Add Qualcomm Crypto Engine device node for Monaco platform.
> 
> QCE and Crypto DMA nodes patch was applied as part of
> commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
> qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
> due to compatible string being mismatched against schema.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: monaco: add QCrypto node
      commit: 6691966f4afc06c674b7679a772b7423cd16c545

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

Posted by Konrad Dybcio 1 month, 1 week ago

On 12/24/25 9:33 AM, Abhinaba Rakshit wrote:
> Add Qualcomm Crypto Engine device node for Monaco platform.
> 
> QCE and Crypto DMA nodes patch was applied as part of
> commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
> qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
> due to compatible string being mismatched against schema.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 24/12/2025 09:33, Abhinaba Rakshit wrote:
> Add Qualcomm Crypto Engine device node for Monaco platform.
> 
> QCE and Crypto DMA nodes patch was applied as part of
> commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
> qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
> due to compatible string being mismatched against schema.

...due to Qualcomm engineer not ever bothering to build test the code.

Was it build tested now? Typically this is implied by trusting people,
but not here. Trust is lost.

Best regards,
Krzysztof

Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

Posted by Abhinaba Rakshit 1 month, 2 weeks ago

On Wed, Dec 24, 2025 at 09:42:03AM +0100, Krzysztof Kozlowski wrote:
> On 24/12/2025 09:33, Abhinaba Rakshit wrote:
> > Add Qualcomm Crypto Engine device node for Monaco platform.
> > 
> > QCE and Crypto DMA nodes patch was applied as part of
> > commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> > however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
> > qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
> > due to compatible string being mismatched against schema.
> 
> ...due to Qualcomm engineer not ever bothering to build test the code.
> 
> Was it build tested now? Typically this is implied by trusting people,
> but not here. Trust is lost.
> 

Yes, the updated patch has now been build‑tested (including DT schema checks).
The previous issue happened due to an oversight on our end, and I agree that it should not have slipped through.
I’ll ensure future submissions are properly tested before sending them upstream.

Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 24/12/2025 09:42, Krzysztof Kozlowski wrote:
> On 24/12/2025 09:33, Abhinaba Rakshit wrote:
>> Add Qualcomm Crypto Engine device node for Monaco platform.
>>
>> QCE and Crypto DMA nodes patch was applied as part of
>> commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
>> however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
>> qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
>> due to compatible string being mismatched against schema.
> 
> ...due to Qualcomm engineer not ever bothering to build test the code.
> 
> Was it build tested now? Typically this is implied by trusting people,
> but not here. Trust is lost.

And to be clear - I found more QCrypto DTS patches which were never
build tested and never tested on the hardware. This was not a single
case, but a pattern.

Best regards,
Krzysztof