[PATCH V1] hwmon: f71882fg: Add F81968 support

Ji-Ze Hong (Peter Hong) posted 1 patch 1 month, 2 weeks ago
drivers/hwmon/f71882fg.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH V1] hwmon: f71882fg: Add F81968 support
Posted by Ji-Ze Hong (Peter Hong) 1 month, 2 weeks ago
This adds hardware monitor support the Fintek F81968 Super I/O chip.
It has fully compatible with F81866.

Several products share compatibility with the F81866. To better
distinguish between them, this patch ensures the Product ID is
displayed when the device is probed.

Signed-off-by: Ji-Ze Hong (Peter Hong) <peter_hong@fintek.com.tw>
---
 drivers/hwmon/f71882fg.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
index df83f9866fbc..204059d2de6c 100644
--- a/drivers/hwmon/f71882fg.c
+++ b/drivers/hwmon/f71882fg.c
@@ -51,6 +51,7 @@
 #define SIO_F81866_ID		0x1010	/* Chipset ID */
 #define SIO_F71858AD_ID		0x0903	/* Chipset ID */
 #define SIO_F81966_ID		0x1502	/* Chipset ID */
+#define SIO_F81968_ID		0x1806	/* Chipset ID */
 
 #define REGION_LENGTH		8
 #define ADDR_REG_OFFSET		5
@@ -2570,6 +2571,7 @@ static int __init f71882fg_find(int sioaddr, struct f71882fg_sio_data *sio_data)
 		break;
 	case SIO_F81866_ID:
 	case SIO_F81966_ID:
+	case SIO_F81968_ID:
 		sio_data->type = f81866a;
 		break;
 	default:
@@ -2599,9 +2601,9 @@ static int __init f71882fg_find(int sioaddr, struct f71882fg_sio_data *sio_data)
 	address &= ~(REGION_LENGTH - 1);	/* Ignore 3 LSB */
 
 	err = address;
-	pr_info("Found %s chip at %#x, revision %d\n",
+	pr_info("Found %s chip at %#x, revision %d, devid: %04x\n",
 		f71882fg_names[sio_data->type],	(unsigned int)address,
-		(int)superio_inb(sioaddr, SIO_REG_DEVREV));
+		(int)superio_inb(sioaddr, SIO_REG_DEVREV), devid);
 exit:
 	superio_exit(sioaddr);
 	return err;
-- 
2.34.1
Re: [PATCH V1] hwmon: f71882fg: Add F81968 support
Posted by Guenter Roeck 3 weeks, 5 days ago
On Tue, Dec 23, 2025 at 01:10:40PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> This adds hardware monitor support the Fintek F81968 Super I/O chip.

"This adds" -> "Add", and "support for".

> It has fully compatible with F81866.

has -> is 

> 
> Several products share compatibility with the F81866. To better
> distinguish between them, this patch ensures the Product ID is

"this patch ensures" -> ensure that

> displayed when the device is probed.
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <peter_hong@fintek.com.tw>

No need to resend, applied after changing the above.

Thanks,
Guenter

> ---
>  drivers/hwmon/f71882fg.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
> index df83f9866fbc..204059d2de6c 100644
> --- a/drivers/hwmon/f71882fg.c
> +++ b/drivers/hwmon/f71882fg.c
> @@ -51,6 +51,7 @@
>  #define SIO_F81866_ID		0x1010	/* Chipset ID */
>  #define SIO_F71858AD_ID		0x0903	/* Chipset ID */
>  #define SIO_F81966_ID		0x1502	/* Chipset ID */
> +#define SIO_F81968_ID		0x1806	/* Chipset ID */
>  
>  #define REGION_LENGTH		8
>  #define ADDR_REG_OFFSET		5
> @@ -2570,6 +2571,7 @@ static int __init f71882fg_find(int sioaddr, struct f71882fg_sio_data *sio_data)
>  		break;
>  	case SIO_F81866_ID:
>  	case SIO_F81966_ID:
> +	case SIO_F81968_ID:
>  		sio_data->type = f81866a;
>  		break;
>  	default:
> @@ -2599,9 +2601,9 @@ static int __init f71882fg_find(int sioaddr, struct f71882fg_sio_data *sio_data)
>  	address &= ~(REGION_LENGTH - 1);	/* Ignore 3 LSB */
>  
>  	err = address;
> -	pr_info("Found %s chip at %#x, revision %d\n",
> +	pr_info("Found %s chip at %#x, revision %d, devid: %04x\n",
>  		f71882fg_names[sio_data->type],	(unsigned int)address,
> -		(int)superio_inb(sioaddr, SIO_REG_DEVREV));
> +		(int)superio_inb(sioaddr, SIO_REG_DEVREV), devid);
>  exit:
>  	superio_exit(sioaddr);
>  	return err;