[PATCH] drm/amdgpu: Fix typos in amdgpu_vm_bo_update comments

Ding Yihan posted 1 patch 1 month, 2 weeks ago
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] drm/amdgpu: Fix typos in amdgpu_vm_bo_update comments
Posted by Ding Yihan 1 month, 2 weeks ago
Fix spelling mistakes in the comment block within amdgpu_vm_bo_update().
Specifically, correct "contians" to "contains" and "WIRTEABLE" to
"WRITEABLE".

Additionally, improve the grammar, capitalization, and punctuation of
the comment for better readability.

Signed-off-by: Ding Yihan <dingyihan@uniontech.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index c362d4dfb5bb..502d32728008 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1352,8 +1352,8 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, struct amdgpu_bo_va *bo_va,
 	list_for_each_entry(mapping, &bo_va->invalids, list) {
 		uint64_t update_flags = flags;
 
-		/* normally,bo_va->flags only contians READABLE and WIRTEABLE bit go here
-		 * but in case of something, we filter the flags in first place
+		/* Normally,bo_va->flags only contains READABLE and WRITEABLE bits here.
+		 * But in case of something, we filter the flags in first place.
 		 */
 		if (!(mapping->flags & AMDGPU_VM_PAGE_READABLE))
 			update_flags &= ~AMDGPU_PTE_READABLE;
-- 
2.20.1
Re: [PATCH] drm/amdgpu: Fix typos in amdgpu_vm_bo_update comments
Posted by Christian König 1 month ago
On 12/23/25 05:41, Ding Yihan wrote:
> Fix spelling mistakes in the comment block within amdgpu_vm_bo_update().
> Specifically, correct "contians" to "contains" and "WIRTEABLE" to
> "WRITEABLE".
> 
> Additionally, improve the grammar, capitalization, and punctuation of
> the comment for better readability.
> 
> Signed-off-by: Ding Yihan <dingyihan@uniontech.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index c362d4dfb5bb..502d32728008 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1352,8 +1352,8 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, struct amdgpu_bo_va *bo_va,
>  	list_for_each_entry(mapping, &bo_va->invalids, list) {
>  		uint64_t update_flags = flags;
>  
> -		/* normally,bo_va->flags only contians READABLE and WIRTEABLE bit go here
> -		 * but in case of something, we filter the flags in first place
> +		/* Normally,bo_va->flags only contains READABLE and WRITEABLE bits here.
> +		 * But in case of something, we filter the flags in first place.
>  		 */
>  		if (!(mapping->flags & AMDGPU_VM_PAGE_READABLE))
>  			update_flags &= ~AMDGPU_PTE_READABLE;