Plane Color Pipeline support for MediaTek

[PATCH 04/11] drm/mediatek: ovl: Enable per-plane color operations on MT8195

Posted by Nícolas F. R. A. Prado 1 month, 2 weeks ago

MT8195's OVL hardware supports per-plane color operations. Enable
support for it in the driver.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
 drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index 46238c21b0ac..cfc6a3154f73 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -738,6 +738,7 @@ static const struct mtk_disp_ovl_data mt8195_ovl_driver_data = {
 	.fmt_rgb565_is_0 = true,
 	.smi_id_en = true,
 	.supports_afbc = true,
+	.supports_plane_colorops = true,
 	.blend_modes = BIT(DRM_MODE_BLEND_PREMULTI) |
 		       BIT(DRM_MODE_BLEND_COVERAGE) |
 		       BIT(DRM_MODE_BLEND_PIXEL_NONE),

-- 
2.51.0

Re: [PATCH 04/11] drm/mediatek: ovl: Enable per-plane color operations on MT8195

Posted by AngeloGioacchino Del Regno 3 days, 13 hours ago

Il 23/12/25 20:44, Nícolas F. R. A. Prado ha scritto:
> MT8195's OVL hardware supports per-plane color operations. Enable
> support for it in the driver.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Agreed, but you're enabling something that doesn't exist.
Please move this commit at the end, so that you enable it after it's all
implemented.

Cheers,
Angelo

> ---
>   drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index 46238c21b0ac..cfc6a3154f73 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -738,6 +738,7 @@ static const struct mtk_disp_ovl_data mt8195_ovl_driver_data = {
>   	.fmt_rgb565_is_0 = true,
>   	.smi_id_en = true,
>   	.supports_afbc = true,
> +	.supports_plane_colorops = true,
>   	.blend_modes = BIT(DRM_MODE_BLEND_PREMULTI) |
>   		       BIT(DRM_MODE_BLEND_COVERAGE) |
>   		       BIT(DRM_MODE_BLEND_PIXEL_NONE),
>

Re: [PATCH 04/11] drm/mediatek: ovl: Enable per-plane color operations on MT8195

Posted by Nícolas F. R. A. Prado 3 days, 9 hours ago

On Fri, 2026-02-06 at 11:07 +0100, AngeloGioacchino Del Regno wrote:
> Il 23/12/25 20:44, Nícolas F. R. A. Prado ha scritto:
> > MT8195's OVL hardware supports per-plane color operations. Enable
> > support for it in the driver.
> > 
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> Agreed, but you're enabling something that doesn't exist.
> Please move this commit at the end, so that you enable it after it's
> all
> implemented.

Ack, will do it in v2.

-- 
Thanks,

Nícolas

Re: [PATCH 04/11] drm/mediatek: ovl: Enable per-plane color operations on MT8195

Posted by Macpaul Lin (林智斌) 1 month, 2 weeks ago

On Tue, 2025-12-23 at 16:44 -0300, Nícolas F. R. A. Prado wrote:
> MT8195's OVL hardware supports per-plane color operations. Enable
> support for it in the driver.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index 46238c21b0ac..cfc6a3154f73 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -738,6 +738,7 @@ static const struct mtk_disp_ovl_data
> mt8195_ovl_driver_data = {
>         .fmt_rgb565_is_0 = true,
>         .smi_id_en = true,
>         .supports_afbc = true,
> +       .supports_plane_colorops = true,
>         .blend_modes = BIT(DRM_MODE_BLEND_PREMULTI) |
>                        BIT(DRM_MODE_BLEND_COVERAGE) |
>                        BIT(DRM_MODE_BLEND_PIXEL_NONE),
> 
> --
> 2.51.0
> 
> 

Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>

Best regards,
Macpaul Lin