[PATCH 0/5] perf build: nondistro build tidyups

James Clark posted 5 patches 1 month, 2 weeks ago
tools/build/Makefile.feature                 |  2 +-
tools/build/feature/Makefile                 |  4 +--
tools/build/feature/test-libbfd-buildid.c    |  8 -----
tools/build/feature/test-libbfd-threadsafe.c | 18 ++++++++++
tools/perf/Makefile.config                   | 54 ++++++++++------------------
tools/perf/tests/make                        |  5 +++
6 files changed, 45 insertions(+), 46 deletions(-)
[PATCH 0/5] perf build: nondistro build tidyups
Posted by James Clark 1 month, 2 weeks ago
nondistro builds now require a specific version of libbfd, so this adds
an error when doing an explicit BUILD_NONDISTRO build and some other
related tidyups.

I'm not sure if the intention is to skip build-tests if something is
missing, but I see it was done for libbpf versions, so I added the same
for libbfd. This is the main thing that I hit, that build-test all of a
sudden stopped working for me.

The first commit is also a cherry pick of an old commit that seemed to
have been accidentally reverted in the unrelated change linked in the
trailers.

---
James Clark (4):
      perf build: Do all non-distro feature checks in one go
      perf build: Remove unused libbfd-buildid feature test
      perf build: Feature test for libbfd thread safety API
      perf build: Skip nondistro build test if libbfd is old

Roberto Sassu (1):
      perf build: Remove FEATURE_CHECK_LDFLAGS-disassembler-{four-args,init-styled} setting

 tools/build/Makefile.feature                 |  2 +-
 tools/build/feature/Makefile                 |  4 +--
 tools/build/feature/test-libbfd-buildid.c    |  8 -----
 tools/build/feature/test-libbfd-threadsafe.c | 18 ++++++++++
 tools/perf/Makefile.config                   | 54 ++++++++++------------------
 tools/perf/tests/make                        |  5 +++
 6 files changed, 45 insertions(+), 46 deletions(-)
---
base-commit: cbd41c6d4c26c161a2b0e70ad411d3885ff13507
change-id: 20251223-james-libbfd-feat-check-e0cd09d2c1e1

Best regards,
-- 
James Clark <james.clark@linaro.org>
Re: [PATCH 0/5] perf build: nondistro build tidyups
Posted by Arnaldo Carvalho de Melo 1 month ago
On Tue, Dec 23, 2025 at 05:00:23PM +0000, James Clark wrote:
> nondistro builds now require a specific version of libbfd, so this adds
> an error when doing an explicit BUILD_NONDISTRO build and some other
> related tidyups.
> 
> I'm not sure if the intention is to skip build-tests if something is
> missing, but I see it was done for libbpf versions, so I added the same
> for libbfd. This is the main thing that I hit, that build-test all of a
> sudden stopped working for me.
> 
> The first commit is also a cherry pick of an old commit that seemed to
> have been accidentally reverted in the unrelated change linked in the
> trailers.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> ---
> James Clark (4):
>       perf build: Do all non-distro feature checks in one go
>       perf build: Remove unused libbfd-buildid feature test
>       perf build: Feature test for libbfd thread safety API
>       perf build: Skip nondistro build test if libbfd is old
> 
> Roberto Sassu (1):
>       perf build: Remove FEATURE_CHECK_LDFLAGS-disassembler-{four-args,init-styled} setting
> 
>  tools/build/Makefile.feature                 |  2 +-
>  tools/build/feature/Makefile                 |  4 +--
>  tools/build/feature/test-libbfd-buildid.c    |  8 -----
>  tools/build/feature/test-libbfd-threadsafe.c | 18 ++++++++++
>  tools/perf/Makefile.config                   | 54 ++++++++++------------------
>  tools/perf/tests/make                        |  5 +++
>  6 files changed, 45 insertions(+), 46 deletions(-)
> ---
> base-commit: cbd41c6d4c26c161a2b0e70ad411d3885ff13507
> change-id: 20251223-james-libbfd-feat-check-e0cd09d2c1e1
> 
> Best regards,
> -- 
> James Clark <james.clark@linaro.org>