[PATCH 3/6] i2c: amd-asf-plat: use i2c_adapter_dev()

Bartosz Golaszewski posted 6 patches 1 month, 2 weeks ago
[PATCH 3/6] i2c: amd-asf-plat: use i2c_adapter_dev()
Posted by Bartosz Golaszewski 1 month, 2 weeks ago
Use i2c_adapter_dev() where applicable in order to avoid direct
dereferencing of struct device embedded within struct i2c_adapter.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/i2c/busses/i2c-amd-asf-plat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c
index ca45f0f233210a3b03a16c4a240012bd524fefb0..271b1b24417d06cc87733268c3191aea16fa1d83 100644
--- a/drivers/i2c/busses/i2c-amd-asf-plat.c
+++ b/drivers/i2c/busses/i2c-amd-asf-plat.c
@@ -209,7 +209,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
 	asf_data[0] = dev_msgs->len;
 	memcpy(asf_data + 1, dev_msgs[0].buf, dev_msgs->len);
 
-	ret = piix4_sb800_region_request(&adap->dev, &dev->mmio_cfg);
+	ret = piix4_sb800_region_request(i2c_adapter_dev(adap), &dev->mmio_cfg);
 	if (ret)
 		return ret;
 
@@ -224,7 +224,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
 	ret = amd_asf_access(adap, msgs->addr, msgs[0].buf[0], asf_data);
 	piix4_sb800_port_sel(prev_port, &dev->mmio_cfg);
 	amd_asf_setup_target(dev);
-	piix4_sb800_region_release(&adap->dev, &dev->mmio_cfg);
+	piix4_sb800_region_release(i2c_adapter_dev(adap), &dev->mmio_cfg);
 	return ret;
 }
 

-- 
2.47.3
Re: [PATCH 3/6] i2c: amd-asf-plat: use i2c_adapter_dev()
Posted by Shyam Sundar S K 1 month, 2 weeks ago

On 12/23/2025 15:38, Bartosz Golaszewski wrote:
> Use i2c_adapter_dev() where applicable in order to avoid direct
> dereferencing of struct device embedded within struct i2c_adapter.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

Thanks,
Shyam

> ---
>  drivers/i2c/busses/i2c-amd-asf-plat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c
> index ca45f0f233210a3b03a16c4a240012bd524fefb0..271b1b24417d06cc87733268c3191aea16fa1d83 100644
> --- a/drivers/i2c/busses/i2c-amd-asf-plat.c
> +++ b/drivers/i2c/busses/i2c-amd-asf-plat.c
> @@ -209,7 +209,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>  	asf_data[0] = dev_msgs->len;
>  	memcpy(asf_data + 1, dev_msgs[0].buf, dev_msgs->len);
>  
> -	ret = piix4_sb800_region_request(&adap->dev, &dev->mmio_cfg);
> +	ret = piix4_sb800_region_request(i2c_adapter_dev(adap), &dev->mmio_cfg);
>  	if (ret)
>  		return ret;
>  
> @@ -224,7 +224,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>  	ret = amd_asf_access(adap, msgs->addr, msgs[0].buf[0], asf_data);
>  	piix4_sb800_port_sel(prev_port, &dev->mmio_cfg);
>  	amd_asf_setup_target(dev);
> -	piix4_sb800_region_release(&adap->dev, &dev->mmio_cfg);
> +	piix4_sb800_region_release(i2c_adapter_dev(adap), &dev->mmio_cfg);
>  	return ret;
>  }
>  
>