Route bfqg_stats_add_aux() time accumulation into the destination
stats object instead of the source, aligning with other stat fields.

Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
 block/bfq-cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 9fb9f3533150..6a75fe1c7a5c 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
 	blkg_rwstat_add_aux(&to->merged, &from->merged);
 	blkg_rwstat_add_aux(&to->service_time, &from->service_time);
 	blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
-	bfq_stat_add_aux(&from->time, &from->time);
+	bfq_stat_add_aux(&to->time, &from->time);
 	bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
 	bfq_stat_add_aux(&to->avg_queue_size_samples,
 			  &from->avg_queue_size_samples);
-- 
2.43.0

Hi,

在 2025/12/22 10:19, shechenglong 写道:
> Route bfqg_stats_add_aux() time accumulation into the destination
> stats object instead of the source, aligning with other stat fields.
>
> Signed-off-by: shechenglong <shechenglong@xfusion.com>
> ---
>   block/bfq-cgroup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Please change the title and follow existing prefix:

block, bfq: fix aux stat accumulation destination

Otherwise, feel free to add:

Reviewed-by: Yu Kuai <yukuai@fnnas.com>

>
> diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
> index 9fb9f3533150..6a75fe1c7a5c 100644
> --- a/block/bfq-cgroup.c
> +++ b/block/bfq-cgroup.c
> @@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
>   	blkg_rwstat_add_aux(&to->merged, &from->merged);
>   	blkg_rwstat_add_aux(&to->service_time, &from->service_time);
>   	blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
> -	bfq_stat_add_aux(&from->time, &from->time);
> +	bfq_stat_add_aux(&to->time, &from->time);
>   	bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
>   	bfq_stat_add_aux(&to->avg_queue_size_samples,
>   			  &from->avg_queue_size_samples);

-- 
Thansk,
Kuai

> Please change the title and follow existing prefix:
> block, bfq: fix aux stat accumulation destination
> Otherwise, feel free to add:
> Reviewed-by: Yu Kuai <yukuai@fnnas.com>

Thanks to Yu Kuai for the review and helpful feedback.

shechenglong (1):
  block,bfq: fix aux stat accumulation destination

 block/bfq-cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Best regards,

shechenglong
-- 
2.43.0

On Sun, 28 Dec 2025 21:04:25 +0800, shechenglong wrote:
> > Please change the title and follow existing prefix:
> > block, bfq: fix aux stat accumulation destination
> > Otherwise, feel free to add:
> > Reviewed-by: Yu Kuai <yukuai@fnnas.com>
> 
> Thanks to Yu Kuai for the review and helpful feedback.
> 
> [...]

Applied, thanks!

[1/1] block,bfq: fix aux stat accumulation destination
      commit: 04bdb1a04d8a2a89df504c1e34250cd3c6e31a1c

Best regards,
-- 
Jens Axboe

Route bfqg_stats_add_aux() time accumulation into the destination
stats object instead of the source, aligning with other stat fields.

Reviewed-by: Yu Kuai <yukuai@fnnas.com>
Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
 block/bfq-cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 9fb9f3533150..6a75fe1c7a5c 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
 	blkg_rwstat_add_aux(&to->merged, &from->merged);
 	blkg_rwstat_add_aux(&to->service_time, &from->service_time);
 	blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
-	bfq_stat_add_aux(&from->time, &from->time);
+	bfq_stat_add_aux(&to->time, &from->time);
 	bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
 	bfq_stat_add_aux(&to->avg_queue_size_samples,
 			  &from->avg_queue_size_samples);
-- 
2.43.0