[v2] media: qcom: camss: Add sm6150 camss support

[PATCH v2 0/3] media: qcom: camss: Add sm6150 camss support

Posted by Wenmeng Liu 1 month, 2 weeks ago

SM6150 is a Qualcomm flagship SoC. This series adds support to
the CSIPHY, CSID, VFE/RDI interfaces in SM6150.

The SM6150 platform provides:
 - 2 x VFE (version 170), each with 3 RDI
 - 1 x VFE Lite (version 170), each with 4 RDI
 - 2 x CSID (version 170)
 - 1 x CSID Lite (version 170)
 - 3 x CSIPHY (version 2.0.0)
 - 1 x BPS (Bayer Processing Segment)
 - 1 x ICP (Imaging Control Processor)
 - 1 x IPE (Image Postprocessing Engine)
 - 1 x JPEG Encoder/Decoder
 - 1 x LRME (Low Resolution Motion Estimation)

Tested on Talos EVK board.

Tested with following commands:
media-ctl -d /dev/media0 --reset
media-ctl -d /dev/media0 -V '"imx577 9-001a":0[fmt:SRGGB10/4056x3040 field:none]'
media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
media-ctl -d /dev/media0 -l '"msm_csiphy1":1->"msm_csid0":0[1]'
media-ctl -d /dev/media0 -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
yavta -B capture-mplane  -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 --capture=5

Changes in v2:
- Add more resources(BPS, ICP, IPE, JPEG, LRME) and details for CAMSS.
- Correct the order of the header files. - bob
- Add Csiphy id num, improve the resource name. - Vladimir
- Link to v1:
  https://lore.kernel.org/all/20251016-sm6150-camss-v1-0-e7f64ac32370@oss.qualcomm.com/

---
Wenmeng Liu (3):
      media: dt-bindings: Add qcom,sm6150-camss
      media: qcom: camss: add support for SM6150 camss
      arm64: dts: qcom: talos: Add camss node

 .../bindings/media/qcom,sm6150-camss.yaml          | 439 +++++++++++++++++++++
 arch/arm64/boot/dts/qcom/talos.dtsi                | 200 ++++++++++
 .../platform/qcom/camss/camss-csiphy-3ph-1-0.c     |   2 +
 drivers/media/platform/qcom/camss/camss-vfe.c      |   2 +
 drivers/media/platform/qcom/camss/camss.c          | 189 +++++++++
 drivers/media/platform/qcom/camss/camss.h          |   1 +
 6 files changed, 833 insertions(+)
---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251222-sm6150-camss-2b46fad884dc

Best regards,
-- 
Wenmeng <wenmeng.liu@oss.qualcomm.com>

Re: [PATCH v2 0/3] media: qcom: camss: Add sm6150 camss support

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On Mon, Dec 22, 2025 at 04:28:38PM +0800, Wenmeng Liu wrote:
> SM6150 is a Qualcomm flagship SoC. This series adds support to
> the CSIPHY, CSID, VFE/RDI interfaces in SM6150.
> 
> The SM6150 platform provides:
>  - 2 x VFE (version 170), each with 3 RDI
>  - 1 x VFE Lite (version 170), each with 4 RDI
>  - 2 x CSID (version 170)
>  - 1 x CSID Lite (version 170)
>  - 3 x CSIPHY (version 2.0.0)
>  - 1 x BPS (Bayer Processing Segment)
>  - 1 x ICP (Imaging Control Processor)
>  - 1 x IPE (Image Postprocessing Engine)
>  - 1 x JPEG Encoder/Decoder
>  - 1 x LRME (Low Resolution Motion Estimation)
> 
> Tested on Talos EVK board.
> 
> Tested with following commands:
> media-ctl -d /dev/media0 --reset
> media-ctl -d /dev/media0 -V '"imx577 9-001a":0[fmt:SRGGB10/4056x3040 field:none]'
> media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -d /dev/media0 -l '"msm_csiphy1":1->"msm_csid0":0[1]'
> media-ctl -d /dev/media0 -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
> yavta -B capture-mplane  -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 --capture=5
> 
> Changes in v2:
> - Add more resources(BPS, ICP, IPE, JPEG, LRME) and details for CAMSS.
> - Correct the order of the header files. - bob
> - Add Csiphy id num, improve the resource name. - Vladimir
> - Link to v1:
>   https://lore.kernel.org/all/20251016-sm6150-camss-v1-0-e7f64ac32370@oss.qualcomm.com/

So no changes done in response to what I asked?

Best regards,
Krzysztof

Re: [PATCH v2 0/3] media: qcom: camss: Add sm6150 camss support

Posted by Wenmeng Liu 1 month, 2 weeks ago


On 12/23/2025 9:35 PM, Krzysztof Kozlowski wrote:
> On Mon, Dec 22, 2025 at 04:28:38PM +0800, Wenmeng Liu wrote:
>> SM6150 is a Qualcomm flagship SoC. This series adds support to
>> the CSIPHY, CSID, VFE/RDI interfaces in SM6150.
>>
>> The SM6150 platform provides:
>>   - 2 x VFE (version 170), each with 3 RDI
>>   - 1 x VFE Lite (version 170), each with 4 RDI
>>   - 2 x CSID (version 170)
>>   - 1 x CSID Lite (version 170)
>>   - 3 x CSIPHY (version 2.0.0)
>>   - 1 x BPS (Bayer Processing Segment)
>>   - 1 x ICP (Imaging Control Processor)
>>   - 1 x IPE (Image Postprocessing Engine)
>>   - 1 x JPEG Encoder/Decoder
>>   - 1 x LRME (Low Resolution Motion Estimation)
>>
>> Tested on Talos EVK board.
>>
>> Tested with following commands:
>> media-ctl -d /dev/media0 --reset
>> media-ctl -d /dev/media0 -V '"imx577 9-001a":0[fmt:SRGGB10/4056x3040 field:none]'
>> media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
>> media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
>> media-ctl -d /dev/media0 -l '"msm_csiphy1":1->"msm_csid0":0[1]'
>> media-ctl -d /dev/media0 -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
>> yavta -B capture-mplane  -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 --capture=5
>>
>> Changes in v2:
>> - Add more resources(BPS, ICP, IPE, JPEG, LRME) and details for CAMSS.
>> - Correct the order of the header files. - bob
>> - Add Csiphy id num, improve the resource name. - Vladimir
>> - Link to v1:
>>    https://lore.kernel.org/all/20251016-sm6150-camss-v1-0-e7f64ac32370@oss.qualcomm.com/
> 
> So no changes done in response to what I asked?
> 
> Best regards,
> Krzysztof
> 

I referred to the comments you raised and the latest reviewed 
DT-binding, but since this was not explicitly mentioned in my previous 
patch, I did not include it in the change description.


Thanks,
Wenmeng