Document the Samsung SOFEF03-M Display-Driver-IC and 1080x2520@120Hz DSI
command-mode panels found in the Sony Xperia 5 II and Sony Xperia 5 III.
It requires Display Stream Compression 1.1 which allows the panels to be
driven at 120Hz, even though a 60Hz mode is available too.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
.../bindings/display/panel/samsung,sofef03-m.yaml | 79 ++++++++++++++++++++++
MAINTAINERS | 5 ++
2 files changed, 84 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml b/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml
new file mode 100644
index 000000000000..5712eca2773d
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/samsung,sofef03-m.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SOFEF03-M DDI for 1080x2520@120Hz 6.1" OLED DSI panels
+
+maintainers:
+ - Marijn Suijten <marijn.suijten@somainline.org>
+
+description: |
+ Samsung SOFEF03-M Display-Driver-IC found in the Sony Xperia 5 II (edo pdx206, amb609vp01
+ panel) and
+ Sony Xperia 5 III (sagami pdx214, amb609vp04
+ panel) smartphones. It is always programmed with Display Stream Compression 1.1 enabled.
+
+ The assembly features a Samsung touchscreen compatible with
+ samsung,s6sy761.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ enum:
+ - samsung,sofef03-m-amb609vp01
+ - samsung,sofef03-m-amb609vp04
+
+ port: true
+
+ reg:
+ maxItems: 1
+ description: DSI virtual channel
+
+ reset-gpios: true
+
+ vci-supply:
+ description: DriverIC Operation supply (3.0V)
+
+ vddio-supply:
+ description: I/O voltage supply (1.8V)
+
+required:
+ - compatible
+ - port
+ - reg
+ - reset-gpios
+ - vci-supply
+ - vddio-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel@0 {
+ compatible = "samsung,sofef03-m-amb609vp01";
+ reg = <0>;
+
+ reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
+
+ vci-supply = <&vreg_l11c_3p0>;
+ vddio-supply = <&vreg_l14a_1p8>;
+
+ port {
+ endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
+ };
+ };
+ };
+
+...
+
diff --git a/MAINTAINERS b/MAINTAINERS
index cd2c924749d3..e48dd7f5a115 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8200,6 +8200,11 @@ S: Maintained
F: Documentation/devicetree/bindings/display/panel/samsung,sofef01-m.yaml
F: drivers/gpu/drm/panel/panel-samsung-sofef01.c
+DRM DRIVER FOR SAMSUNG SOFEF03 DDIC
+M: Marijn Suijten <marijn.suijten@somainline.org>
+S: Maintained
+F: Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml
+
DRM DRIVER FOR SHARP MEMORY LCD
M: Alex Lanzano <lanzano.alex@gmail.com>
S: Maintained
--
2.52.0On Mon, 22 Dec 2025 00:32:12 +0100, Marijn Suijten wrote: > Document the Samsung SOFEF03-M Display-Driver-IC and 1080x2520@120Hz DSI > command-mode panels found in the Sony Xperia 5 II and Sony Xperia 5 III. > It requires Display Stream Compression 1.1 which allows the panels to be > driven at 120Hz, even though a 60Hz mode is available too. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > .../bindings/display/panel/samsung,sofef03-m.yaml | 79 ++++++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 84 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,sofef01-m.example.dtb: panel@0 (samsung,sofef01-m-amb609tc01): 'vci-supply' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/display/panel/samsung,sofef01-m.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20251222-drm-panels-sony-v2-6-82a87465d163@somainline.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Dec 22, 2025 at 12:32:12AM +0100, Marijn Suijten wrote:
> Document the Samsung SOFEF03-M Display-Driver-IC and 1080x2520@120Hz DSI
> command-mode panels found in the Sony Xperia 5 II and Sony Xperia 5 III.
> It requires Display Stream Compression 1.1 which allows the panels to be
> driven at 120Hz, even though a 60Hz mode is available too.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Your patchset has multiple white space warnings. Apply and see...
> ---
> .../bindings/display/panel/samsung,sofef03-m.yaml | 79 ++++++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 84 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml b/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml
> new file mode 100644
> index 000000000000..5712eca2773d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/samsung,sofef03-m.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung SOFEF03-M DDI for 1080x2520@120Hz 6.1" OLED DSI panels
> +
> +maintainers:
> + - Marijn Suijten <marijn.suijten@somainline.org>
> +
> +description: |
> + Samsung SOFEF03-M Display-Driver-IC found in the Sony Xperia 5 II (edo pdx206, amb609vp01
> + panel) and
> + Sony Xperia 5 III (sagami pdx214, amb609vp04
> + panel) smartphones. It is always programmed with Display Stream Compression 1.1 enabled.
Please wrap according to Linux coding style.
> +
> + The assembly features a Samsung touchscreen compatible with
> + samsung,s6sy761.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - samsung,sofef03-m-amb609vp01
> + - samsung,sofef03-m-amb609vp04
> +
> + port: true
> +
> + reg:
> + maxItems: 1
> + description: DSI virtual channel
> +
> + reset-gpios: true
> +
> + vci-supply:
> + description: DriverIC Operation supply (3.0V)
> +
> + vddio-supply:
> + description: I/O voltage supply (1.8V)
> +
> +required:
> + - compatible
> + - port
> + - reg
> + - reset-gpios
> + - vci-supply
> + - vddio-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel@0 {
> + compatible = "samsung,sofef03-m-amb609vp01";
> + reg = <0>;
> +
> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> +
> + vci-supply = <&vreg_l11c_3p0>;
> + vddio-supply = <&vreg_l14a_1p8>;
> +
> + port {
Not tested :/
Best regards,
Krzysztof
On 22/12/2025 09:33, Krzysztof Kozlowski wrote:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + dsi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + panel@0 {
>> + compatible = "samsung,sofef03-m-amb609vp01";
>> + reg = <0>;
>> +
>> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
>> +
>> + vci-supply = <&vreg_l11c_3p0>;
>> + vddio-supply = <&vreg_l14a_1p8>;
>> +
>> + port {
>
> Not tested :/
Ah no, this one is correct. It's the other patch with similar compatible
which was not tested.
Actually two others were not tested. We are not a testing service - it
is your task.
Best regards,
Krzysztof
On 2025-12-22 09:36:23, Krzysztof Kozlowski wrote:
> On 22/12/2025 09:33, Krzysztof Kozlowski wrote:
> >> + - |
> >> + #include <dt-bindings/gpio/gpio.h>
> >> +
> >> + dsi {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + panel@0 {
> >> + compatible = "samsung,sofef03-m-amb609vp01";
> >> + reg = <0>;
> >> +
> >> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> >> +
> >> + vci-supply = <&vreg_l11c_3p0>;
> >> + vddio-supply = <&vreg_l14a_1p8>;
> >> +
> >> + port {
> >
> > Not tested :/
>
> Ah no, this one is correct. It's the other patch with similar compatible
> which was not tested.
I think you mean:
.output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
.output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'port' is a required property
from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
Which looks to be fixed by including panel-common-dual.yaml and changing `port`
to `ports` in the properties and required table? At least the errors are gone,
just asking if that is acceptable.
Then:
.output/Documentation/devicetree/bindings/display/panel/samsung,sofef01-m.example.dtb: panel@0 (samsung,sofef01-m-amb609tc01): 'vci-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/display/panel/samsung,sofef01-m.yaml
Which I do not immediately understand how to resolve. I'd believe there's a
problem with the conditional inclusion of this vci-supply property based on the
compatible name, but do not see where the problem lies as other dt-bindings seem
to write it this way as well. Can you point this out to me?
Alternatively I'll drop the example with vci-supply, but this'll return when
said panel is committed to DTS.
Lastly checkpatch complains that the "lgd" prefix isn't a valid vendor. Should
I add "LG Display" to the list or rename it to "lg,"?
> Actually two others were not tested. We are not a testing service - it
> is your task.
That is not very kind; sometimes things might slip through and it's nice if CI
catches them at a last resort.
- Marijn
On Sun, Dec 28, 2025 at 11:49:13PM +0100, Marijn Suijten wrote:
> On 2025-12-22 09:36:23, Krzysztof Kozlowski wrote:
> > On 22/12/2025 09:33, Krzysztof Kozlowski wrote:
> > >> + - |
> > >> + #include <dt-bindings/gpio/gpio.h>
> > >> +
> > >> + dsi {
> > >> + #address-cells = <1>;
> > >> + #size-cells = <0>;
> > >> + panel@0 {
> > >> + compatible = "samsung,sofef03-m-amb609vp01";
> > >> + reg = <0>;
> > >> +
> > >> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> > >> +
> > >> + vci-supply = <&vreg_l11c_3p0>;
> > >> + vddio-supply = <&vreg_l14a_1p8>;
> > >> +
> > >> + port {
> > >
> > > Not tested :/
> >
> > Ah no, this one is correct. It's the other patch with similar compatible
> > which was not tested.
>
> I think you mean:
>
> .output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
> .output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'port' is a required property
> from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
>
> Which looks to be fixed by including panel-common-dual.yaml and changing `port`
> to `ports` in the properties and required table? At least the errors are gone,
> just asking if that is acceptable.
Considering it's a dual interface panel, yes, that's the right change.
Rob
On 2025-12-22 09:33:04, Krzysztof Kozlowski wrote: > On Mon, Dec 22, 2025 at 12:32:12AM +0100, Marijn Suijten wrote: > > Document the Samsung SOFEF03-M Display-Driver-IC and 1080x2520@120Hz DSI > > command-mode panels found in the Sony Xperia 5 II and Sony Xperia 5 III. > > It requires Display Stream Compression 1.1 which allows the panels to be > > driven at 120Hz, even though a 60Hz mode is available too. > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > > Your patchset has multiple white space warnings. Apply and see... I am sorry for missing this. I've asked b4 upstream to include diff --check validation in their prep --check pass as I did not save + reapply my own series before sending with this workflow. - Marijn
© 2016 - 2026 Red Hat, Inc.