1. Patchew
  2. linux
  3. View series

[PATCH] rust: configfs: replace `kernel::c_str!` with C-Strings

Tamir Duberstein posted 1 patch 1 month, 2 weeks ago 
rust/kernel/configfs.rs       | 9 +++++----
samples/rust/rust_configfs.rs | 5 ++---
2 files changed, 7 insertions(+), 7 deletions(-)
[PATCH] rust: configfs: replace `kernel::c_str!` with C-Strings
Posted by Tamir Duberstein 1 month, 2 weeks ago 
From: Tamir Duberstein <tamird@gmail.com>

C-String literals were added in Rust 1.77. Replace instances of
`kernel::c_str!` with C-String literals where possible.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Benno Lossin <lossin@kernel.org>
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Acked-by: Andreas Hindborg <a.hindborg@kernel.org>
---
 rust/kernel/configfs.rs       | 9 +++++----
 samples/rust/rust_configfs.rs | 5 ++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs
index 466fb7f40762..2339c6467325 100644
--- a/rust/kernel/configfs.rs
+++ b/rust/kernel/configfs.rs
@@ -21,7 +21,6 @@
 //!
 //! ```ignore
 //! use kernel::alloc::flags;
-//! use kernel::c_str;
 //! use kernel::configfs_attrs;
 //! use kernel::configfs;
 //! use kernel::new_mutex;
@@ -50,7 +49,7 @@
 //!
 //!         try_pin_init!(Self {
 //!             config <- configfs::Subsystem::new(
-//!                 c_str!("rust_configfs"), item_type, Configuration::new()
+//!                 c"rust_configfs", item_type, Configuration::new()
 //!             ),
 //!         })
 //!     }
@@ -66,7 +65,7 @@
 //! impl Configuration {
 //!     fn new() -> impl PinInit<Self, Error> {
 //!         try_pin_init!(Self {
-//!             message: c_str!("Hello World\n"),
+//!             message: c"Hello World\n",
 //!             bar <- new_mutex!((KBox::new([0; PAGE_SIZE], flags::GFP_KERNEL)?, 0)),
 //!         })
 //!     }
@@ -1000,7 +999,9 @@ macro_rules! configfs_attrs {
                     static [< $data:upper _ $name:upper _ATTR >]:
                         $crate::configfs::Attribute<$attr, $data, $data> =
                             unsafe {
-                                $crate::configfs::Attribute::new(c_str!(::core::stringify!($name)))
+                                $crate::configfs::Attribute::new(
+                                    $crate::c_str!(::core::stringify!($name)),
+                                )
                             };
                 )*
 
diff --git a/samples/rust/rust_configfs.rs b/samples/rust/rust_configfs.rs
index 0ccc7553ef39..a1bd9db6010d 100644
--- a/samples/rust/rust_configfs.rs
+++ b/samples/rust/rust_configfs.rs
@@ -3,7 +3,6 @@
 //! Rust configfs sample.
 
 use kernel::alloc::flags;
-use kernel::c_str;
 use kernel::configfs;
 use kernel::configfs::configfs_attrs;
 use kernel::new_mutex;
@@ -35,7 +34,7 @@ struct Configuration {
 impl Configuration {
     fn new() -> impl PinInit<Self, Error> {
         try_pin_init!(Self {
-            message: c_str!("Hello World\n"),
+            message: c"Hello World\n",
             bar <- new_mutex!((KBox::new([0; PAGE_SIZE], flags::GFP_KERNEL)?, 0)),
         })
     }
@@ -61,7 +60,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit<Self, Error> {
 
         try_pin_init!(Self {
             config <- configfs::Subsystem::new(
-                c_str!("rust_configfs"), item_type, Configuration::new()
+                c"rust_configfs", item_type, Configuration::new()
             ),
         })
     }

---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251222-cstr-configfs-3e5e5092f187

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>
Re: [PATCH] rust: configfs: replace `kernel::c_str!` with C-Strings
Posted by Andreas Hindborg 3 weeks, 2 days ago 
On Mon, 22 Dec 2025 13:12:20 +0100, Tamir Duberstein wrote:
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
> 
> 

Applied, thanks!

[1/1] rust: configfs: replace `kernel::c_str!` with C-Strings
      commit: 1d40cb05e077bb294f128c6a52630b93e452a8ed

Best regards,
-- 
Andreas Hindborg <a.hindborg@kernel.org>
Re: [PATCH] rust: configfs: replace `kernel::c_str!` with C-Strings
Posted by Tamir Duberstein 1 month ago 
On Mon, Dec 22, 2025 at 7:12 AM Tamir Duberstein <tamird@kernel.org> wrote:
>
> From: Tamir Duberstein <tamird@gmail.com>
>
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Reviewed-by: Benno Lossin <lossin@kernel.org>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> Acked-by: Andreas Hindborg <a.hindborg@kernel.org>
> ---
>  rust/kernel/configfs.rs       | 9 +++++----
>  samples/rust/rust_configfs.rs | 5 ++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs
> index 466fb7f40762..2339c6467325 100644
> --- a/rust/kernel/configfs.rs
> +++ b/rust/kernel/configfs.rs
> @@ -21,7 +21,6 @@
>  //!
>  //! ```ignore
>  //! use kernel::alloc::flags;
> -//! use kernel::c_str;
>  //! use kernel::configfs_attrs;
>  //! use kernel::configfs;
>  //! use kernel::new_mutex;
> @@ -50,7 +49,7 @@
>  //!
>  //!         try_pin_init!(Self {
>  //!             config <- configfs::Subsystem::new(
> -//!                 c_str!("rust_configfs"), item_type, Configuration::new()
> +//!                 c"rust_configfs", item_type, Configuration::new()
>  //!             ),
>  //!         })
>  //!     }
> @@ -66,7 +65,7 @@
>  //! impl Configuration {
>  //!     fn new() -> impl PinInit<Self, Error> {
>  //!         try_pin_init!(Self {
> -//!             message: c_str!("Hello World\n"),
> +//!             message: c"Hello World\n",
>  //!             bar <- new_mutex!((KBox::new([0; PAGE_SIZE], flags::GFP_KERNEL)?, 0)),
>  //!         })
>  //!     }
> @@ -1000,7 +999,9 @@ macro_rules! configfs_attrs {
>                      static [< $data:upper _ $name:upper _ATTR >]:
>                          $crate::configfs::Attribute<$attr, $data, $data> =
>                              unsafe {
> -                                $crate::configfs::Attribute::new(c_str!(::core::stringify!($name)))
> +                                $crate::configfs::Attribute::new(
> +                                    $crate::c_str!(::core::stringify!($name)),
> +                                )
>                              };
>                  )*
>
> diff --git a/samples/rust/rust_configfs.rs b/samples/rust/rust_configfs.rs
> index 0ccc7553ef39..a1bd9db6010d 100644
> --- a/samples/rust/rust_configfs.rs
> +++ b/samples/rust/rust_configfs.rs
> @@ -3,7 +3,6 @@
>  //! Rust configfs sample.
>
>  use kernel::alloc::flags;
> -use kernel::c_str;
>  use kernel::configfs;
>  use kernel::configfs::configfs_attrs;
>  use kernel::new_mutex;
> @@ -35,7 +34,7 @@ struct Configuration {
>  impl Configuration {
>      fn new() -> impl PinInit<Self, Error> {
>          try_pin_init!(Self {
> -            message: c_str!("Hello World\n"),
> +            message: c"Hello World\n",
>              bar <- new_mutex!((KBox::new([0; PAGE_SIZE], flags::GFP_KERNEL)?, 0)),
>          })
>      }
> @@ -61,7 +60,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit<Self, Error> {
>
>          try_pin_init!(Self {
>              config <- configfs::Subsystem::new(
> -                c_str!("rust_configfs"), item_type, Configuration::new()
> +                c"rust_configfs", item_type, Configuration::new()
>              ),
>          })
>      }
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-configfs-3e5e5092f187
>
> Best regards,
> --
> Tamir Duberstein <tamird@gmail.com>
>

@Andreas could you please have a look?
Re: [PATCH] rust: configfs: replace `kernel::c_str!` with C-Strings
Posted by Andreas Hindborg 1 month ago 
Tamir Duberstein <tamird@gmail.com> writes:

> On Mon, Dec 22, 2025 at 7:12 AM Tamir Duberstein <tamird@kernel.org> wrote:
>>
>> From: Tamir Duberstein <tamird@gmail.com>
>>
>> C-String literals were added in Rust 1.77. Replace instances of
>> `kernel::c_str!` with C-String literals where possible.
>>
>> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>> Reviewed-by: Benno Lossin <lossin@kernel.org>
>> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
>> Acked-by: Andreas Hindborg <a.hindborg@kernel.org>
>
> @Andreas could you please have a look?

I'll take it for next cycle.


Best regards,
Andreas Hindborg

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.