rust: miscdevice: replace `kernel::c_str!` with C-Strings

[PATCH] rust: miscdevice: replace `kernel::c_str!` with C-Strings

Posted by Tamir Duberstein 1 month, 2 weeks ago

From: Tamir Duberstein <tamird@gmail.com>

C-String literals were added in Rust 1.77. Replace instances of
`kernel::c_str!` with C-String literals where possible.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Benno Lossin <lossin@kernel.org>
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 samples/rust/rust_misc_device.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/samples/rust/rust_misc_device.rs b/samples/rust/rust_misc_device.rs
index d69bc33dbd99..49dd5814e1ab 100644
--- a/samples/rust/rust_misc_device.rs
+++ b/samples/rust/rust_misc_device.rs
@@ -98,7 +98,6 @@
 use core::pin::Pin;
 
 use kernel::{
-    c_str,
     device::Device,
     fs::{File, Kiocb},
     ioctl::{_IO, _IOC_SIZE, _IOR, _IOW},
@@ -133,7 +132,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit<Self, Error> {
         pr_info!("Initialising Rust Misc Device Sample\n");
 
         let options = MiscDeviceOptions {
-            name: c_str!("rust-misc-device"),
+            name: c"rust-misc-device",
         };
 
         try_pin_init!(Self {

---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251222-cstr-char-misc-0f4144d0a7b2

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>

Re: [PATCH] rust: miscdevice: replace `kernel::c_str!` with C-Strings

Posted by Daniel Almeida 1 month, 2 weeks ago


> On 22 Dec 2025, at 09:21, Tamir Duberstein <tamird@kernel.org> wrote:
> 
> From: Tamir Duberstein <tamird@gmail.com>
> 
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Reviewed-by: Benno Lossin <lossin@kernel.org>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> samples/rust/rust_misc_device.rs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/samples/rust/rust_misc_device.rs b/samples/rust/rust_misc_device.rs
> index d69bc33dbd99..49dd5814e1ab 100644
> --- a/samples/rust/rust_misc_device.rs
> +++ b/samples/rust/rust_misc_device.rs
> @@ -98,7 +98,6 @@
> use core::pin::Pin;
> 
> use kernel::{
> -    c_str,
>     device::Device,
>     fs::{File, Kiocb},
>     ioctl::{_IO, _IOC_SIZE, _IOR, _IOW},
> @@ -133,7 +132,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit<Self, Error> {
>         pr_info!("Initialising Rust Misc Device Sample\n");
> 
>         let options = MiscDeviceOptions {
> -            name: c_str!("rust-misc-device"),
> +            name: c"rust-misc-device",
>         };
> 
>         try_pin_init!(Self {
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-char-misc-0f4144d0a7b2
> 
> Best regards,
> --  
> Tamir Duberstein <tamird@gmail.com>
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>