rnull: replace `kernel::c_str!` with C-Strings

[PATCH] rnull: replace `kernel::c_str!` with C-Strings

Posted by Tamir Duberstein 1 month, 2 weeks ago

From: Tamir Duberstein <tamird@gmail.com>

C-String literals were added in Rust 1.77. Replace instances of
`kernel::c_str!` with C-String literals where possible.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 drivers/block/rnull/configfs.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/rnull/configfs.rs b/drivers/block/rnull/configfs.rs
index 6713a6d92391..2f5a7da03af5 100644
--- a/drivers/block/rnull/configfs.rs
+++ b/drivers/block/rnull/configfs.rs
@@ -25,7 +25,7 @@ pub(crate) fn subsystem() -> impl PinInit<kernel::configfs::Subsystem<Config>, E
         ],
     };
 
-    kernel::configfs::Subsystem::new(c_str!("rnull"), item_type, try_pin_init!(Config {}))
+    kernel::configfs::Subsystem::new(c"rnull", item_type, try_pin_init!(Config {}))
 }
 
 #[pin_data]

---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251222-cstr-block-0611c0c035e3

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>

Re: [PATCH] rnull: replace `kernel::c_str!` with C-Strings

Posted by Daniel Almeida 1 month, 2 weeks ago


> On 22 Dec 2025, at 09:26, Tamir Duberstein <tamird@kernel.org> wrote:
> 
> From: Tamir Duberstein <tamird@gmail.com>
> 
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> drivers/block/rnull/configfs.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/rnull/configfs.rs b/drivers/block/rnull/configfs.rs
> index 6713a6d92391..2f5a7da03af5 100644
> --- a/drivers/block/rnull/configfs.rs
> +++ b/drivers/block/rnull/configfs.rs
> @@ -25,7 +25,7 @@ pub(crate) fn subsystem() -> impl PinInit<kernel::configfs::Subsystem<Config>, E
>         ],
>     };
> 
> -    kernel::configfs::Subsystem::new(c_str!("rnull"), item_type, try_pin_init!(Config {}))
> +    kernel::configfs::Subsystem::new(c"rnull", item_type, try_pin_init!(Config {}))
> }
> 
> #[pin_data]
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-block-0611c0c035e3
> 
> Best regards,
> --  
> Tamir Duberstein <tamird@gmail.com>
> 
> 


Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>

Re: [PATCH] rnull: replace `kernel::c_str!` with C-Strings

Posted by Jens Axboe 1 month, 2 weeks ago

On Mon, 22 Dec 2025 13:26:19 +0100, Tamir Duberstein wrote:
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
> 
> 

Applied, thanks!

[1/1] rnull: replace `kernel::c_str!` with C-Strings
      commit: 8818fa7010a53af03d2584a2b80772aeeeeba209

Best regards,
-- 
Jens Axboe