[v1] Add Axiado AX3000 eMMC Host Controller Support

[PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support

Posted by Tzu-Hao Wei 1 month, 2 weeks ago

This patch series adds support for the eMMC host controller found on
the Axiado AX3000 SoC. The implementation includes support for an
external Arasan eMMC PHY that enables HS200 mode operation at 200 MHz,
significantly improving performance over the default 25 MHz operation.

Hardware Details:

Arasan eMMC host controller on AX3000 SoC
External Arasan eMMC PHY (different from internal PHY supported
by the standard sdhci-of-arasan driver)
Support for HS200 mode (200 MHz) operation
Integration with existing SDHCI framework
Implementation Overview:
The series adds support for the external eMMC PHY required for HS200
mode. The existing sdhci-of-arasan.c driver supports internal PHY
configurations, but the AX3000 uses an external PHY that requires
different configuration. The PHY driver was implemented based on the
reference code in sdhci-pci-arasan.c as recommended by the Arasan team.

This series includes:
1. Device tree bindings for the eMMC PHY
2. PHY driver implementation for the external Arasan eMMC PHY
3. Integration of PHY support into the sdhci-of-arasan host driver
4. Device tree bindings for the eMMC host controller variant
5. Device tree source files for the SoC and EVK board
6. MAINTAINERS file update

Patch series structure:
[1/8] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY document
[2/8] phy: axiado: add Arasan eMMC-PHY for Axiado
[3/8] arm64: dts: axiado: Add eMMC-PHY node support
[4/8] MAINTAINERS: Update entry for Axiado eMMC PHY
[5/8] dt-bindings: mmc: axiado: Add axiado eMMC variant
[6/8] mmc: host: axiado: add AX3000 eMMC PHY support to sdhci-of-arasan
[7/8] arm64: dts: axiado: add common sdhci host node in dtsi
[8/8] arm64: dts: axiado: enable sdhci host

The driver follows the standard Linux PHY framework and integrates
seamlessly with the existing SDHCI subsystem. The implementation
maintains compatibility with the standard Arasan host controller
driver while adding the necessary support for the external PHY.

Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
SriNavmani A (8):
      dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY document
      phy: axiado: add Arasan eMMC-PHY for Axiado
      arm64: dts: axiado: Add eMMC-PHY node support
      MAINTAINERS: Update entry for Axiado eMMC PHY
      dt-bindings: mmc: axiado: Add axiado eMMC variant
      mmc: host: axiado: add AX3000 eMMC PHY support to sdhci-of-arasan
      arm64: dts: axiado: add common sdhci host node in dtsi
      arm64: dts: axiado: enable sdhci host

 .../devicetree/bindings/mmc/arasan,sdhci.yaml      |  18 ++
 .../bindings/phy/axiado,ax3000-emmc-phy.yaml       |  46 ++++
 MAINTAINERS                                        |  10 +
 arch/arm64/boot/dts/axiado/ax3000-evk.dts          |   8 +
 arch/arm64/boot/dts/axiado/ax3000.dtsi             |  20 ++
 drivers/mmc/host/sdhci-of-arasan.c                 |  20 +-
 drivers/phy/Kconfig                                |   1 +
 drivers/phy/Makefile                               |   1 +
 drivers/phy/axiado/Kconfig                         |  15 ++
 drivers/phy/axiado/Makefile                        |   1 +
 drivers/phy/axiado/phy-axiado-emmc.c               | 260 +++++++++++++++++++++
 11 files changed, 393 insertions(+), 7 deletions(-)
---
base-commit: 9448598b22c50c8a5bb77a9103e2d49f134c9578
change-id: 20251222-axiado-ax3000-add-emmc-host-driver-support-2cc84a8f889a

Best regards,
-- 
Tzu-Hao Wei <twei@axiado.com>

Re: [PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On Mon, Dec 22, 2025 at 04:44:59PM +0800, Tzu-Hao Wei wrote:
> This patch series adds support for the eMMC host controller found on
> the Axiado AX3000 SoC. The implementation includes support for an
> external Arasan eMMC PHY that enables HS200 mode operation at 200 MHz,
> significantly improving performance over the default 25 MHz operation.
> 
> Hardware Details:
> 
> Arasan eMMC host controller on AX3000 SoC
> External Arasan eMMC PHY (different from internal PHY supported
> by the standard sdhci-of-arasan driver)
> Support for HS200 mode (200 MHz) operation
> Integration with existing SDHCI framework
> Implementation Overview:
> The series adds support for the external eMMC PHY required for HS200
> mode. The existing sdhci-of-arasan.c driver supports internal PHY
> configurations, but the AX3000 uses an external PHY that requires
> different configuration. The PHY driver was implemented based on the
> reference code in sdhci-pci-arasan.c as recommended by the Arasan team.
> 
> This series includes:
> 1. Device tree bindings for the eMMC PHY
> 2. PHY driver implementation for the external Arasan eMMC PHY
> 3. Integration of PHY support into the sdhci-of-arasan host driver
> 4. Device tree bindings for the eMMC host controller variant
> 5. Device tree source files for the SoC and EVK board
> 6. MAINTAINERS file update

You completely disorganized the patch.. dts is mixed all over driver
code, you combined two or three completely independent subsystems into
one.

Read submitting patches in DT dir to understand how DTS must be sent.


Best regards,
Krzysztof

Re: [PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support

Posted by Tzu-Hao Wei 1 month ago

On 12/23/2025 10:33 PM, Krzysztof Kozlowski wrote:
> 
> You completely disorganized the patch.. dts is mixed all over driver
> code, you combined two or three completely independent subsystems into
> one.
> 
> Read submitting patches in DT dir to understand how DTS must be sent.
> 
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,

Appreciate your review comments. We reorganized the patch series per your review comments, separating the DTS changes and applying the driver code changes to the respective subsystems as following
https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-phy-driver-support-v1-0-dd43459dbfea@axiado.com/
https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-host-driver-support-v2-0-934f1a61f7c0@axiado.com/

We will also sync up internally and tighten our review process to ensure this kind of mistake does not happen again in future submissions.

Best regards,
TH

Re: [PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support

Posted by Krzysztof Kozlowski 3 weeks, 6 days ago

On 09/01/2026 10:48, Tzu-Hao Wei wrote:
> On 12/23/2025 10:33 PM, Krzysztof Kozlowski wrote:
>>
>> You completely disorganized the patch.. dts is mixed all over driver
>> code, you combined two or three completely independent subsystems into
>> one.
>>
>> Read submitting patches in DT dir to understand how DTS must be sent.
>>
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
> 
> Appreciate your review comments. We reorganized the patch series per your review comments, separating the DTS changes and applying the driver code changes to the respective subsystems as following

Please wrap your emails correctly.

> https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-phy-driver-support-v1-0-dd43459dbfea@axiado.com/


You sent this as v1, which I noticed only now. If I knew you ignored my
feedback, I would not care to review again... Lesson for me.

> https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-host-driver-support-v2-0-934f1a61f7c0@axiado.com/
> 
> We will also sync up internally and tighten our review process to ensure this kind of mistake does not happen again in future submissions.

Best regards,
Krzysztof