[PATCH v3 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub

Swati Agarwal posted 4 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH v3 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub
Posted by Swati Agarwal 1 month, 3 weeks ago
Add the binding for the USB3.2 Genesys Logic GL3590 hub.

Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
---
 .../devicetree/bindings/usb/genesys,gl850g.yaml      | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
index 9a94b2a74a1e..a184e1074c7c 100644
--- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
+++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
@@ -15,6 +15,7 @@ properties:
       - usb5e3,608
       - usb5e3,610
       - usb5e3,620
+      - usb5e3,625
       - usb5e3,626
 
   reg: true
@@ -69,6 +70,17 @@ allOf:
         peer-hub: true
         vdd-supply: true
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - usb5e3,625
+    then:
+      properties:
+        peer-hub: true
+        vdd-supply: false
+
 unevaluatedProperties: false
 
 examples:
-- 
2.34.1
Re: [PATCH v3 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago
On Sat, Dec 20, 2025 at 12:05:34PM +0530, Swati Agarwal wrote:
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - usb5e3,625
> +    then:
> +      properties:
> +        peer-hub: true
> +        vdd-supply: false

This is not true. I clearly see VP33, AVDD and VP10 (and maybe more)
supplies. Not only in pin list, but high level diagram clearly marks two
supplies.

Please read again datasheet carefully, because that's your task, not
mine. I do not have even access to most of the datasheets, so  you
expecting me to do it is just unfair.

Best regards,
Krzysztof