[PATCH v3 08/14] tools/nolibc: use custom structs timespec and timeval

Thomas Weißschuh posted 14 patches 1 month, 2 weeks ago
[PATCH v3 08/14] tools/nolibc: use custom structs timespec and timeval
Posted by Thomas Weißschuh 1 month, 2 weeks ago
A custom 'struct timespec' and 'struct timeval' will be necessary for
64-bit time types on 32-bit architectures. <linux/time.h> will define
other time-related types in terms of the custom 'struct timespec'.

Add custom struct definitions which for now mirror exactly the ones from
the UAPI headers, but provide the foundation for further changes.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Acked-by: Willy Tarreau <w@1wt.eu>
---
 tools/include/nolibc/arch-s390.h |  3 +++
 tools/include/nolibc/types.h     | 16 +++++++++++++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/tools/include/nolibc/arch-s390.h b/tools/include/nolibc/arch-s390.h
index 74125a254ce3..5bee6ecbde0a 100644
--- a/tools/include/nolibc/arch-s390.h
+++ b/tools/include/nolibc/arch-s390.h
@@ -5,6 +5,9 @@
 
 #ifndef _NOLIBC_ARCH_S390_H
 #define _NOLIBC_ARCH_S390_H
+
+#include "types.h"
+
 #include <linux/signal.h>
 #include <linux/unistd.h>
 
diff --git a/tools/include/nolibc/types.h b/tools/include/nolibc/types.h
index 470a5f77bc0f..5d180ffabcb6 100644
--- a/tools/include/nolibc/types.h
+++ b/tools/include/nolibc/types.h
@@ -13,9 +13,23 @@
 #include "std.h"
 #include <linux/mman.h>
 #include <linux/stat.h>
-#include <linux/time.h>
+#include <linux/time_types.h>
 #include <linux/wait.h>
 
+struct timespec {
+	__kernel_old_time_t	tv_sec;
+	long			tv_nsec;
+};
+#define _STRUCT_TIMESPEC
+
+struct timeval {
+	__kernel_old_time_t	tv_sec;
+	__kernel_suseconds_t	tv_usec;
+};
+
+#define timeval __nolibc_kernel_timeval
+#include <linux/time.h>
+#undef timeval
 
 /* Only the generic macros and types may be defined here. The arch-specific
  * ones such as the O_RDONLY and related macros used by fcntl() and open()

-- 
2.52.0

Re: [PATCH v3 08/14] tools/nolibc: use custom structs timespec and timeval
Posted by Arnd Bergmann 1 month, 2 weeks ago
On Sat, Dec 20, 2025, at 14:55, Thomas Weißschuh wrote:
> 
> +struct timespec {
> +	__kernel_old_time_t	tv_sec;
> +	long			tv_nsec;
> +};
> +#define _STRUCT_TIMESPEC
> +
> +struct timeval {
> +	__kernel_old_time_t	tv_sec;
> +	__kernel_suseconds_t	tv_usec;
> +};
> +
> +#define timeval __nolibc_kernel_timeval
> +#include <linux/time.h>
> +#undef timeval

This looks like an appropriate workaround for nolibc so
it can work with old kernel headers, but I feel like we
need to also fix the kernel headers so at some point in
the future we won't need those workarounds any more.

    Arnd