ACPI: APEI: EINJ: make read-only array non_mmio_desc static const

[PATCH][next] ACPI: APEI: EINJ: make read-only array non_mmio_desc static const

Posted by Colin Ian King 1 month, 2 weeks ago

Don't populate the read-only array non_mmio_desc on the stack at run
time, instead make it static const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/acpi/apei/einj-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
index 305c240a303f..f5bfdffe1e43 100644
--- a/drivers/acpi/apei/einj-core.c
+++ b/drivers/acpi/apei/einj-core.c
@@ -679,7 +679,7 @@ static bool is_allowed_range(u64 base_addr, u64 size)
 	 * region intersects with known resource. So do an allow list check for
 	 * IORES_DESCs that definitely or most likely not MMIO.
 	 */
-	int non_mmio_desc[] = {
+	static const int non_mmio_desc[] = {
 		IORES_DESC_CRASH_KERNEL,
 		IORES_DESC_ACPI_TABLES,
 		IORES_DESC_ACPI_NV_STORAGE,
-- 
2.51.0

Re: [PATCH][next] ACPI: APEI: EINJ: make read-only array non_mmio_desc static const

Posted by Rafael J. Wysocki 1 month ago

On Fri, Dec 19, 2025 at 11:00 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> Don't populate the read-only array non_mmio_desc on the stack at run
> time, instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/acpi/apei/einj-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
> index 305c240a303f..f5bfdffe1e43 100644
> --- a/drivers/acpi/apei/einj-core.c
> +++ b/drivers/acpi/apei/einj-core.c
> @@ -679,7 +679,7 @@ static bool is_allowed_range(u64 base_addr, u64 size)
>          * region intersects with known resource. So do an allow list check for
>          * IORES_DESCs that definitely or most likely not MMIO.
>          */
> -       int non_mmio_desc[] = {
> +       static const int non_mmio_desc[] = {
>                 IORES_DESC_CRASH_KERNEL,
>                 IORES_DESC_ACPI_TABLES,
>                 IORES_DESC_ACPI_NV_STORAGE,
> --

Applied as 6.20 material, thanks!