scsi: ufs: host: mediatek: make read-only array scale_us static const

[PATCH][next] scsi: ufs: host: mediatek: make read-only array scale_us static const

Posted by Colin Ian King 1 month, 2 weeks ago

Don't populate the read-only array scale_us on the stack at run time,
instead make it static const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/ufs/host/ufs-mediatek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index ecbbf52bf734..66b11cc0703b 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -1112,7 +1112,7 @@ static void ufs_mtk_setup_clk_gating(struct ufs_hba *hba)
 	unsigned long flags;
 	u32 ah_ms = 10;
 	u32 ah_scale, ah_timer;
-	u32 scale_us[] = {1, 10, 100, 1000, 10000, 100000};
+	static const u32 scale_us[] = {1, 10, 100, 1000, 10000, 100000};
 
 	if (ufshcd_is_clkgating_allowed(hba)) {
 		if (ufshcd_is_auto_hibern8_supported(hba) && hba->ahit) {
-- 
2.51.0

Re: [PATCH][next] scsi: ufs: host: mediatek: make read-only array scale_us static const

Posted by Peter Wang (王信友) 1 month, 2 weeks ago

On Fri, 2025-12-19 at 21:44 +0000, Colin Ian King wrote:
> Don't populate the read-only array scale_us on the stack at run time,
> instead make it static const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/ufs/host/ufs-mediatek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-
> mediatek.c
> index ecbbf52bf734..66b11cc0703b 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -1112,7 +1112,7 @@ static void ufs_mtk_setup_clk_gating(struct
> ufs_hba *hba)
>         unsigned long flags;
>         u32 ah_ms = 10;
>         u32 ah_scale, ah_timer;
> -       u32 scale_us[] = {1, 10, 100, 1000, 10000, 100000};
> +       static const u32 scale_us[] = {1, 10, 100, 1000, 10000,
> 100000};
> 

Reviewed-by: Peter Wang <peter.wang@mediatek.com>

Re: [PATCH][next] scsi: ufs: host: mediatek: make read-only array scale_us static const

Posted by Martin K. Petersen 1 month ago

On Fri, 19 Dec 2025 21:44:28 +0000, Colin Ian King wrote:

> Don't populate the read-only array scale_us on the stack at run time,
> instead make it static const.
> 
> 

Applied to 6.19/scsi-fixes, thanks!

[1/1] scsi: ufs: host: mediatek: make read-only array scale_us static const
      https://git.kernel.org/mkp/scsi/c/309a29b5965a

-- 
Martin K. Petersen