crypto: hisilicon/sgl - fix inconsistent map/unmap direction issue

[PATCH] crypto: hisilicon/sgl - fix inconsistent map/unmap direction issue

Posted by Chenghai Huang 1 month, 2 weeks ago

Ensure that the direction for dma_map_sg and dma_unmap_sg is
consistent.

Fixes: 2566de3e06a3 ("crypto: hisilicon - Use fine grained DMA mapping direction")
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
---
 drivers/crypto/hisilicon/sgl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c
index 24c7b6ab285b..d41b34405c21 100644
--- a/drivers/crypto/hisilicon/sgl.c
+++ b/drivers/crypto/hisilicon/sgl.c
@@ -260,7 +260,7 @@ hisi_acc_sg_buf_map_to_hw_sgl(struct device *dev, struct scatterlist *sgl,
 	return curr_hw_sgl;
 
 err_unmap:
-	dma_unmap_sg(dev, sgl, sg_n, DMA_BIDIRECTIONAL);
+	dma_unmap_sg(dev, sgl, sg_n, dir);
 
 	return ERR_PTR(ret);
 }
-- 
2.33.0

Re: [PATCH] crypto: hisilicon/sgl - fix inconsistent map/unmap direction issue

Posted by Herbert Xu 3 weeks, 1 day ago

On Fri, Dec 19, 2025 at 11:36:19AM +0800, Chenghai Huang wrote:
> Ensure that the direction for dma_map_sg and dma_unmap_sg is
> consistent.
> 
> Fixes: 2566de3e06a3 ("crypto: hisilicon - Use fine grained DMA mapping direction")
> Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
> ---
>  drivers/crypto/hisilicon/sgl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/sgl - fix inconsistent map/unmap direction issue

Posted by Zenghui Yu 1 month, 2 weeks ago

On 2025/12/19 11:36, Chenghai Huang wrote:
> Ensure that the direction for dma_map_sg and dma_unmap_sg is
> consistent.
> 
> Fixes: 2566de3e06a3 ("crypto: hisilicon - Use fine grained DMA mapping direction")
> Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
> ---
>  drivers/crypto/hisilicon/sgl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c
> index 24c7b6ab285b..d41b34405c21 100644
> --- a/drivers/crypto/hisilicon/sgl.c
> +++ b/drivers/crypto/hisilicon/sgl.c
> @@ -260,7 +260,7 @@ hisi_acc_sg_buf_map_to_hw_sgl(struct device *dev, struct scatterlist *sgl,
>  	return curr_hw_sgl;
>  
>  err_unmap:
> -	dma_unmap_sg(dev, sgl, sg_n, DMA_BIDIRECTIONAL);
> +	dma_unmap_sg(dev, sgl, sg_n, dir);
>  
>  	return ERR_PTR(ret);
>  }

Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>

Thanks for fixing it!

Zenghui