[PATCH v3 5/5] ARM: dts: aspeed: yosemite5: Correct power monitor shunt resistor

Kevin Tung posted 5 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH v3 5/5] ARM: dts: aspeed: yosemite5: Correct power monitor shunt resistor
Posted by Kevin Tung 1 month, 3 weeks ago
Correct the shunt resistor value in the DTS with the hardware setting
to ensure accurate power and current measurements.

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 84d3731b17f7c7c87338672bbcc859de2b89b722..524597a81365ef10cd03b67d35eeb88a965cbe0a 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -415,7 +415,7 @@ power-sensor@42 {
 	power-monitor@43 {
 		compatible = "lltc,ltc4287";
 		reg = <0x43>;
-		shunt-resistor-micro-ohms = <250>;
+		shunt-resistor-micro-ohms = <100>;
 	};
 
 	power-sensor@44 {
@@ -461,25 +461,25 @@ eeprom@57 {
 	power-monitor@58 {
 		compatible = "renesas,isl28022";
 		reg = <0x58>;
-		shunt-resistor-micro-ohms = <1000>;
+		shunt-resistor-micro-ohms = <10000>;
 	};
 
 	power-monitor@59 {
 		compatible = "renesas,isl28022";
 		reg = <0x59>;
-		shunt-resistor-micro-ohms = <1000>;
+		shunt-resistor-micro-ohms = <10000>;
 	};
 
 	power-monitor@5a {
 		compatible = "renesas,isl28022";
 		reg = <0x5a>;
-		shunt-resistor-micro-ohms = <1000>;
+		shunt-resistor-micro-ohms = <10000>;
 	};
 
 	power-monitor@5b {
 		compatible = "renesas,isl28022";
 		reg = <0x5b>;
-		shunt-resistor-micro-ohms = <1000>;
+		shunt-resistor-micro-ohms = <10000>;
 	};
 
 	psu@5c {
@@ -723,13 +723,13 @@ gpio-expander@21 {
 	power-sensor@40 {
 		compatible = "ti,ina230";
 		reg = <0x40>;
-		shunt-resistor = <2000>;
+		shunt-resistor = <1000>;
 	};
 
 	power-sensor@41 {
 		compatible = "ti,ina230";
 		reg = <0x41>;
-		shunt-resistor = <2000>;
+		shunt-resistor = <1000>;
 	};
 
 	power-sensor@42 {

-- 
2.52.0
Re: [PATCH v3 5/5] ARM: dts: aspeed: yosemite5: Correct power monitor shunt resistor
Posted by Andrew Jeffery 1 month ago
Hi Kevin,

On Fri, 2025-12-19 at 16:09 +0800, Kevin Tung wrote:
> Correct the shunt resistor value in the DTS with the hardware setting
> to ensure accurate power and current measurements.

Why were the existing values wrong? Why are the new values correct? Can
you please add more information here explaining both concerns?

Andrew
Re: [PATCH v3 5/5] ARM: dts: aspeed: yosemite5: Correct power monitor shunt resistor
Posted by Kevin Tung 1 week, 3 days ago
On Thu, Jan 8, 2026 at 1:22 PM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> Hi Kevin,
>
> On Fri, 2025-12-19 at 16:09 +0800, Kevin Tung wrote:
> > Correct the shunt resistor value in the DTS with the hardware setting
> > to ensure accurate power and current measurements.
>
> Why were the existing values wrong? Why are the new values correct? Can
> you please add more information here explaining both concerns?
>
> Andrew

Hi Andrew,

Sorry for the late reply. I’ve sent v4 with additional details to
explain the patch better. Thanks.

Kevin