[PATCH 1/2] hwmon: Fix wrong return errno in *sanitize_name()

Kari Argillander posted 2 patches 1 month, 3 weeks ago
[PATCH 1/2] hwmon: Fix wrong return errno in *sanitize_name()
Posted by Kari Argillander 1 month, 3 weeks ago
Currently if user of *sanitize_name() function gives nullptr for name
they get's ENOMEM. Logically it should be EINVAL.

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
---
 drivers/hwmon/hwmon.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index 0b4bdcd33c7b..7a784d685d77 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -1260,6 +1260,9 @@ static char *__hwmon_sanitize_name(struct device *dev, const char *old_name)
  */
 char *hwmon_sanitize_name(const char *name)
 {
+	if (!name)
+		return ERR_PTR(-EINVAL);
+
 	return __hwmon_sanitize_name(NULL, name);
 }
 EXPORT_SYMBOL_GPL(hwmon_sanitize_name);
@@ -1276,7 +1279,7 @@ EXPORT_SYMBOL_GPL(hwmon_sanitize_name);
  */
 char *devm_hwmon_sanitize_name(struct device *dev, const char *name)
 {
-	if (!dev)
+	if (!dev || !name)
 		return ERR_PTR(-EINVAL);
 
 	return __hwmon_sanitize_name(dev, name);

-- 
2.43.0
Re: [PATCH 1/2] hwmon: Fix wrong return errno in *sanitize_name()
Posted by Guenter Roeck 1 month, 3 weeks ago
On Fri, Dec 19, 2025 at 05:48:14PM +0200, Kari Argillander wrote:
> Currently if user of *sanitize_name() function gives nullptr for name
> they get's ENOMEM. Logically it should be EINVAL.
> 
> Signed-off-by: Kari Argillander <kari.argillander@gmail.com>

Applied.

Thanks,
Guenter