Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q)
compatibles.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Tested-by: Tan Siewert <tan.siewert@hetzner.com>
Reviewed-by: Tan Siewert <tan.siewert@hetzner.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 9298c1a75dd1..aefad2d02993 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -34,6 +34,7 @@ properties:
               - amd,ethanolx-bmc
               - ampere,mtjade-bmc
               - aspeed,ast2500-evb
+              - asrock,altrad8-bmc
               - asrock,e3c246d4i-bmc
               - asrock,e3c256d4i-bmc
               - asrock,romed8hm3-bmc
-- 
2.47.3

On 18/12/2025 17:18, Rebecca Cran wrote:
> Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q)
> compatibles.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Tested-by: Tan Siewert <tan.siewert@hetzner.com>

How was the binding tested?


Best regards,
Krzysztof

On 12/18/25 09:21, Krzysztof Kozlowski wrote:
> On 18/12/2025 17:18, Rebecca Cran wrote:
>> Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q)
>> compatibles.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>> Tested-by: Tan Siewert <tan.siewert@hetzner.com>
> How was the binding tested?

I ran "make ARCH=arm CHECK_DTBS=y aspeed/aspeed-bmc-asrock-altrad8.dtb"
to check for errors

and have used the dts file in an ASRock Rack ALTRAD8UD-1L2T system with
Linux 6.12.61 running OpenBMC.


-- 
Rebecca Cran

On 18/12/2025 19:34, Rebecca Cran wrote:
> On 12/18/25 09:21, Krzysztof Kozlowski wrote:
>> On 18/12/2025 17:18, Rebecca Cran wrote:
>>> Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q)
>>> compatibles.
>>>
>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Tested-by: Tan Siewert <tan.siewert@hetzner.com>
>> How was the binding tested?
> 
> I ran "make ARCH=arm CHECK_DTBS=y aspeed/aspeed-bmc-asrock-altrad8.dtb"
> to check for errors

That's a build check for DTS, not binding. I compiled this code - so it
is also Tested-by?

> 
> and have used the dts file in an ASRock Rack ALTRAD8UD-1L2T system with
> Linux 6.12.61 running OpenBMC.

This does not test anything from the binding.

Please don't add fake tests... Building instructions are not testing.

Best regards,
Krzysztof

On 12/18/25 12:31, Krzysztof Kozlowski wrote:
> This does not test anything from the binding.
>
> Please don't add fake tests... Building instructions are not testing.

Sorry. In that case I don't know how to test the bindings.


-- 
Rebecca Cran

On 18.12.25 17:21, Krzysztof Kozlowski wrote:
> On 18/12/2025 17:18, Rebecca Cran wrote:
>> Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q)
>> compatibles.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>> Tested-by: Tan Siewert <tan.siewert@hetzner.com>
> 
> How was the binding tested?

My bad for sending the wrong trailing header in v4. Tested-by should've 
been only on the dts instead of the dt-bindings+dts. Either way, `make 
dt_binding_check` was what I did to check if there are any errors 
produced for `asrock,altrad8-bmc`.

-- Tan

> 
> 
> Best regards,
> Krzysztof
>

On 18/12/2025 17:44, Tan Siewert wrote:
> On 18.12.25 17:21, Krzysztof Kozlowski wrote:
>> On 18/12/2025 17:18, Rebecca Cran wrote:
>>> Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q)
>>> compatibles.
>>>
>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Tested-by: Tan Siewert <tan.siewert@hetzner.com>
>>
>> How was the binding tested?
> 
> My bad for sending the wrong trailing header in v4. Tested-by should've 
> been only on the dts instead of the dt-bindings+dts. Either way, `make 
> dt_binding_check` was what I did to check if there are any errors 
> produced for `asrock,altrad8-bmc`.

Yeah, that's not testing. It's a build command and running build process
is not a test. Otherwise why there is no Tested-by for Rob...

Best regards,
Krzysztof