arch/arm/boot/dts/xilinx/zynq-7000.dtsi | 72 +++++++++++-------- arch/arm/boot/dts/xilinx/zynq-cc108.dts | 11 ++- arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 1 + arch/arm/boot/dts/xilinx/zynq-parallella.dts | 7 +- arch/arm/boot/dts/xilinx/zynq-zc702.dts | 17 +++++ arch/arm/boot/dts/xilinx/zynq-zc706.dts | 13 ++++ arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts | 10 +++ arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts | 5 ++ arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts | 6 ++ arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts | 8 +++ arch/arm/boot/dts/xilinx/zynq-zed.dts | 7 ++ .../boot/dts/xilinx/zynq-zturn-common.dtsi | 5 +- 12 files changed, 126 insertions(+), 36 deletions(-)
From: Kyle Bonnici <kylebonnici@hotmail.com>
- Convert hex value to lowercase
- align property values to ' = '
- clean up whitespaces
- fix indentation
- add new line between nodes
The changes are generated using the dts-linter.
This is just a sample of what the above tool can fix and this change is
intended to start the conversation on how I should suggest fixes to this repo
Without sending one big PR.
Also, this is my first attempt at such a submission. Hopefully I did not miss
Anything fundamental in the submission process.
Signed-off-by: Kyle Bonnici <kylebonnici@proton.me>
---
arch/arm/boot/dts/xilinx/zynq-7000.dtsi | 72 +++++++++++--------
arch/arm/boot/dts/xilinx/zynq-cc108.dts | 11 ++-
arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 1 +
arch/arm/boot/dts/xilinx/zynq-parallella.dts | 7 +-
arch/arm/boot/dts/xilinx/zynq-zc702.dts | 17 +++++
arch/arm/boot/dts/xilinx/zynq-zc706.dts | 13 ++++
arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts | 10 +++
arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts | 5 ++
arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts | 6 ++
arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts | 8 +++
arch/arm/boot/dts/xilinx/zynq-zed.dts | 7 ++
.../boot/dts/xilinx/zynq-zturn-common.dtsi | 5 +-
12 files changed, 126 insertions(+), 36 deletions(-)
diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
index 153b8d93cbee..dd8a6528e8a7 100644
--- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
@@ -27,10 +27,9 @@ cpu0: cpu@0 {
clock-latency = <1000>;
cpu0-supply = <®ulator_vccpint>;
operating-points = <
- /* kHz uV */
- 666667 1000000
- 333334 1000000
- >;
+ /* kHz uV */
+ 666667 1000000
+ 333334 1000000>;
};
cpu1: cpu@1 {
@@ -78,17 +77,21 @@ out-ports {
/* replicator output ports */
port@0 {
reg = <0>;
+
replicator_out_port0: endpoint {
remote-endpoint = <&tpiu_in_port>;
};
};
+
port@1 {
reg = <1>;
+
replicator_out_port1: endpoint {
remote-endpoint = <&etb_in_port>;
};
};
};
+
in-ports {
/* replicator input port */
port {
@@ -179,13 +182,13 @@ intc: interrupt-controller@f8f01000 {
compatible = "arm,cortex-a9-gic";
#interrupt-cells = <3>;
interrupt-controller;
- reg = <0xF8F01000 0x1000>,
- <0xF8F00100 0x100>;
+ reg = <0xf8f01000 0x1000>,
+ <0xf8f00100 0x100>;
};
L2: cache-controller@f8f02000 {
compatible = "arm,pl310-cache";
- reg = <0xF8F02000 0x1000>;
+ reg = <0xf8f02000 0x1000>;
interrupts = <0 2 4>;
arm,data-latency = <3 2 2>;
arm,tag-latency = <2 2 2>;
@@ -204,6 +207,7 @@ ocm: sram@fffc0000 {
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0xfffc0000 0x10000>;
+
ocm-sram@0 {
reg = <0x0 0x10000>;
};
@@ -214,7 +218,7 @@ uart0: serial@e0000000 {
status = "disabled";
clocks = <&clkc 23>, <&clkc 40>;
clock-names = "uart_clk", "pclk";
- reg = <0xE0000000 0x1000>;
+ reg = <0xe0000000 0x1000>;
interrupts = <0 27 4>;
};
@@ -223,7 +227,7 @@ uart1: serial@e0001000 {
status = "disabled";
clocks = <&clkc 24>, <&clkc 41>;
clock-names = "uart_clk", "pclk";
- reg = <0xE0001000 0x1000>;
+ reg = <0xe0001000 0x1000>;
interrupts = <0 50 4>;
};
@@ -304,6 +308,7 @@ nfc0: nand-controller@0,0 {
reg = <0 0 0x1000000>;
status = "disabled";
};
+
nor0: flash@1,0 {
status = "disabled";
compatible = "cfi-flash";
@@ -336,24 +341,26 @@ slcr: slcr@f8000000 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "xlnx,zynq-slcr", "syscon", "simple-mfd";
- reg = <0xF8000000 0x1000>;
+ reg = <0xf8000000 0x1000>;
ranges;
+
clkc: clkc@100 {
bootph-all;
#clock-cells = <1>;
compatible = "xlnx,ps7-clkc";
fclk-enable = <0>;
clock-output-names = "armpll", "ddrpll", "iopll", "cpu_6or4x",
- "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x", "ddr3x",
- "dci", "lqspi", "smc", "pcap", "gem0", "gem1",
- "fclk0", "fclk1", "fclk2", "fclk3", "can0", "can1",
- "sdio0", "sdio1", "uart0", "uart1", "spi0", "spi1",
- "dma", "usb0_aper", "usb1_aper", "gem0_aper",
- "gem1_aper", "sdio0_aper", "sdio1_aper",
- "spi0_aper", "spi1_aper", "can0_aper", "can1_aper",
- "i2c0_aper", "i2c1_aper", "uart0_aper", "uart1_aper",
- "gpio_aper", "lqspi_aper", "smc_aper", "swdt",
- "dbg_trc", "dbg_apb";
+ "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x",
+ "ddr3x", "dci", "lqspi", "smc", "pcap", "gem0",
+ "gem1", "fclk0", "fclk1", "fclk2", "fclk3",
+ "can0", "can1", "sdio0", "sdio1", "uart0",
+ "uart1", "spi0", "spi1", "dma", "usb0_aper",
+ "usb1_aper", "gem0_aper", "gem1_aper",
+ "sdio0_aper", "sdio1_aper", "spi0_aper",
+ "spi1_aper", "can0_aper", "can1_aper",
+ "i2c0_aper", "i2c1_aper", "uart0_aper",
+ "uart1_aper", "gpio_aper", "lqspi_aper",
+ "smc_aper", "swdt", "dbg_trc", "dbg_apb";
reg = <0x100 0x100>;
};
@@ -380,10 +387,10 @@ dmac_s: dma-controller@f8003000 {
* "dma4", "dma5", "dma6", "dma7";
*/
interrupts = <0 13 4>,
- <0 14 4>, <0 15 4>,
- <0 16 4>, <0 17 4>,
- <0 40 4>, <0 41 4>,
- <0 42 4>, <0 43 4>;
+ <0 14 4>, <0 15 4>,
+ <0 16 4>, <0 17 4>,
+ <0 40 4>, <0 41 4>,
+ <0 42 4>, <0 43 4>;
#dma-cells = <1>;
clocks = <&clkc 27>;
clock-names = "apb_pclk";
@@ -412,7 +419,7 @@ ttc0: timer@f8001000 {
interrupts = <0 10 4>, <0 11 4>, <0 12 4>;
compatible = "cdns,ttc";
clocks = <&clkc 6>;
- reg = <0xF8001000 0x1000>;
+ reg = <0xf8001000 0x1000>;
};
ttc1: timer@f8002000 {
@@ -420,7 +427,7 @@ ttc1: timer@f8002000 {
interrupts = <0 37 4>, <0 38 4>, <0 39 4>;
compatible = "cdns,ttc";
clocks = <&clkc 6>;
- reg = <0xF8002000 0x1000>;
+ reg = <0xf8002000 0x1000>;
};
scutimer: timer@f8f00600 {
@@ -466,6 +473,7 @@ etb@f8801000 {
reg = <0xf8801000 0x1000>;
clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
+
in-ports {
port {
etb_in_port: endpoint {
@@ -480,6 +488,7 @@ tpiu@f8803000 {
reg = <0xf8803000 0x1000>;
clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
+
in-ports {
port {
tpiu_in_port: endpoint {
@@ -499,8 +508,7 @@ funnel@f8804000 {
out-ports {
port {
funnel_out_port: endpoint {
- remote-endpoint =
- <&replicator_in_port0>;
+ remote-endpoint = <&replicator_in_port0>;
};
};
};
@@ -512,6 +520,7 @@ in-ports {
/* funnel input ports */
port@0 {
reg = <0>;
+
funnel0_in_port0: endpoint {
remote-endpoint = <&ptm0_out_port>;
};
@@ -519,6 +528,7 @@ funnel0_in_port0: endpoint {
port@1 {
reg = <1>;
+
funnel0_in_port1: endpoint {
remote-endpoint = <&ptm1_out_port>;
};
@@ -526,8 +536,8 @@ funnel0_in_port1: endpoint {
port@2 {
reg = <2>;
- funnel0_in_port2: endpoint {
- };
+
+ funnel0_in_port2: endpoint {};
};
/* The other input ports are not connect to anything */
};
@@ -539,6 +549,7 @@ ptm@f889c000 {
clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
cpu = <&cpu0>;
+
out-ports {
port {
ptm0_out_port: endpoint {
@@ -554,6 +565,7 @@ ptm@f889d000 {
clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
cpu = <&cpu1>;
+
out-ports {
port {
ptm1_out_port: endpoint {
diff --git a/arch/arm/boot/dts/xilinx/zynq-cc108.dts b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
index f5525c048426..25828ba9fa16 100644
--- a/arch/arm/boot/dts/xilinx/zynq-cc108.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
@@ -55,6 +55,7 @@ ethernet_phy: ethernet-phy@1 {
&qspi {
status = "okay";
num-cs = <1>;
+
flash@0 { /* 16 MB */
compatible = "jedec,spi-nor";
reg = <0x0>;
@@ -63,26 +64,32 @@ flash@0 { /* 16 MB */
spi-rx-bus-width = <4>;
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "qspi-fsbl-uboot-bs";
reg = <0x0 0x400000>; /* 4MB */
};
+
partition@400000 {
label = "qspi-linux";
reg = <0x400000 0x400000>; /* 4MB */
};
+
partition@800000 {
label = "qspi-rootfs";
reg = <0x800000 0x400000>; /* 4MB */
};
+
partition@c00000 {
label = "qspi-devicetree";
reg = <0xc00000 0x100000>; /* 1MB */
};
+
partition@d00000 {
label = "qspi-scratch";
reg = <0xd00000 0x200000>; /* 2MB */
};
+
partition@f00000 {
label = "qspi-uboot-env";
reg = <0xf00000 0x100000>; /* 1MB */
@@ -92,8 +99,8 @@ partition@f00000 {
&sdhci1 {
status = "okay";
- broken-cd ;
- wp-inverted ;
+ broken-cd;
+ wp-inverted;
};
&uart0 {
diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
index 14f644156a6f..d4c07d28ec25 100644
--- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
@@ -53,6 +53,7 @@ &nfc0 {
#address-cells = <1>;
#size-cells = <0>;
+
nand@0 {
reg = <0>;
};
diff --git a/arch/arm/boot/dts/xilinx/zynq-parallella.dts b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
index 366af4fcf8d9..e498feaa7ca4 100644
--- a/arch/arm/boot/dts/xilinx/zynq-parallella.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
@@ -44,10 +44,10 @@ &gem0 {
ethernet_phy: ethernet-phy@0 {
/* Marvell 88E1318 */
compatible = "ethernet-phy-id0141.0e90",
- "ethernet-phy-ieee802.3-c22";
+ "ethernet-phy-ieee802.3-c22";
reg = <0>;
marvell,reg-init = <0x3 0x10 0xff00 0x1e>,
- <0x3 0x11 0xfff0 0xa>;
+ <0x3 0x11 0xfff0 0xa>;
};
};
@@ -63,13 +63,16 @@ dcd1 {
regulator-name = "VDD_DSP";
regulator-always-on;
};
+
dcd2 {
regulator-name = "1P35V";
regulator-always-on;
};
+
ldo1 {
regulator-name = "VDD_ADJ";
};
+
ldo2 {
regulator-name = "VDD_GPIO";
regulator-always-on;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zc702.dts b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
index 6955637c5b1a..63eded827b37 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zc702.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
@@ -34,6 +34,7 @@ chosen {
gpio-keys {
compatible = "gpio-keys";
autorepeat;
+
switch-14 {
label = "sw14";
gpios = <&gpio0 12 0>;
@@ -41,6 +42,7 @@ switch-14 {
wakeup-source;
autorepeat;
};
+
switch-13 {
label = "sw13";
gpios = <&gpio0 14 0>;
@@ -112,6 +114,7 @@ i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0>;
+
si570: clock-generator@5d {
#clock-cells = <0>;
compatible = "silabs,si570";
@@ -126,6 +129,7 @@ i2c@1 {
#address-cells = <1>;
#size-cells = <0>;
reg = <1>;
+
adv7511: hdmi-tx@39 {
compatible = "adi,adv7511";
reg = <0x39>;
@@ -141,6 +145,7 @@ i2c@2 {
#address-cells = <1>;
#size-cells = <0>;
reg = <2>;
+
eeprom: eeprom@54 {
compatible = "atmel,24c08";
reg = <0x54>;
@@ -151,6 +156,7 @@ i2c@3 {
#address-cells = <1>;
#size-cells = <0>;
reg = <3>;
+
gpio@21 {
compatible = "ti,tca6416";
reg = <0x21>;
@@ -163,6 +169,7 @@ i2c@4 {
#address-cells = <1>;
#size-cells = <0>;
reg = <4>;
+
rtc: rtc@51 {
compatible = "nxp,pcf8563";
reg = <0x51>;
@@ -173,14 +180,17 @@ i2c@7 {
#address-cells = <1>;
#size-cells = <0>;
reg = <7>;
+
hwmon@34 {
compatible = "ti,ucd9248";
reg = <0x34>;
};
+
hwmon@35 {
compatible = "ti,ucd9248";
reg = <0x35>;
};
+
hwmon@36 {
compatible = "ti,ucd9248";
reg = <0x36>;
@@ -396,32 +406,39 @@ &qspi {
bootph-all;
status = "okay";
num-cs = <1>;
+
flash@0 {
compatible = "jedec,spi-nor";
reg = <0x0>;
spi-tx-bus-width = <1>;
spi-rx-bus-width = <4>;
spi-max-frequency = <50000000>;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "qspi-fsbl-uboot";
reg = <0x0 0x100000>;
};
+
partition@100000 {
label = "qspi-linux";
reg = <0x100000 0x500000>;
};
+
partition@600000 {
label = "qspi-device-tree";
reg = <0x600000 0x20000>;
};
+
partition@620000 {
label = "qspi-rootfs";
reg = <0x620000 0x5e0000>;
};
+
partition@c00000 {
label = "qspi-bitstream";
reg = <0xc00000 0x400000>;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zc706.dts b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
index 3b803c698473..d6447e544d8f 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zc706.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
@@ -73,6 +73,7 @@ i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0>;
+
si570: clock-generator@5d {
#clock-cells = <0>;
compatible = "silabs,si570";
@@ -87,6 +88,7 @@ i2c@1 {
#address-cells = <1>;
#size-cells = <0>;
reg = <1>;
+
adv7511: hdmi-tx@39 {
compatible = "adi,adv7511";
reg = <0x39>;
@@ -102,6 +104,7 @@ i2c@2 {
#address-cells = <1>;
#size-cells = <0>;
reg = <2>;
+
eeprom: eeprom@54 {
compatible = "atmel,24c08";
reg = <0x54>;
@@ -112,6 +115,7 @@ i2c@3 {
#address-cells = <1>;
#size-cells = <0>;
reg = <3>;
+
gpio@21 {
compatible = "ti,tca6416";
reg = <0x21>;
@@ -124,6 +128,7 @@ i2c@4 {
#address-cells = <1>;
#size-cells = <0>;
reg = <4>;
+
rtc: rtc@51 {
compatible = "nxp,pcf8563";
reg = <0x51>;
@@ -134,6 +139,7 @@ i2c@7 {
#address-cells = <1>;
#size-cells = <0>;
reg = <7>;
+
ucd90120@65 {
compatible = "ti,ucd90120";
reg = <0x65>;
@@ -309,6 +315,7 @@ &qspi {
bootph-all;
status = "okay";
num-cs = <2>;
+
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>, <1>;
@@ -316,26 +323,32 @@ flash@0 {
spi-tx-bus-width = <1>;
spi-rx-bus-width = <4>;
spi-max-frequency = <50000000>;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "qspi-fsbl-uboot";
reg = <0x0 0x100000>;
};
+
partition@100000 {
label = "qspi-linux";
reg = <0x100000 0x500000>;
};
+
partition@600000 {
label = "qspi-device-tree";
reg = <0x600000 0x20000>;
};
+
partition@620000 {
label = "qspi-rootfs";
reg = <0x620000 0x5e0000>;
};
+
partition@c00000 {
label = "qspi-bitstream";
reg = <0xc00000 0x400000>;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
index 5fe799c3c7cf..4929a5aa1678 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
@@ -62,32 +62,39 @@ eeprom: eeprom@52 {
&qspi {
status = "okay";
num-cs = <1>;
+
flash@0 {
compatible = "jedec,spi-nor";
reg = <0x0>;
spi-tx-bus-width = <1>;
spi-rx-bus-width = <4>;
spi-max-frequency = <50000000>;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "qspi-fsbl-uboot";
reg = <0x0 0x100000>;
};
+
partition@100000 {
label = "qspi-linux";
reg = <0x100000 0x500000>;
};
+
partition@600000 {
label = "qspi-device-tree";
reg = <0x600000 0x20000>;
};
+
partition@620000 {
label = "qspi-rootfs";
reg = <0x620000 0x5e0000>;
};
+
partition@c00000 {
label = "qspi-bitstream";
reg = <0xc00000 0x400000>;
@@ -104,14 +111,17 @@ &spi1 {
status = "okay";
num-cs = <4>;
is-decoded-cs = <0>;
+
flash@1 {
compatible = "sst25wf080", "jedec,spi-nor";
reg = <1>;
spi-max-frequency = <1000000>;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "data";
reg = <0x0 0x100000>;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
index f9a086fe66d3..d4e739772d7b 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
@@ -51,20 +51,25 @@ &nfc0 {
status = "okay";
#address-cells = <1>;
#size-cells = <0>;
+
nand@0 {
reg = <0>;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "nand-fsbl-uboot";
reg = <0x0 0x1000000>;
};
+
partition@1000000 {
label = "nand-linux";
reg = <0x1000000 0x2000000>;
};
+
partition@3000000 {
label = "nand-rootfs";
reg = <0x3000000 0x200000>;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
index 24520e7d3965..32422aed77a3 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
@@ -56,26 +56,32 @@ eeprom1: eeprom@52 {
&nor0 {
status = "okay";
bank-width = <1>;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "nor-fsbl-uboot";
reg = <0x0 0x100000>;
};
+
partition@100000 {
label = "nor-linux";
reg = <0x100000 0x500000>;
};
+
partition@600000 {
label = "nor-device-tree";
reg = <0x600000 0x20000>;
};
+
partition@620000 {
label = "nor-rootfs";
reg = <0x620000 0x5e0000>;
};
+
partition@c00000 {
label = "nor-bitstream";
reg = <0xc00000 0x400000>;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
index 103e87ea7253..9c94421bf650 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
@@ -61,6 +61,7 @@ si570: clock-generator@55 {
&qspi {
status = "okay";
num-cs = <2>;
+
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>, <1>;
@@ -68,26 +69,32 @@ flash@0 {
spi-tx-bus-width = <1>;
spi-rx-bus-width = <4>;
spi-max-frequency = <50000000>;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "qspi-fsbl-uboot";
reg = <0x0 0x100000>;
};
+
partition@100000 {
label = "qspi-linux";
reg = <0x100000 0x500000>;
};
+
partition@600000 {
label = "qspi-device-tree";
reg = <0x600000 0x20000>;
};
+
partition@620000 {
label = "qspi-rootfs";
reg = <0x620000 0x5e0000>;
};
+
partition@c00000 {
label = "qspi-bitstream";
reg = <0xc00000 0x400000>;
@@ -100,6 +107,7 @@ &spi0 {
status = "okay";
num-cs = <4>;
is-decoded-cs = <0>;
+
eeprom: eeprom@2 {
compatible = "atmel,at25";
reg = <2>;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zed.dts b/arch/arm/boot/dts/xilinx/zynq-zed.dts
index 52ba569b2b9f..dd46d71e3f36 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zed.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-zed.dts
@@ -51,6 +51,7 @@ &qspi {
bootph-all;
status = "okay";
num-cs = <1>;
+
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
@@ -58,26 +59,32 @@ flash@0 {
spi-rx-bus-width = <4>;
spi-max-frequency = <50000000>;
m25p,fast-read;
+
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
+
partition@0 {
label = "qspi-fsbl-uboot";
reg = <0x0 0x100000>;
};
+
partition@100000 {
label = "qspi-linux";
reg = <0x100000 0x500000>;
};
+
partition@600000 {
label = "qspi-device-tree";
reg = <0x600000 0x20000>;
};
+
partition@620000 {
label = "qspi-rootfs";
reg = <0x620000 0x5e0000>;
};
+
partition@c00000 {
label = "qspi-bitstream";
reg = <0xc00000 0x400000>;
diff --git a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
index defef9c8da13..57e6cda1a798 100644
--- a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
+++ b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
@@ -33,6 +33,7 @@ chosen {
gpio-leds {
compatible = "gpio-leds";
+
usr-led1 {
label = "usr-led1";
gpios = <&gpio0 0x0 0x1>;
@@ -49,6 +50,7 @@ usr-led2 {
gpio-keys {
compatible = "gpio-keys";
autorepeat;
+
key {
label = "K1";
gpios = <&gpio0 0x32 0x1>;
@@ -73,8 +75,7 @@ &gem0 {
phy-mode = "rgmii-id";
phy-handle = <ðernet_phy>;
- ethernet_phy: ethernet-phy@0 {
- };
+ ethernet_phy: ethernet-phy@0 {};
};
&sdhci0 {
--
2.50.1 (Apple Git-155)Hi,
On 12/18/25 13:51, kylebonnici wrote:
> From: Kyle Bonnici <kylebonnici@hotmail.com>
>
> - Convert hex value to lowercase
> - align property values to ' = '
> - clean up whitespaces
> - fix indentation
> - add new line between nodes
>
> The changes are generated using the dts-linter.
>
> This is just a sample of what the above tool can fix and this change is
> intended to start the conversation on how I should suggest fixes to this repo
> Without sending one big PR.
>
> Also, this is my first attempt at such a submission. Hopefully I did not miss
> Anything fundamental in the submission process.
my issue is with subject. Where Coding Style: subsystem is not defined.
I tried your tool locally and I think handling in connection to long line should
be improved.
But in general I don't have a problem to use any tool to do coding style
formatting.
Newlines I don't really mind but lower case, additional spaces, tabs/spaces are
nicely visible.
I think you should get ack from Rob, Krzysztof and Conor to run it in bigger scale.
Thanks,
Michal
>
> Signed-off-by: Kyle Bonnici <kylebonnici@proton.me>
> ---
> arch/arm/boot/dts/xilinx/zynq-7000.dtsi | 72 +++++++++++--------
> arch/arm/boot/dts/xilinx/zynq-cc108.dts | 11 ++-
> arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 1 +
> arch/arm/boot/dts/xilinx/zynq-parallella.dts | 7 +-
> arch/arm/boot/dts/xilinx/zynq-zc702.dts | 17 +++++
> arch/arm/boot/dts/xilinx/zynq-zc706.dts | 13 ++++
> arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts | 10 +++
> arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts | 5 ++
> arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts | 6 ++
> arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts | 8 +++
> arch/arm/boot/dts/xilinx/zynq-zed.dts | 7 ++
> .../boot/dts/xilinx/zynq-zturn-common.dtsi | 5 +-
> 12 files changed, 126 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> index 153b8d93cbee..dd8a6528e8a7 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> @@ -27,10 +27,9 @@ cpu0: cpu@0 {
> clock-latency = <1000>;
> cpu0-supply = <®ulator_vccpint>;
> operating-points = <
> - /* kHz uV */
> - 666667 1000000
> - 333334 1000000
> - >;
> + /* kHz uV */
> + 666667 1000000
> + 333334 1000000>;
> };
>
> cpu1: cpu@1 {
> @@ -78,17 +77,21 @@ out-ports {
> /* replicator output ports */
> port@0 {
> reg = <0>;
> +
> replicator_out_port0: endpoint {
> remote-endpoint = <&tpiu_in_port>;
> };
> };
> +
> port@1 {
> reg = <1>;
> +
> replicator_out_port1: endpoint {
> remote-endpoint = <&etb_in_port>;
> };
> };
> };
> +
> in-ports {
> /* replicator input port */
> port {
> @@ -179,13 +182,13 @@ intc: interrupt-controller@f8f01000 {
> compatible = "arm,cortex-a9-gic";
> #interrupt-cells = <3>;
> interrupt-controller;
> - reg = <0xF8F01000 0x1000>,
> - <0xF8F00100 0x100>;
> + reg = <0xf8f01000 0x1000>,
> + <0xf8f00100 0x100>;
> };
>
> L2: cache-controller@f8f02000 {
> compatible = "arm,pl310-cache";
> - reg = <0xF8F02000 0x1000>;
> + reg = <0xf8f02000 0x1000>;
> interrupts = <0 2 4>;
> arm,data-latency = <3 2 2>;
> arm,tag-latency = <2 2 2>;
> @@ -204,6 +207,7 @@ ocm: sram@fffc0000 {
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0xfffc0000 0x10000>;
> +
> ocm-sram@0 {
> reg = <0x0 0x10000>;
> };
> @@ -214,7 +218,7 @@ uart0: serial@e0000000 {
> status = "disabled";
> clocks = <&clkc 23>, <&clkc 40>;
> clock-names = "uart_clk", "pclk";
> - reg = <0xE0000000 0x1000>;
> + reg = <0xe0000000 0x1000>;
> interrupts = <0 27 4>;
> };
>
> @@ -223,7 +227,7 @@ uart1: serial@e0001000 {
> status = "disabled";
> clocks = <&clkc 24>, <&clkc 41>;
> clock-names = "uart_clk", "pclk";
> - reg = <0xE0001000 0x1000>;
> + reg = <0xe0001000 0x1000>;
> interrupts = <0 50 4>;
> };
>
> @@ -304,6 +308,7 @@ nfc0: nand-controller@0,0 {
> reg = <0 0 0x1000000>;
> status = "disabled";
> };
> +
> nor0: flash@1,0 {
> status = "disabled";
> compatible = "cfi-flash";
> @@ -336,24 +341,26 @@ slcr: slcr@f8000000 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "xlnx,zynq-slcr", "syscon", "simple-mfd";
> - reg = <0xF8000000 0x1000>;
> + reg = <0xf8000000 0x1000>;
> ranges;
> +
> clkc: clkc@100 {
> bootph-all;
> #clock-cells = <1>;
> compatible = "xlnx,ps7-clkc";
> fclk-enable = <0>;
> clock-output-names = "armpll", "ddrpll", "iopll", "cpu_6or4x",
> - "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x", "ddr3x",
> - "dci", "lqspi", "smc", "pcap", "gem0", "gem1",
> - "fclk0", "fclk1", "fclk2", "fclk3", "can0", "can1",
> - "sdio0", "sdio1", "uart0", "uart1", "spi0", "spi1",
> - "dma", "usb0_aper", "usb1_aper", "gem0_aper",
> - "gem1_aper", "sdio0_aper", "sdio1_aper",
> - "spi0_aper", "spi1_aper", "can0_aper", "can1_aper",
> - "i2c0_aper", "i2c1_aper", "uart0_aper", "uart1_aper",
> - "gpio_aper", "lqspi_aper", "smc_aper", "swdt",
> - "dbg_trc", "dbg_apb";
> + "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x",
> + "ddr3x", "dci", "lqspi", "smc", "pcap", "gem0",
> + "gem1", "fclk0", "fclk1", "fclk2", "fclk3",
> + "can0", "can1", "sdio0", "sdio1", "uart0",
> + "uart1", "spi0", "spi1", "dma", "usb0_aper",
> + "usb1_aper", "gem0_aper", "gem1_aper",
> + "sdio0_aper", "sdio1_aper", "spi0_aper",
> + "spi1_aper", "can0_aper", "can1_aper",
> + "i2c0_aper", "i2c1_aper", "uart0_aper",
> + "uart1_aper", "gpio_aper", "lqspi_aper",
> + "smc_aper", "swdt", "dbg_trc", "dbg_apb";
> reg = <0x100 0x100>;
> };
>
> @@ -380,10 +387,10 @@ dmac_s: dma-controller@f8003000 {
> * "dma4", "dma5", "dma6", "dma7";
> */
> interrupts = <0 13 4>,
> - <0 14 4>, <0 15 4>,
> - <0 16 4>, <0 17 4>,
> - <0 40 4>, <0 41 4>,
> - <0 42 4>, <0 43 4>;
> + <0 14 4>, <0 15 4>,
> + <0 16 4>, <0 17 4>,
> + <0 40 4>, <0 41 4>,
> + <0 42 4>, <0 43 4>;
> #dma-cells = <1>;
> clocks = <&clkc 27>;
> clock-names = "apb_pclk";
> @@ -412,7 +419,7 @@ ttc0: timer@f8001000 {
> interrupts = <0 10 4>, <0 11 4>, <0 12 4>;
> compatible = "cdns,ttc";
> clocks = <&clkc 6>;
> - reg = <0xF8001000 0x1000>;
> + reg = <0xf8001000 0x1000>;
> };
>
> ttc1: timer@f8002000 {
> @@ -420,7 +427,7 @@ ttc1: timer@f8002000 {
> interrupts = <0 37 4>, <0 38 4>, <0 39 4>;
> compatible = "cdns,ttc";
> clocks = <&clkc 6>;
> - reg = <0xF8002000 0x1000>;
> + reg = <0xf8002000 0x1000>;
> };
>
> scutimer: timer@f8f00600 {
> @@ -466,6 +473,7 @@ etb@f8801000 {
> reg = <0xf8801000 0x1000>;
> clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> +
> in-ports {
> port {
> etb_in_port: endpoint {
> @@ -480,6 +488,7 @@ tpiu@f8803000 {
> reg = <0xf8803000 0x1000>;
> clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> +
> in-ports {
> port {
> tpiu_in_port: endpoint {
> @@ -499,8 +508,7 @@ funnel@f8804000 {
> out-ports {
> port {
> funnel_out_port: endpoint {
> - remote-endpoint =
> - <&replicator_in_port0>;
> + remote-endpoint = <&replicator_in_port0>;
> };
> };
> };
> @@ -512,6 +520,7 @@ in-ports {
> /* funnel input ports */
> port@0 {
> reg = <0>;
> +
> funnel0_in_port0: endpoint {
> remote-endpoint = <&ptm0_out_port>;
> };
> @@ -519,6 +528,7 @@ funnel0_in_port0: endpoint {
>
> port@1 {
> reg = <1>;
> +
> funnel0_in_port1: endpoint {
> remote-endpoint = <&ptm1_out_port>;
> };
> @@ -526,8 +536,8 @@ funnel0_in_port1: endpoint {
>
> port@2 {
> reg = <2>;
> - funnel0_in_port2: endpoint {
> - };
> +
> + funnel0_in_port2: endpoint {};
> };
> /* The other input ports are not connect to anything */
> };
> @@ -539,6 +549,7 @@ ptm@f889c000 {
> clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> cpu = <&cpu0>;
> +
> out-ports {
> port {
> ptm0_out_port: endpoint {
> @@ -554,6 +565,7 @@ ptm@f889d000 {
> clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> cpu = <&cpu1>;
> +
> out-ports {
> port {
> ptm1_out_port: endpoint {
> diff --git a/arch/arm/boot/dts/xilinx/zynq-cc108.dts b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> index f5525c048426..25828ba9fa16 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> @@ -55,6 +55,7 @@ ethernet_phy: ethernet-phy@1 {
> &qspi {
> status = "okay";
> num-cs = <1>;
> +
> flash@0 { /* 16 MB */
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> @@ -63,26 +64,32 @@ flash@0 { /* 16 MB */
> spi-rx-bus-width = <4>;
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "qspi-fsbl-uboot-bs";
> reg = <0x0 0x400000>; /* 4MB */
> };
> +
> partition@400000 {
> label = "qspi-linux";
> reg = <0x400000 0x400000>; /* 4MB */
> };
> +
> partition@800000 {
> label = "qspi-rootfs";
> reg = <0x800000 0x400000>; /* 4MB */
> };
> +
> partition@c00000 {
> label = "qspi-devicetree";
> reg = <0xc00000 0x100000>; /* 1MB */
> };
> +
> partition@d00000 {
> label = "qspi-scratch";
> reg = <0xd00000 0x200000>; /* 2MB */
> };
> +
> partition@f00000 {
> label = "qspi-uboot-env";
> reg = <0xf00000 0x100000>; /* 1MB */
> @@ -92,8 +99,8 @@ partition@f00000 {
>
> &sdhci1 {
> status = "okay";
> - broken-cd ;
> - wp-inverted ;
> + broken-cd;
> + wp-inverted;
> };
>
> &uart0 {
> diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> index 14f644156a6f..d4c07d28ec25 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> @@ -53,6 +53,7 @@ &nfc0 {
>
> #address-cells = <1>;
> #size-cells = <0>;
> +
> nand@0 {
> reg = <0>;
> };
> diff --git a/arch/arm/boot/dts/xilinx/zynq-parallella.dts b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> index 366af4fcf8d9..e498feaa7ca4 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> @@ -44,10 +44,10 @@ &gem0 {
> ethernet_phy: ethernet-phy@0 {
> /* Marvell 88E1318 */
> compatible = "ethernet-phy-id0141.0e90",
> - "ethernet-phy-ieee802.3-c22";
> + "ethernet-phy-ieee802.3-c22";
> reg = <0>;
> marvell,reg-init = <0x3 0x10 0xff00 0x1e>,
> - <0x3 0x11 0xfff0 0xa>;
> + <0x3 0x11 0xfff0 0xa>;
> };
> };
>
> @@ -63,13 +63,16 @@ dcd1 {
> regulator-name = "VDD_DSP";
> regulator-always-on;
> };
> +
> dcd2 {
> regulator-name = "1P35V";
> regulator-always-on;
> };
> +
> ldo1 {
> regulator-name = "VDD_ADJ";
> };
> +
> ldo2 {
> regulator-name = "VDD_GPIO";
> regulator-always-on;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zc702.dts b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> index 6955637c5b1a..63eded827b37 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> @@ -34,6 +34,7 @@ chosen {
> gpio-keys {
> compatible = "gpio-keys";
> autorepeat;
> +
> switch-14 {
> label = "sw14";
> gpios = <&gpio0 12 0>;
> @@ -41,6 +42,7 @@ switch-14 {
> wakeup-source;
> autorepeat;
> };
> +
> switch-13 {
> label = "sw13";
> gpios = <&gpio0 14 0>;
> @@ -112,6 +114,7 @@ i2c@0 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0>;
> +
> si570: clock-generator@5d {
> #clock-cells = <0>;
> compatible = "silabs,si570";
> @@ -126,6 +129,7 @@ i2c@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <1>;
> +
> adv7511: hdmi-tx@39 {
> compatible = "adi,adv7511";
> reg = <0x39>;
> @@ -141,6 +145,7 @@ i2c@2 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <2>;
> +
> eeprom: eeprom@54 {
> compatible = "atmel,24c08";
> reg = <0x54>;
> @@ -151,6 +156,7 @@ i2c@3 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <3>;
> +
> gpio@21 {
> compatible = "ti,tca6416";
> reg = <0x21>;
> @@ -163,6 +169,7 @@ i2c@4 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <4>;
> +
> rtc: rtc@51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
> @@ -173,14 +180,17 @@ i2c@7 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <7>;
> +
> hwmon@34 {
> compatible = "ti,ucd9248";
> reg = <0x34>;
> };
> +
> hwmon@35 {
> compatible = "ti,ucd9248";
> reg = <0x35>;
> };
> +
> hwmon@36 {
> compatible = "ti,ucd9248";
> reg = <0x36>;
> @@ -396,32 +406,39 @@ &qspi {
> bootph-all;
> status = "okay";
> num-cs = <1>;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <1>;
> spi-rx-bus-width = <4>;
> spi-max-frequency = <50000000>;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "qspi-fsbl-uboot";
> reg = <0x0 0x100000>;
> };
> +
> partition@100000 {
> label = "qspi-linux";
> reg = <0x100000 0x500000>;
> };
> +
> partition@600000 {
> label = "qspi-device-tree";
> reg = <0x600000 0x20000>;
> };
> +
> partition@620000 {
> label = "qspi-rootfs";
> reg = <0x620000 0x5e0000>;
> };
> +
> partition@c00000 {
> label = "qspi-bitstream";
> reg = <0xc00000 0x400000>;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zc706.dts b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> index 3b803c698473..d6447e544d8f 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> @@ -73,6 +73,7 @@ i2c@0 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0>;
> +
> si570: clock-generator@5d {
> #clock-cells = <0>;
> compatible = "silabs,si570";
> @@ -87,6 +88,7 @@ i2c@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <1>;
> +
> adv7511: hdmi-tx@39 {
> compatible = "adi,adv7511";
> reg = <0x39>;
> @@ -102,6 +104,7 @@ i2c@2 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <2>;
> +
> eeprom: eeprom@54 {
> compatible = "atmel,24c08";
> reg = <0x54>;
> @@ -112,6 +115,7 @@ i2c@3 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <3>;
> +
> gpio@21 {
> compatible = "ti,tca6416";
> reg = <0x21>;
> @@ -124,6 +128,7 @@ i2c@4 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <4>;
> +
> rtc: rtc@51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
> @@ -134,6 +139,7 @@ i2c@7 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <7>;
> +
> ucd90120@65 {
> compatible = "ti,ucd90120";
> reg = <0x65>;
> @@ -309,6 +315,7 @@ &qspi {
> bootph-all;
> status = "okay";
> num-cs = <2>;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>, <1>;
> @@ -316,26 +323,32 @@ flash@0 {
> spi-tx-bus-width = <1>;
> spi-rx-bus-width = <4>;
> spi-max-frequency = <50000000>;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "qspi-fsbl-uboot";
> reg = <0x0 0x100000>;
> };
> +
> partition@100000 {
> label = "qspi-linux";
> reg = <0x100000 0x500000>;
> };
> +
> partition@600000 {
> label = "qspi-device-tree";
> reg = <0x600000 0x20000>;
> };
> +
> partition@620000 {
> label = "qspi-rootfs";
> reg = <0x620000 0x5e0000>;
> };
> +
> partition@c00000 {
> label = "qspi-bitstream";
> reg = <0xc00000 0x400000>;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> index 5fe799c3c7cf..4929a5aa1678 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> @@ -62,32 +62,39 @@ eeprom: eeprom@52 {
> &qspi {
> status = "okay";
> num-cs = <1>;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <1>;
> spi-rx-bus-width = <4>;
> spi-max-frequency = <50000000>;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "qspi-fsbl-uboot";
> reg = <0x0 0x100000>;
> };
> +
> partition@100000 {
> label = "qspi-linux";
> reg = <0x100000 0x500000>;
> };
> +
> partition@600000 {
> label = "qspi-device-tree";
> reg = <0x600000 0x20000>;
> };
> +
> partition@620000 {
> label = "qspi-rootfs";
> reg = <0x620000 0x5e0000>;
> };
> +
> partition@c00000 {
> label = "qspi-bitstream";
> reg = <0xc00000 0x400000>;
> @@ -104,14 +111,17 @@ &spi1 {
> status = "okay";
> num-cs = <4>;
> is-decoded-cs = <0>;
> +
> flash@1 {
> compatible = "sst25wf080", "jedec,spi-nor";
> reg = <1>;
> spi-max-frequency = <1000000>;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "data";
> reg = <0x0 0x100000>;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> index f9a086fe66d3..d4e739772d7b 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> @@ -51,20 +51,25 @@ &nfc0 {
> status = "okay";
> #address-cells = <1>;
> #size-cells = <0>;
> +
> nand@0 {
> reg = <0>;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "nand-fsbl-uboot";
> reg = <0x0 0x1000000>;
> };
> +
> partition@1000000 {
> label = "nand-linux";
> reg = <0x1000000 0x2000000>;
> };
> +
> partition@3000000 {
> label = "nand-rootfs";
> reg = <0x3000000 0x200000>;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> index 24520e7d3965..32422aed77a3 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> @@ -56,26 +56,32 @@ eeprom1: eeprom@52 {
> &nor0 {
> status = "okay";
> bank-width = <1>;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "nor-fsbl-uboot";
> reg = <0x0 0x100000>;
> };
> +
> partition@100000 {
> label = "nor-linux";
> reg = <0x100000 0x500000>;
> };
> +
> partition@600000 {
> label = "nor-device-tree";
> reg = <0x600000 0x20000>;
> };
> +
> partition@620000 {
> label = "nor-rootfs";
> reg = <0x620000 0x5e0000>;
> };
> +
> partition@c00000 {
> label = "nor-bitstream";
> reg = <0xc00000 0x400000>;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> index 103e87ea7253..9c94421bf650 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> @@ -61,6 +61,7 @@ si570: clock-generator@55 {
> &qspi {
> status = "okay";
> num-cs = <2>;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>, <1>;
> @@ -68,26 +69,32 @@ flash@0 {
> spi-tx-bus-width = <1>;
> spi-rx-bus-width = <4>;
> spi-max-frequency = <50000000>;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "qspi-fsbl-uboot";
> reg = <0x0 0x100000>;
> };
> +
> partition@100000 {
> label = "qspi-linux";
> reg = <0x100000 0x500000>;
> };
> +
> partition@600000 {
> label = "qspi-device-tree";
> reg = <0x600000 0x20000>;
> };
> +
> partition@620000 {
> label = "qspi-rootfs";
> reg = <0x620000 0x5e0000>;
> };
> +
> partition@c00000 {
> label = "qspi-bitstream";
> reg = <0xc00000 0x400000>;
> @@ -100,6 +107,7 @@ &spi0 {
> status = "okay";
> num-cs = <4>;
> is-decoded-cs = <0>;
> +
> eeprom: eeprom@2 {
> compatible = "atmel,at25";
> reg = <2>;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zed.dts b/arch/arm/boot/dts/xilinx/zynq-zed.dts
> index 52ba569b2b9f..dd46d71e3f36 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zed.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-zed.dts
> @@ -51,6 +51,7 @@ &qspi {
> bootph-all;
> status = "okay";
> num-cs = <1>;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> @@ -58,26 +59,32 @@ flash@0 {
> spi-rx-bus-width = <4>;
> spi-max-frequency = <50000000>;
> m25p,fast-read;
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> +
> partition@0 {
> label = "qspi-fsbl-uboot";
> reg = <0x0 0x100000>;
> };
> +
> partition@100000 {
> label = "qspi-linux";
> reg = <0x100000 0x500000>;
> };
> +
> partition@600000 {
> label = "qspi-device-tree";
> reg = <0x600000 0x20000>;
> };
> +
> partition@620000 {
> label = "qspi-rootfs";
> reg = <0x620000 0x5e0000>;
> };
> +
> partition@c00000 {
> label = "qspi-bitstream";
> reg = <0xc00000 0x400000>;
> diff --git a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> index defef9c8da13..57e6cda1a798 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> +++ b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> @@ -33,6 +33,7 @@ chosen {
>
> gpio-leds {
> compatible = "gpio-leds";
> +
> usr-led1 {
> label = "usr-led1";
> gpios = <&gpio0 0x0 0x1>;
> @@ -49,6 +50,7 @@ usr-led2 {
> gpio-keys {
> compatible = "gpio-keys";
> autorepeat;
> +
> key {
> label = "K1";
> gpios = <&gpio0 0x32 0x1>;
> @@ -73,8 +75,7 @@ &gem0 {
> phy-mode = "rgmii-id";
> phy-handle = <ðernet_phy>;
>
> - ethernet_phy: ethernet-phy@0 {
> - };
> + ethernet_phy: ethernet-phy@0 {};
> };
>
> &sdhci0 {
Hi,
Thanks for the feedback.
with regard to subject I am not sure in what subsystem file formatting would go (especially if we run it on even more files and more systems are modified) Your guidance would be appreciated.
With regard to improving the line wrapping, can you share some examples so that I can start looking on improving this?
To run on more files I will wait for feedback from Rob, Krzysztof and Conor.
Regards,
Kyle
Sent with Proton Mail secure email.
On Tuesday, January 6th, 2026 at 12:54 PM, Michal Simek <michal.simek@amd.com> wrote:
>
>
> Hi,
>
> On 12/18/25 13:51, kylebonnici wrote:
>
> > From: Kyle Bonnici kylebonnici@hotmail.com
> >
> > - Convert hex value to lowercase
> > - align property values to ' = '
> > - clean up whitespaces
> > - fix indentation
> > - add new line between nodes
> >
> > The changes are generated using the dts-linter.
> >
> > This is just a sample of what the above tool can fix and this change is
> > intended to start the conversation on how I should suggest fixes to this repo
> > Without sending one big PR.
> >
> > Also, this is my first attempt at such a submission. Hopefully I did not miss
> > Anything fundamental in the submission process.
>
>
> my issue is with subject. Where Coding Style: subsystem is not defined.
>
> I tried your tool locally and I think handling in connection to long line should
> be improved.
>
> But in general I don't have a problem to use any tool to do coding style
> formatting.
>
> Newlines I don't really mind but lower case, additional spaces, tabs/spaces are
> nicely visible.
>
> I think you should get ack from Rob, Krzysztof and Conor to run it in bigger scale.
>
> Thanks,
> Michal
>
> > Signed-off-by: Kyle Bonnici kylebonnici@proton.me
> > ---
> > arch/arm/boot/dts/xilinx/zynq-7000.dtsi | 72 +++++++++++--------
> > arch/arm/boot/dts/xilinx/zynq-cc108.dts | 11 ++-
> > arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 1 +
> > arch/arm/boot/dts/xilinx/zynq-parallella.dts | 7 +-
> > arch/arm/boot/dts/xilinx/zynq-zc702.dts | 17 +++++
> > arch/arm/boot/dts/xilinx/zynq-zc706.dts | 13 ++++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts | 10 +++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts | 5 ++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts | 6 ++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts | 8 +++
> > arch/arm/boot/dts/xilinx/zynq-zed.dts | 7 ++
> > .../boot/dts/xilinx/zynq-zturn-common.dtsi | 5 +-
> > 12 files changed, 126 insertions(+), 36 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> > index 153b8d93cbee..dd8a6528e8a7 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> > +++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> > @@ -27,10 +27,9 @@ cpu0: cpu@0 {
> > clock-latency = <1000>;
> > cpu0-supply = <®ulator_vccpint>;
> > operating-points = <
> > - /* kHz uV /
> > - 666667 1000000
> > - 333334 1000000
> > - >;
> > + / kHz uV */
> > + 666667 1000000
> > + 333334 1000000>;
> > };
> >
> > cpu1: cpu@1 {
> > @@ -78,17 +77,21 @@ out-ports {
> > /* replicator output ports /
> > port@0 {
> > reg = <0>;
> > +
> > replicator_out_port0: endpoint {
> > remote-endpoint = <&tpiu_in_port>;
> > };
> > };
> > +
> > port@1 {
> > reg = <1>;
> > +
> > replicator_out_port1: endpoint {
> > remote-endpoint = <&etb_in_port>;
> > };
> > };
> > };
> > +
> > in-ports {
> > / replicator input port */
> > port {
> > @@ -179,13 +182,13 @@ intc: interrupt-controller@f8f01000 {
> > compatible = "arm,cortex-a9-gic";
> > #interrupt-cells = <3>;
> > interrupt-controller;
> > - reg = <0xF8F01000 0x1000>,
> > - <0xF8F00100 0x100>;
> > + reg = <0xf8f01000 0x1000>,
> > + <0xf8f00100 0x100>;
> > };
> >
> > L2: cache-controller@f8f02000 {
> > compatible = "arm,pl310-cache";
> > - reg = <0xF8F02000 0x1000>;
> > + reg = <0xf8f02000 0x1000>;
> > interrupts = <0 2 4>;
> > arm,data-latency = <3 2 2>;
> > arm,tag-latency = <2 2 2>;
> > @@ -204,6 +207,7 @@ ocm: sram@fffc0000 {
> > #address-cells = <1>;
> > #size-cells = <1>;
> > ranges = <0 0xfffc0000 0x10000>;
> > +
> > ocm-sram@0 {
> > reg = <0x0 0x10000>;
> > };
> > @@ -214,7 +218,7 @@ uart0: serial@e0000000 {
> > status = "disabled";
> > clocks = <&clkc 23>, <&clkc 40>;
> > clock-names = "uart_clk", "pclk";
> > - reg = <0xE0000000 0x1000>;
> > + reg = <0xe0000000 0x1000>;
> > interrupts = <0 27 4>;
> > };
> >
> > @@ -223,7 +227,7 @@ uart1: serial@e0001000 {
> > status = "disabled";
> > clocks = <&clkc 24>, <&clkc 41>;
> > clock-names = "uart_clk", "pclk";
> > - reg = <0xE0001000 0x1000>;
> > + reg = <0xe0001000 0x1000>;
> > interrupts = <0 50 4>;
> > };
> >
> > @@ -304,6 +308,7 @@ nfc0: nand-controller@0,0 {
> > reg = <0 0 0x1000000>;
> > status = "disabled";
> > };
> > +
> > nor0: flash@1,0 {
> > status = "disabled";
> > compatible = "cfi-flash";
> > @@ -336,24 +341,26 @@ slcr: slcr@f8000000 {
> > #address-cells = <1>;
> > #size-cells = <1>;
> > compatible = "xlnx,zynq-slcr", "syscon", "simple-mfd";
> > - reg = <0xF8000000 0x1000>;
> > + reg = <0xf8000000 0x1000>;
> > ranges;
> > +
> > clkc: clkc@100 {
> > bootph-all;
> > #clock-cells = <1>;
> > compatible = "xlnx,ps7-clkc";
> > fclk-enable = <0>;
> > clock-output-names = "armpll", "ddrpll", "iopll", "cpu_6or4x",
> > - "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x", "ddr3x",
> > - "dci", "lqspi", "smc", "pcap", "gem0", "gem1",
> > - "fclk0", "fclk1", "fclk2", "fclk3", "can0", "can1",
> > - "sdio0", "sdio1", "uart0", "uart1", "spi0", "spi1",
> > - "dma", "usb0_aper", "usb1_aper", "gem0_aper",
> > - "gem1_aper", "sdio0_aper", "sdio1_aper",
> > - "spi0_aper", "spi1_aper", "can0_aper", "can1_aper",
> > - "i2c0_aper", "i2c1_aper", "uart0_aper", "uart1_aper",
> > - "gpio_aper", "lqspi_aper", "smc_aper", "swdt",
> > - "dbg_trc", "dbg_apb";
> > + "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x",
> > + "ddr3x", "dci", "lqspi", "smc", "pcap", "gem0",
> > + "gem1", "fclk0", "fclk1", "fclk2", "fclk3",
> > + "can0", "can1", "sdio0", "sdio1", "uart0",
> > + "uart1", "spi0", "spi1", "dma", "usb0_aper",
> > + "usb1_aper", "gem0_aper", "gem1_aper",
> > + "sdio0_aper", "sdio1_aper", "spi0_aper",
> > + "spi1_aper", "can0_aper", "can1_aper",
> > + "i2c0_aper", "i2c1_aper", "uart0_aper",
> > + "uart1_aper", "gpio_aper", "lqspi_aper",
> > + "smc_aper", "swdt", "dbg_trc", "dbg_apb";
> > reg = <0x100 0x100>;
> > };
> >
> > @@ -380,10 +387,10 @@ dmac_s: dma-controller@f8003000 {
> > * "dma4", "dma5", "dma6", "dma7";
> > */
> > interrupts = <0 13 4>,
> > - <0 14 4>, <0 15 4>,
> > - <0 16 4>, <0 17 4>,
> > - <0 40 4>, <0 41 4>,
> > - <0 42 4>, <0 43 4>;
> > + <0 14 4>, <0 15 4>,
> > + <0 16 4>, <0 17 4>,
> > + <0 40 4>, <0 41 4>,
> > + <0 42 4>, <0 43 4>;
> > #dma-cells = <1>;
> > clocks = <&clkc 27>;
> > clock-names = "apb_pclk";
> > @@ -412,7 +419,7 @@ ttc0: timer@f8001000 {
> > interrupts = <0 10 4>, <0 11 4>, <0 12 4>;
> > compatible = "cdns,ttc";
> > clocks = <&clkc 6>;
> > - reg = <0xF8001000 0x1000>;
> > + reg = <0xf8001000 0x1000>;
> > };
> >
> > ttc1: timer@f8002000 {
> > @@ -420,7 +427,7 @@ ttc1: timer@f8002000 {
> > interrupts = <0 37 4>, <0 38 4>, <0 39 4>;
> > compatible = "cdns,ttc";
> > clocks = <&clkc 6>;
> > - reg = <0xF8002000 0x1000>;
> > + reg = <0xf8002000 0x1000>;
> > };
> >
> > scutimer: timer@f8f00600 {
> > @@ -466,6 +473,7 @@ etb@f8801000 {
> > reg = <0xf8801000 0x1000>;
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > +
> > in-ports {
> > port {
> > etb_in_port: endpoint {
> > @@ -480,6 +488,7 @@ tpiu@f8803000 {
> > reg = <0xf8803000 0x1000>;
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > +
> > in-ports {
> > port {
> > tpiu_in_port: endpoint {
> > @@ -499,8 +508,7 @@ funnel@f8804000 {
> > out-ports {
> > port {
> > funnel_out_port: endpoint {
> > - remote-endpoint =
> > - <&replicator_in_port0>;
> > + remote-endpoint = <&replicator_in_port0>;
> > };
> > };
> > };
> > @@ -512,6 +520,7 @@ in-ports {
> > /* funnel input ports */
> > port@0 {
> > reg = <0>;
> > +
> > funnel0_in_port0: endpoint {
> > remote-endpoint = <&ptm0_out_port>;
> > };
> > @@ -519,6 +528,7 @@ funnel0_in_port0: endpoint {
> >
> > port@1 {
> > reg = <1>;
> > +
> > funnel0_in_port1: endpoint {
> > remote-endpoint = <&ptm1_out_port>;
> > };
> > @@ -526,8 +536,8 @@ funnel0_in_port1: endpoint {
> >
> > port@2 {
> > reg = <2>;
> > - funnel0_in_port2: endpoint {
> > - };
> > +
> > + funnel0_in_port2: endpoint {};
> > };
> > /* The other input ports are not connect to anything /
> > };
> > @@ -539,6 +549,7 @@ ptm@f889c000 {
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > cpu = <&cpu0>;
> > +
> > out-ports {
> > port {
> > ptm0_out_port: endpoint {
> > @@ -554,6 +565,7 @@ ptm@f889d000 {
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > cpu = <&cpu1>;
> > +
> > out-ports {
> > port {
> > ptm1_out_port: endpoint {
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-cc108.dts b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> > index f5525c048426..25828ba9fa16 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> > @@ -55,6 +55,7 @@ ethernet_phy: ethernet-phy@1 {
> > &qspi {
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 { / 16 MB /
> > compatible = "jedec,spi-nor";
> > reg = <0x0>;
> > @@ -63,26 +64,32 @@ flash@0 { / 16 MB /
> > spi-rx-bus-width = <4>;
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot-bs";
> > reg = <0x0 0x400000>; / 4MB /
> > };
> > +
> > partition@400000 {
> > label = "qspi-linux";
> > reg = <0x400000 0x400000>; / 4MB /
> > };
> > +
> > partition@800000 {
> > label = "qspi-rootfs";
> > reg = <0x800000 0x400000>; / 4MB /
> > };
> > +
> > partition@c00000 {
> > label = "qspi-devicetree";
> > reg = <0xc00000 0x100000>; / 1MB /
> > };
> > +
> > partition@d00000 {
> > label = "qspi-scratch";
> > reg = <0xd00000 0x200000>; / 2MB /
> > };
> > +
> > partition@f00000 {
> > label = "qspi-uboot-env";
> > reg = <0xf00000 0x100000>; / 1MB */
> > @@ -92,8 +99,8 @@ partition@f00000 {
> >
> > &sdhci1 {
> > status = "okay";
> > - broken-cd ;
> > - wp-inverted ;
> > + broken-cd;
> > + wp-inverted;
> > };
> >
> > &uart0 {
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> > index 14f644156a6f..d4c07d28ec25 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> > @@ -53,6 +53,7 @@ &nfc0 {
> >
> > #address-cells = <1>;
> > #size-cells = <0>;
> > +
> > nand@0 {
> > reg = <0>;
> > };
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-parallella.dts b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> > index 366af4fcf8d9..e498feaa7ca4 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> > @@ -44,10 +44,10 @@ &gem0 {
> > ethernet_phy: ethernet-phy@0 {
> > /* Marvell 88E1318 */
> > compatible = "ethernet-phy-id0141.0e90",
> > - "ethernet-phy-ieee802.3-c22";
> > + "ethernet-phy-ieee802.3-c22";
> > reg = <0>;
> > marvell,reg-init = <0x3 0x10 0xff00 0x1e>,
> > - <0x3 0x11 0xfff0 0xa>;
> > + <0x3 0x11 0xfff0 0xa>;
> > };
> > };
> >
> > @@ -63,13 +63,16 @@ dcd1 {
> > regulator-name = "VDD_DSP";
> > regulator-always-on;
> > };
> > +
> > dcd2 {
> > regulator-name = "1P35V";
> > regulator-always-on;
> > };
> > +
> > ldo1 {
> > regulator-name = "VDD_ADJ";
> > };
> > +
> > ldo2 {
> > regulator-name = "VDD_GPIO";
> > regulator-always-on;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc702.dts b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> > index 6955637c5b1a..63eded827b37 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> > @@ -34,6 +34,7 @@ chosen {
> > gpio-keys {
> > compatible = "gpio-keys";
> > autorepeat;
> > +
> > switch-14 {
> > label = "sw14";
> > gpios = <&gpio0 12 0>;
> > @@ -41,6 +42,7 @@ switch-14 {
> > wakeup-source;
> > autorepeat;
> > };
> > +
> > switch-13 {
> > label = "sw13";
> > gpios = <&gpio0 14 0>;
> > @@ -112,6 +114,7 @@ i2c@0 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <0>;
> > +
> > si570: clock-generator@5d {
> > #clock-cells = <0>;
> > compatible = "silabs,si570";
> > @@ -126,6 +129,7 @@ i2c@1 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <1>;
> > +
> > adv7511: hdmi-tx@39 {
> > compatible = "adi,adv7511";
> > reg = <0x39>;
> > @@ -141,6 +145,7 @@ i2c@2 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <2>;
> > +
> > eeprom: eeprom@54 {
> > compatible = "atmel,24c08";
> > reg = <0x54>;
> > @@ -151,6 +156,7 @@ i2c@3 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <3>;
> > +
> > gpio@21 {
> > compatible = "ti,tca6416";
> > reg = <0x21>;
> > @@ -163,6 +169,7 @@ i2c@4 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <4>;
> > +
> > rtc: rtc@51 {
> > compatible = "nxp,pcf8563";
> > reg = <0x51>;
> > @@ -173,14 +180,17 @@ i2c@7 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <7>;
> > +
> > hwmon@34 {
> > compatible = "ti,ucd9248";
> > reg = <0x34>;
> > };
> > +
> > hwmon@35 {
> > compatible = "ti,ucd9248";
> > reg = <0x35>;
> > };
> > +
> > hwmon@36 {
> > compatible = "ti,ucd9248";
> > reg = <0x36>;
> > @@ -396,32 +406,39 @@ &qspi {
> > bootph-all;
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0x0>;
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@100000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@600000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@620000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@c00000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc706.dts b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> > index 3b803c698473..d6447e544d8f 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> > @@ -73,6 +73,7 @@ i2c@0 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <0>;
> > +
> > si570: clock-generator@5d {
> > #clock-cells = <0>;
> > compatible = "silabs,si570";
> > @@ -87,6 +88,7 @@ i2c@1 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <1>;
> > +
> > adv7511: hdmi-tx@39 {
> > compatible = "adi,adv7511";
> > reg = <0x39>;
> > @@ -102,6 +104,7 @@ i2c@2 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <2>;
> > +
> > eeprom: eeprom@54 {
> > compatible = "atmel,24c08";
> > reg = <0x54>;
> > @@ -112,6 +115,7 @@ i2c@3 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <3>;
> > +
> > gpio@21 {
> > compatible = "ti,tca6416";
> > reg = <0x21>;
> > @@ -124,6 +128,7 @@ i2c@4 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <4>;
> > +
> > rtc: rtc@51 {
> > compatible = "nxp,pcf8563";
> > reg = <0x51>;
> > @@ -134,6 +139,7 @@ i2c@7 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <7>;
> > +
> > ucd90120@65 {
> > compatible = "ti,ucd90120";
> > reg = <0x65>;
> > @@ -309,6 +315,7 @@ &qspi {
> > bootph-all;
> > status = "okay";
> > num-cs = <2>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0>, <1>;
> > @@ -316,26 +323,32 @@ flash@0 {
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@100000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@600000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@620000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@c00000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> > index 5fe799c3c7cf..4929a5aa1678 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> > @@ -62,32 +62,39 @@ eeprom: eeprom@52 {
> > &qspi {
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0x0>;
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@100000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@600000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@620000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@c00000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > @@ -104,14 +111,17 @@ &spi1 {
> > status = "okay";
> > num-cs = <4>;
> > is-decoded-cs = <0>;
> > +
> > flash@1 {
> > compatible = "sst25wf080", "jedec,spi-nor";
> > reg = <1>;
> > spi-max-frequency = <1000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "data";
> > reg = <0x0 0x100000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> > index f9a086fe66d3..d4e739772d7b 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> > @@ -51,20 +51,25 @@ &nfc0 {
> > status = "okay";
> > #address-cells = <1>;
> > #size-cells = <0>;
> > +
> > nand@0 {
> > reg = <0>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "nand-fsbl-uboot";
> > reg = <0x0 0x1000000>;
> > };
> > +
> > partition@1000000 {
> > label = "nand-linux";
> > reg = <0x1000000 0x2000000>;
> > };
> > +
> > partition@3000000 {
> > label = "nand-rootfs";
> > reg = <0x3000000 0x200000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> > index 24520e7d3965..32422aed77a3 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> > @@ -56,26 +56,32 @@ eeprom1: eeprom@52 {
> > &nor0 {
> > status = "okay";
> > bank-width = <1>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "nor-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@100000 {
> > label = "nor-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@600000 {
> > label = "nor-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@620000 {
> > label = "nor-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@c00000 {
> > label = "nor-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> > index 103e87ea7253..9c94421bf650 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> > @@ -61,6 +61,7 @@ si570: clock-generator@55 {
> > &qspi {
> > status = "okay";
> > num-cs = <2>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0>, <1>;
> > @@ -68,26 +69,32 @@ flash@0 {
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@100000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@600000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@620000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@c00000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > @@ -100,6 +107,7 @@ &spi0 {
> > status = "okay";
> > num-cs = <4>;
> > is-decoded-cs = <0>;
> > +
> > eeprom: eeprom@2 {
> > compatible = "atmel,at25";
> > reg = <2>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zed.dts b/arch/arm/boot/dts/xilinx/zynq-zed.dts
> > index 52ba569b2b9f..dd46d71e3f36 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zed.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zed.dts
> > @@ -51,6 +51,7 @@ &qspi {
> > bootph-all;
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0>;
> > @@ -58,26 +59,32 @@ flash@0 {
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > m25p,fast-read;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@100000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@600000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@620000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@c00000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> > index defef9c8da13..57e6cda1a798 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> > @@ -33,6 +33,7 @@ chosen {
> >
> > gpio-leds {
> > compatible = "gpio-leds";
> > +
> > usr-led1 {
> > label = "usr-led1";
> > gpios = <&gpio0 0x0 0x1>;
> > @@ -49,6 +50,7 @@ usr-led2 {
> > gpio-keys {
> > compatible = "gpio-keys";
> > autorepeat;
> > +
> > key {
> > label = "K1";
> > gpios = <&gpio0 0x32 0x1>;
> > @@ -73,8 +75,7 @@ &gem0 {
> > phy-mode = "rgmii-id";
> > phy-handle = <ðernet_phy>;
> >
> > - ethernet_phy: ethernet-phy@0 {
> > - };
> > + ethernet_phy: ethernet-phy@0 {};
> > };
> >
> > &sdhci0 {
Hi,
On 1/6/26 21:28, kylebonnici wrote:
> Hi,
>
first of all please don't do top posting.
> Thanks for the feedback.
>
> with regard to subject I am not sure in what subsystem file formatting would go (especially if we run it on even more files and more systems are modified) Your guidance would be appreciated.
arm: xilinx:
or for 64 bit version
arm64: xilinx:
>
> With regard to improving the line wrapping, can you share some examples so that I can start looking on improving this?
run it over zynqmp.dtsi file
And focus on pcie node
@@ -958,8 +979,10 @@ pcie: pcie@fd0e0000 {
<0x0 0xfd480000 0x0 0x1000>,
<0x80 0x00000000 0x0 0x10000000>;
reg-names = "breg", "pcireg", "cfg";
- ranges = <0x02000000 0x00000000 0xe0000000 0x00000000
0xe0000000 0x00000000 0x10000000>,/* non-prefetchable memory */
- <0x43000000 0x00000006 0x00000000 0x00000006
0x00000000 0x00000002 0x00000000>;/* prefetchable memory */
+ ranges = <0x02000000 0x00000000 0xe0000000 0x00000000
0xe0000000 0x00000000
+ 0x10000000>,/* non-prefetchable memory */
+ <0x43000000 0x00000006 0x00000000 0x00000006
0x00000000 0x00000002
+ 0x00000000>;/* prefetchable memory */
bus-range = <0x00 0xff>;
1. sometimes commens are using space,tab or nothing. Same style would be useful.
2. last cell on next line looks weird to me. I think you can decode
address-cells/size-cells for ranges and do indentation base on it.
>
> To run on more files I will wait for feedback from Rob, Krzysztof and Conor.
yep.
Thanks,
Michal
Hi,
On 1/7/26 08:49, Michal wrote:
>
>
> Hi,
>
> On 1/6/26 21:28, kylebonnici wrote:
>
> > Hi,
>
>
> first of all please don't do top posting.
Noted
>
> > Thanks for the feedback.
> >
> > with regard to subject I am not sure in what subsystem file formatting would go (especially if we run it on even more files and more systems are modified) Your guidance would be appreciated.
>
>
> arm: xilinx:
>
> or for 64 bit version
>
> arm64: xilinx:
At this point how does one go about changing subject ? by creating a new patch or is there some other process?
>
> > With regard to improving the line wrapping, can you share some examples so that I can start looking on improving this?
>
>
>
> run it over zynqmp.dtsi file
> And focus on pcie node
>
> @@ -958,8 +979,10 @@ pcie: pcie@fd0e0000 {
> <0x0 0xfd480000 0x0 0x1000>,
>
> <0x80 0x00000000 0x0 0x10000000>;
>
> reg-names = "breg", "pcireg", "cfg";
> - ranges = <0x02000000 0x00000000 0xe0000000 0x00000000
> 0xe0000000 0x00000000 0x10000000>,/* non-prefetchable memory */
>
> - <0x43000000 0x00000006 0x00000000 0x00000006
> 0x00000000 0x00000002 0x00000000>;/* prefetchable memory */
>
> + ranges = <0x02000000 0x00000000 0xe0000000 0x00000000
> 0xe0000000 0x00000000
> + 0x10000000>,/* non-prefetchable memory */
>
> + <0x43000000 0x00000006 0x00000000 0x00000006
> 0x00000000 0x00000002
> + 0x00000000>;/* prefetchable memory */
>
> bus-range = <0x00 0xff>;
>
>
> 1. sometimes commens are using space,tab or nothing. Same style would be useful.
Comments are currently untouched when the comment first token is not the first token on the line.
This is because some users wanted comments to align within a property values e.g. `foo = <...> /* ...*/\n,<...>; /* ...*/`and some wanted to also align comments across multiple properties in the same node. Hence no rule on how this should be formatted was reached when this tool was applied to format the Zephyr project.
I am open to discuss some rule that can be followed and looking applying that.
> 2. last cell on next line looks weird to me. I think you can decode
> address-cells/size-cells for ranges and do indentation base on it.
This is not necessarily always possible with out parsing the full context i.e all the includes from the root of this context.
Reasons:
- This values found in this node in this file might be overridden by some later definition.
- The omission of these values can mean a value of 2 and 1 respectively or again these may have been defined in some other instance in the full dts context.
Currently the rule to wrap is a follows:
- Wrap Value (e.g ...., <0xf00 (0xc - 0xb) 0xaa>) > if value length + indentation exceeds the wrap column
- Wrap Expression (e.g. ...(0xc - 0xb) 0xaa>, Note that expression are wrapped outside in when we have nested expressions and nested expression will be indented to be aligned with the parent expression group > if value length + indentation exceeds the wrap column,
- Warp Value e.g ....0xaa>
>
> > To run on more files I will wait for feedback from Rob, Krzysztof and Conor.
>
>
> yep.
>
> Thanks,
> Michal
© 2016 - 2026 Red Hat, Inc.