node: fix a api misuse in node_init_node_access()

[PATCH] node: fix a api misuse in node_init_node_access()

Posted by Haoxiang Li 1 month, 3 weeks ago

If device_register() fails, put_device() is the correct way to
cleanup the resource.
And free the dev name is unnecessary.

Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
 drivers/base/node.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index 00cf4532f121..28c89ad67d0b 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -170,14 +170,15 @@ static struct node_access_nodes *node_init_node_access(struct node *node,
 	if (dev_set_name(dev, "access%u", access))
 		goto free;
 
-	if (device_register(dev))
-		goto free_name;
+	if (device_register(dev)) {
+		put_device(dev);
+		return NULL;
+	}
 
 	pm_runtime_no_callbacks(dev);
 	list_add_tail(&access_node->list_node, &node->access_list);
 	return access_node;
-free_name:
-	kfree_const(dev->kobj.name);
+
 free:
 	kfree(access_node);
 	return NULL;
-- 
2.25.1

Re: [PATCH] node: fix a api misuse in node_init_node_access()

Posted by Greg KH 1 month, 3 weeks ago

On Thu, Dec 18, 2025 at 04:52:51PM +0800, Haoxiang Li wrote:
> If device_register() fails, put_device() is the correct way to
> cleanup the resource.
> And free the dev name is unnecessary.
> 
> Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
> ---
>  drivers/base/node.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 00cf4532f121..28c89ad67d0b 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -170,14 +170,15 @@ static struct node_access_nodes *node_init_node_access(struct node *node,
>  	if (dev_set_name(dev, "access%u", access))
>  		goto free;
>  
> -	if (device_register(dev))
> -		goto free_name;
> +	if (device_register(dev)) {
> +		put_device(dev);
> +		return NULL;
> +	}
>  
>  	pm_runtime_no_callbacks(dev);
>  	list_add_tail(&access_node->list_node, &node->access_list);
>  	return access_node;
> -free_name:
> -	kfree_const(dev->kobj.name);
> +
>  free:
>  	kfree(access_node);
>  	return NULL;
> -- 
> 2.25.1
> 
> 

How was this found and tested?