1. Patchew
  2. linux
  3. [PATCH v4 0/6] Microsoft Surface Pro 11 support
  4. View patch

[PATCH v4 1/6] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11

Jérôme de Bretagne via B4 Relay posted 6 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH v4 1/6] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11
Posted by Jérôme de Bretagne via B4 Relay 1 month, 3 weeks ago 
From: Jérôme de Bretagne <jerome.debretagne@gmail.com>

Add the compatibles for the Qualcomm-based Microsoft Surface Pro 11,
using its Denali codename.

The LCD models are using the Qualcomm Snapdragon X1 Plus (X1P64100),
the OLED ones are using the Qualcomm Snapdragon X1 Elite (X1E80100).

Due to the difference in how the built-in panel is being handled
between the OLED variant and LCD one, it is required to have two
separate DTBs, so document the compatible string for both variants.

Signed-off-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index d84bd3bca2010508a8225b9549d8c634efa06531..3685330344c0bf621125fc3d2f9c04082d6de144 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1067,6 +1067,17 @@ properties:
           - const: qcom,x1e78100
           - const: qcom,x1e80100
 
+      - items:
+          - const: microsoft,denali-lcd
+          - const: microsoft,denali
+          - const: qcom,x1p64100
+          - const: qcom,x1e80100
+
+      - items:
+          - const: microsoft,denali-oled
+          - const: microsoft,denali
+          - const: qcom,x1e80100
+
       - items:
           - enum:
               - asus,vivobook-s15

-- 
2.47.3
Re: [PATCH v4 1/6] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago 
On 18/12/2025 23:22, Jérôme de Bretagne via B4 Relay wrote:
> From: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> 
> Add the compatibles for the Qualcomm-based Microsoft Surface Pro 11,
> using its Denali codename.
> 
> The LCD models are using the Qualcomm Snapdragon X1 Plus (X1P64100),
> the OLED ones are using the Qualcomm Snapdragon X1 Elite (X1E80100).
> 
> Due to the difference in how the built-in panel is being handled
> between the OLED variant and LCD one, it is required to have two
> separate DTBs, so document the compatible string for both variants.
> 
> Signed-off-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index d84bd3bca2010508a8225b9549d8c634efa06531..3685330344c0bf621125fc3d2f9c04082d6de144 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1067,6 +1067,17 @@ properties:
>            - const: qcom,x1e78100
>            - const: qcom,x1e80100
>  
> +      - items:
> +          - const: microsoft,denali-lcd
> +          - const: microsoft,denali
> +          - const: qcom,x1p64100

64 < 78, so this should be placed after devkit list.

> +          - const: qcom,x1e80100
> +
> +      - items:
> +          - const: microsoft,denali-oled
> +          - const: microsoft,denali

So this goes after hamoa list, to keep somehow logical order.

> +          - const: qcom,x1e80100
> +
>        - items:
>            - enum:
>                - asus,vivobook-s15
> 


Best regards,
Krzysztof
Re: [PATCH v4 1/6] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago 
On 19/12/2025 18:40, Krzysztof Kozlowski wrote:
> On 18/12/2025 23:22, Jérôme de Bretagne via B4 Relay wrote:
>> From: Jérôme de Bretagne <jerome.debretagne@gmail.com>
>>
>> Add the compatibles for the Qualcomm-based Microsoft Surface Pro 11,
>> using its Denali codename.
>>
>> The LCD models are using the Qualcomm Snapdragon X1 Plus (X1P64100),
>> the OLED ones are using the Qualcomm Snapdragon X1 Elite (X1E80100).
>>
>> Due to the difference in how the built-in panel is being handled
>> between the OLED variant and LCD one, it is required to have two
>> separate DTBs, so document the compatible string for both variants.
>>
>> Signed-off-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index d84bd3bca2010508a8225b9549d8c634efa06531..3685330344c0bf621125fc3d2f9c04082d6de144 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1067,6 +1067,17 @@ properties:
>>            - const: qcom,x1e78100
>>            - const: qcom,x1e80100
>>  
>> +      - items:
>> +          - const: microsoft,denali-lcd
>> +          - const: microsoft,denali
>> +          - const: qcom,x1p64100
> 
> 64 < 78, so this should be placed after devkit list.

No, I missed this is x1p, not x1e. This is placed correct, but the oled
should be moved as I suggested.

> 
>> +          - const: qcom,x1e80100
>> +
>> +      - items:
>> +          - const: microsoft,denali-oled
>> +          - const: microsoft,denali
> 
> So this goes after hamoa list, to keep somehow logical order.
> 
>> +          - const: qcom,x1e80100
>> +
>>        - items:
>>            - enum:
>>                - asus,vivobook-s15
>>
> 
> 
> Best regards,
> Krzysztof


Best regards,
Krzysztof
Re: [PATCH v4 1/6] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11
Posted by Jérôme de Bretagne 1 month, 3 weeks ago 
Le ven. 19 déc. 2025 à 18:44, Krzysztof Kozlowski <krzk@kernel.org> a écrit :
>
> On 19/12/2025 18:40, Krzysztof Kozlowski wrote:
> > On 18/12/2025 23:22, Jérôme de Bretagne via B4 Relay wrote:
> >> From: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> >>
> >> Add the compatibles for the Qualcomm-based Microsoft Surface Pro 11,
> >> using its Denali codename.
> >>
> >> The LCD models are using the Qualcomm Snapdragon X1 Plus (X1P64100),
> >> the OLED ones are using the Qualcomm Snapdragon X1 Elite (X1E80100).
> >>
> >> Due to the difference in how the built-in panel is being handled
> >> between the OLED variant and LCD one, it is required to have two
> >> separate DTBs, so document the compatible string for both variants.
> >>
> >> Signed-off-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> >> ---
> >>  Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> >> index d84bd3bca2010508a8225b9549d8c634efa06531..3685330344c0bf621125fc3d2f9c04082d6de144 100644
> >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> >> @@ -1067,6 +1067,17 @@ properties:
> >>            - const: qcom,x1e78100
> >>            - const: qcom,x1e80100
> >>
> >> +      - items:
> >> +          - const: microsoft,denali-lcd
> >> +          - const: microsoft,denali
> >> +          - const: qcom,x1p64100
> >
> > 64 < 78, so this should be placed after devkit list.
>
> No, I missed this is x1p, not x1e. This is placed correct, but the oled
> should be moved as I suggested.

Indeed, this is x1p for the 64100, I didn't choose this naming :)
I will move the oled entry after hamoa in v5.

> >> +          - const: qcom,x1e80100
> >> +
> >> +      - items:
> >> +          - const: microsoft,denali-oled
> >> +          - const: microsoft,denali
> >
> > So this goes after hamoa list, to keep somehow logical order.
> >
> >> +          - const: qcom,x1e80100
> >> +
> >>        - items:
> >>            - enum:
> >>                - asus,vivobook-s15
> >>
> >
> >
> > Best regards,
> > Krzysztof
>
>
> Best regards,
> Krzysztof

Thank you for the review,
Jérôme

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.