ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub

[PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub

Posted by Sheetal . 1 month, 3 weeks ago

From: sheetal <sheetal@nvidia.com>

Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
in tegra210_ahub") attempted to fix the uninitialized flat cache warning
that is observed for the Tegra210 AHUB driver. However, the change broke
various audio tests because an -EBUSY error is returned when accessing
registers from cache before they are read from hardware. Revert this
change for now, until a proper fix is available.

Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub")
Signed-off-by: sheetal <sheetal@nvidia.com>
---
 sound/soc/tegra/tegra210_ahub.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahub.c
index 261d9067d27b..e795907a3963 100644
--- a/sound/soc/tegra/tegra210_ahub.c
+++ b/sound/soc/tegra/tegra210_ahub.c
@@ -2077,7 +2077,7 @@ static const struct regmap_config tegra210_ahub_regmap_config = {
 	.val_bits		= 32,
 	.reg_stride		= 4,
 	.max_register		= TEGRA210_MAX_REGISTER_ADDR,
-	.cache_type		= REGCACHE_FLAT_S,
+	.cache_type		= REGCACHE_FLAT,
 };
 
 static const struct regmap_config tegra186_ahub_regmap_config = {
@@ -2085,7 +2085,7 @@ static const struct regmap_config tegra186_ahub_regmap_config = {
 	.val_bits		= 32,
 	.reg_stride		= 4,
 	.max_register		= TEGRA186_MAX_REGISTER_ADDR,
-	.cache_type		= REGCACHE_FLAT_S,
+	.cache_type		= REGCACHE_FLAT,
 };
 
 static const struct regmap_config tegra264_ahub_regmap_config = {
@@ -2094,7 +2094,7 @@ static const struct regmap_config tegra264_ahub_regmap_config = {
 	.reg_stride		= 4,
 	.writeable_reg		= tegra264_ahub_wr_reg,
 	.max_register		= TEGRA264_MAX_REGISTER_ADDR,
-	.cache_type		= REGCACHE_FLAT_S,
+	.cache_type		= REGCACHE_FLAT,
 };
 
 static const struct tegra_ahub_soc_data soc_data_tegra210 = {
-- 
2.34.1

Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub

Posted by Mark Brown 3 weeks, 4 days ago

On Wed, 17 Dec 2025 18:55:24 +0530, Sheetal . wrote:
> Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
> in tegra210_ahub") attempted to fix the uninitialized flat cache warning
> that is observed for the Tegra210 AHUB driver. However, the change broke
> various audio tests because an -EBUSY error is returned when accessing
> registers from cache before they are read from hardware. Revert this
> change for now, until a proper fix is available.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub
      commit: f34b32745e2c9f85ee33b42e7a8cdaa1ee1c16a3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub

Posted by Jon Hunter 1 month, 3 weeks ago

On 17/12/2025 13:25, Sheetal . wrote:
> From: sheetal <sheetal@nvidia.com>
> 
> Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
> in tegra210_ahub") attempted to fix the uninitialized flat cache warning
> that is observed for the Tegra210 AHUB driver. However, the change broke
> various audio tests because an -EBUSY error is returned when accessing
> registers from cache before they are read from hardware. Revert this
> change for now, until a proper fix is available.
> 
> Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub")
> Signed-off-by: sheetal <sheetal@nvidia.com>
> ---
>   sound/soc/tegra/tegra210_ahub.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahub.c
> index 261d9067d27b..e795907a3963 100644
> --- a/sound/soc/tegra/tegra210_ahub.c
> +++ b/sound/soc/tegra/tegra210_ahub.c
> @@ -2077,7 +2077,7 @@ static const struct regmap_config tegra210_ahub_regmap_config = {
>   	.val_bits		= 32,
>   	.reg_stride		= 4,
>   	.max_register		= TEGRA210_MAX_REGISTER_ADDR,
> -	.cache_type		= REGCACHE_FLAT_S,
> +	.cache_type		= REGCACHE_FLAT,
>   };
>   
>   static const struct regmap_config tegra186_ahub_regmap_config = {
> @@ -2085,7 +2085,7 @@ static const struct regmap_config tegra186_ahub_regmap_config = {
>   	.val_bits		= 32,
>   	.reg_stride		= 4,
>   	.max_register		= TEGRA186_MAX_REGISTER_ADDR,
> -	.cache_type		= REGCACHE_FLAT_S,
> +	.cache_type		= REGCACHE_FLAT,
>   };
>   
>   static const struct regmap_config tegra264_ahub_regmap_config = {
> @@ -2094,7 +2094,7 @@ static const struct regmap_config tegra264_ahub_regmap_config = {
>   	.reg_stride		= 4,
>   	.writeable_reg		= tegra264_ahub_wr_reg,
>   	.max_register		= TEGRA264_MAX_REGISTER_ADDR,
> -	.cache_type		= REGCACHE_FLAT_S,
> +	.cache_type		= REGCACHE_FLAT,
>   };
>   
>   static const struct tegra_ahub_soc_data soc_data_tegra210 = {


Acked-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon
-- 
nvpublic

Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub

Posted by Jon Hunter 1 month ago

Hi Mark,

On 17/12/2025 13:40, Jon Hunter wrote:
> 
> On 17/12/2025 13:25, Sheetal . wrote:
>> From: sheetal <sheetal@nvidia.com>
>>
>> Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
>> in tegra210_ahub") attempted to fix the uninitialized flat cache warning
>> that is observed for the Tegra210 AHUB driver. However, the change broke
>> various audio tests because an -EBUSY error is returned when accessing
>> registers from cache before they are read from hardware. Revert this
>> change for now, until a proper fix is available.
>>
>> Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache 
>> warning in tegra210_ahub")
>> Signed-off-by: sheetal <sheetal@nvidia.com>
>> ---
>>   sound/soc/tegra/tegra210_ahub.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/ 
>> tegra210_ahub.c
>> index 261d9067d27b..e795907a3963 100644
>> --- a/sound/soc/tegra/tegra210_ahub.c
>> +++ b/sound/soc/tegra/tegra210_ahub.c
>> @@ -2077,7 +2077,7 @@ static const struct regmap_config 
>> tegra210_ahub_regmap_config = {
>>       .val_bits        = 32,
>>       .reg_stride        = 4,
>>       .max_register        = TEGRA210_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct regmap_config tegra186_ahub_regmap_config = {
>> @@ -2085,7 +2085,7 @@ static const struct regmap_config 
>> tegra186_ahub_regmap_config = {
>>       .val_bits        = 32,
>>       .reg_stride        = 4,
>>       .max_register        = TEGRA186_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct regmap_config tegra264_ahub_regmap_config = {
>> @@ -2094,7 +2094,7 @@ static const struct regmap_config 
>> tegra264_ahub_regmap_config = {
>>       .reg_stride        = 4,
>>       .writeable_reg        = tegra264_ahub_wr_reg,
>>       .max_register        = TEGRA264_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct tegra_ahub_soc_data soc_data_tegra210 = {
> 
> 
> Acked-by: Jon Hunter <jonathanh@nvidia.com>

Now we are into the new year, I just wanted to send a reminder for this 
fix. We need to get this revert into v6.19.

Thanks!
Jon

-- 
nvpublic

Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub

Posted by Mark Brown 1 month ago

On Mon, Jan 05, 2026 at 04:06:22PM +0000, Jon Hunter wrote:

> Now we are into the new year, I just wanted to send a reminder for this fix.
> We need to get this revert into v6.19.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.