Use sysfs_emit() instead of sprintf() in sysfs attribute show functions.
sysfs_emit() is the recommended API for sysfs output as it provides buffer
overflow protection and proper formatting.
No functional changes.
Signed-off-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
---
drivers/rpmsg/qcom_smd.c | 2 +-
drivers/rpmsg/rpmsg_char.c | 6 +++---
drivers/rpmsg/rpmsg_core.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 42594f5ee438..2793096aba45 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1458,7 +1458,7 @@ static ssize_t rpmsg_name_show(struct device *dev,
{
struct qcom_smd_edge *edge = to_smd_edge(dev);
- return sprintf(buf, "%s\n", edge->name);
+ return sysfs_emit(buf, "%s\n", edge->name);
}
static DEVICE_ATTR_RO(rpmsg_name);
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
index 96fcdd2d7093..3287e7941c8c 100644
--- a/drivers/rpmsg/rpmsg_char.c
+++ b/drivers/rpmsg/rpmsg_char.c
@@ -365,7 +365,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr,
{
struct rpmsg_eptdev *eptdev = dev_get_drvdata(dev);
- return sprintf(buf, "%s\n", eptdev->chinfo.name);
+ return sysfs_emit(buf, "%s\n", eptdev->chinfo.name);
}
static DEVICE_ATTR_RO(name);
@@ -374,7 +374,7 @@ static ssize_t src_show(struct device *dev, struct device_attribute *attr,
{
struct rpmsg_eptdev *eptdev = dev_get_drvdata(dev);
- return sprintf(buf, "%d\n", eptdev->chinfo.src);
+ return sysfs_emit(buf, "%d\n", eptdev->chinfo.src);
}
static DEVICE_ATTR_RO(src);
@@ -383,7 +383,7 @@ static ssize_t dst_show(struct device *dev, struct device_attribute *attr,
{
struct rpmsg_eptdev *eptdev = dev_get_drvdata(dev);
- return sprintf(buf, "%d\n", eptdev->chinfo.dst);
+ return sysfs_emit(buf, "%d\n", eptdev->chinfo.dst);
}
static DEVICE_ATTR_RO(dst);
diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
index 96964745065b..bcfd17e5309e 100644
--- a/drivers/rpmsg/rpmsg_core.c
+++ b/drivers/rpmsg/rpmsg_core.c
@@ -348,7 +348,7 @@ field##_show(struct device *dev, \
{ \
struct rpmsg_device *rpdev = to_rpmsg_device(dev); \
\
- return sprintf(buf, format_string, rpdev->path); \
+ return sysfs_emit(buf, format_string, rpdev->path); \
} \
static DEVICE_ATTR_RO(field);
@@ -395,7 +395,7 @@ static ssize_t modalias_show(struct device *dev,
if (len != -ENODEV)
return len;
- return sprintf(buf, RPMSG_DEVICE_MODALIAS_FMT "\n", rpdev->id.name);
+ return sysfs_emit(buf, RPMSG_DEVICE_MODALIAS_FMT "\n", rpdev->id.name);
}
static DEVICE_ATTR_RO(modalias);
--
2.43.0