These casts are used to remove const for no good reason. Fix the types
instead.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/i2c/busses/i2c-rtl9300.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rtl9300.c b/drivers/i2c/busses/i2c-rtl9300.c
index 4723e48cfe18..f2aa341a7cdd 100644
--- a/drivers/i2c/busses/i2c-rtl9300.c
+++ b/drivers/i2c/busses/i2c-rtl9300.c
@@ -129,7 +129,7 @@ static int rtl9310_i2c_select_scl(struct rtl9300_i2c *i2c, u8 scl)
static int rtl9300_i2c_config_chan(struct rtl9300_i2c *i2c, struct rtl9300_i2c_chan *chan)
{
- struct rtl9300_i2c_drv_data *drv_data;
+ const struct rtl9300_i2c_drv_data *drv_data;
int ret;
if (i2c->sda_num == chan->sda_num)
@@ -139,7 +139,7 @@ static int rtl9300_i2c_config_chan(struct rtl9300_i2c *i2c, struct rtl9300_i2c_c
if (ret)
return ret;
- drv_data = (struct rtl9300_i2c_drv_data *)device_get_match_data(i2c->dev);
+ drv_data = device_get_match_data(i2c->dev);
ret = drv_data->select_scl(i2c, i2c->scl_num);
if (ret)
return ret;
@@ -372,7 +372,7 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct rtl9300_i2c *i2c;
struct fwnode_handle *child;
- struct rtl9300_i2c_drv_data *drv_data;
+ const struct rtl9300_i2c_drv_data *drv_data;
struct reg_field fields[F_NUM_FIELDS];
u32 clock_freq, scl_num, sda_num;
int ret, i = 0;
@@ -399,7 +399,7 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, i2c);
- drv_data = (struct rtl9300_i2c_drv_data *)device_get_match_data(i2c->dev);
+ drv_data = device_get_match_data(i2c->dev);
if (device_get_child_node_count(dev) > drv_data->max_nchan)
return dev_err_probe(dev, -EINVAL, "Too many channels\n");
--
2.52.0
Hi Rosen,
On 17/12/2025 19:30, Rosen Penev wrote:
> These casts are used to remove const for no good reason. Fix the types
> instead.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> drivers/i2c/busses/i2c-rtl9300.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-rtl9300.c b/drivers/i2c/busses/i2c-rtl9300.c
> index 4723e48cfe18..f2aa341a7cdd 100644
> --- a/drivers/i2c/busses/i2c-rtl9300.c
> +++ b/drivers/i2c/busses/i2c-rtl9300.c
> @@ -129,7 +129,7 @@ static int rtl9310_i2c_select_scl(struct rtl9300_i2c *i2c, u8 scl)
>
> static int rtl9300_i2c_config_chan(struct rtl9300_i2c *i2c, struct rtl9300_i2c_chan *chan)
> {
> - struct rtl9300_i2c_drv_data *drv_data;
> + const struct rtl9300_i2c_drv_data *drv_data;
> int ret;
>
> if (i2c->sda_num == chan->sda_num)
> @@ -139,7 +139,7 @@ static int rtl9300_i2c_config_chan(struct rtl9300_i2c *i2c, struct rtl9300_i2c_c
> if (ret)
> return ret;
>
> - drv_data = (struct rtl9300_i2c_drv_data *)device_get_match_data(i2c->dev);
> + drv_data = device_get_match_data(i2c->dev);
> ret = drv_data->select_scl(i2c, i2c->scl_num);
> if (ret)
> return ret;
> @@ -372,7 +372,7 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct rtl9300_i2c *i2c;
> struct fwnode_handle *child;
> - struct rtl9300_i2c_drv_data *drv_data;
> + const struct rtl9300_i2c_drv_data *drv_data;
> struct reg_field fields[F_NUM_FIELDS];
> u32 clock_freq, scl_num, sda_num;
> int ret, i = 0;
> @@ -399,7 +399,7 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, i2c);
>
> - drv_data = (struct rtl9300_i2c_drv_data *)device_get_match_data(i2c->dev);
> + drv_data = device_get_match_data(i2c->dev);
> if (device_get_child_node_count(dev) > drv_data->max_nchan)
> return dev_err_probe(dev, -EINVAL, "Too many channels\n");
>
© 2016 - 2026 Red Hat, Inc.