spi: realtek-rtl-snand: assign of_node instead of device

[PATCH] spi: realtek-rtl-snand: assign of_node instead of device

Posted by Rosen Penev 1 day, 7 hours ago

This driver is OF only. No need for device_set_node.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/spi/spi-realtek-rtl-snand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-realtek-rtl-snand.c b/drivers/spi/spi-realtek-rtl-snand.c
index 741cf2af3e91..6b857742b301 100644
--- a/drivers/spi/spi-realtek-rtl-snand.c
+++ b/drivers/spi/spi-realtek-rtl-snand.c
@@ -400,7 +400,7 @@ static int rtl_snand_probe(struct platform_device *pdev)
 	ctrl->mem_ops = &rtl_snand_mem_ops;
 	ctrl->bits_per_word_mask = SPI_BPW_MASK(8);
 	ctrl->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_DUAL | SPI_TX_QUAD;
-	device_set_node(&ctrl->dev, dev_fwnode(dev));
+	ctrl->dev.of_node = dev->of_node;
 
 	return devm_spi_register_controller(dev, ctrl);
 }
-- 
2.52.0

Re: [PATCH] spi: realtek-rtl-snand: assign of_node instead of device

Posted by Mark Brown 1 day, 3 hours ago

On Tue, Dec 16, 2025 at 10:26:35PM -0800, Rosen Penev wrote:
> This driver is OF only. No need for device_set_node.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

What's the benefit here?  This creates a barrier to adding support for
other interfaces and I can't identify a problem it solves.